gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-28 05:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove our custom hashmap

Browse Source
This commit is contained in:
Rangi42
2024-02-20 21:30:29 -05:00
committed by Sylvie
parent 95e7dac9a6
commit d53bba97e8
7 changed files with 5 additions and 204 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/asm/charmap-inheritance.asm
View File

@@ -13,7 +13,7 @@ SECTION "test", ROM0
charmap "<FAR>", $08
; At this point, enough nodes were allocated for 'foo' to be reallocated.
; Its value in the charmaps' hashmap should have been updated too,
; Its value in the charmaps' std::map should have been updated too,
; so that usages of 'foo' will not segfault.
; This uses 'foo; by switching to it.

7
test/asm/sym-collision.asm
View File

@@ -1,9 +1,8 @@
; Hashmap collisions are pretty poorly-tested code path...
; At some point, `PURGE` would malfunction with them
SECTION "Collision course", OAM[$FE00]
; All the following symbols collide!
; All the following symbols used to collide with our custom hashmap,
; which at some point caused `PURGE` to malfunction with them.
; We now use C++ `std::map` which reliably handles collisions.
aqfj: ds 1 ; Give them different addresses
cxje: ds 1
dgsd: ds 1

2
test/asm/sym-collision.err
View File

@@ -1,3 +1,3 @@
error: sym-collision.asm(26):
error: sym-collision.asm(25):
Interpolated symbol "dork" does not exist
error: Assembly aborted (1 error)!