gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-22 19:22:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Phrase error messages as "Failed to", not "Could not" or "Couldn't" (#1298)

Browse Source
This commit is contained in:
Sylvie
2024-02-18 08:52:31 -05:00
committed by GitHub
parent ef0d973187
commit d71a161bc9
12 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/gfx/pal_spec.cpp
View File

@@ -468,7 +468,7 @@ static void parseACOFile(std::filebuf &file) {
char buf[10];
if (file.sgetn(buf, 2) != 2) {
error("Couldn't read ACO file version");
error("Failed to read ACO file version");
return;
}
if (readBE<uint16_t>(buf) != 1) {
@@ -477,7 +477,7 @@ static void parseACOFile(std::filebuf &file) {
}
if (file.sgetn(buf, 2) != 2) {
error("Couldn't read number of colors in palette file");
error("Failed to read number of colors in palette file");
return;
}
uint16_t nbColors = readBE<uint16_t>(buf);

2
src/gfx/process.cpp
View File

@@ -606,7 +606,7 @@ static std::tuple<DefaultInitVec<size_t>, std::vector<Palette>>
if (iter == palettes.end()) {
assert(!protoPal.empty());
error("Could not fit tile colors [%s] in specified palettes", listColors(protoPal));
error("Failed to fit tile colors [%s] in specified palettes", listColors(protoPal));
bad = true;
}
mappings[i] = iter - palettes.begin(); // Bogus value, but whatever

4
src/gfx/reverse.cpp
View File

@@ -246,11 +246,11 @@ void reverse() {
const_cast<png_voidp>(static_cast<void const *>(pngFile.c_str(options.input))), pngError,
pngWarning);
if (!png) {
fatal("Couldn't create PNG write struct: %s", strerror(errno));
fatal("Failed to create PNG write struct: %s", strerror(errno));
}
png_infop pngInfo = png_create_info_struct(png);
if (!pngInfo) {
fatal("Couldn't create PNG info struct: %s", strerror(errno));
fatal("Failed to create PNG info struct: %s", strerror(errno));
}
png_set_write_fn(png, &pngFile, writePng, flushPng);