From e05321356b68a1736d5d304bab0ee2bc4b39b7bf Mon Sep 17 00:00:00 2001
From: ISSOtm <eldredhabert0@gmail.com>
Date: Mon, 31 Aug 2020 21:33:53 +0200
Subject: [PATCH] Fix truncation warning when adding charmap mapping

It used to warn when mapping negative values
---
 src/asm/asmy.y | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/asm/asmy.y b/src/asm/asmy.y
index 8cb98574..0cfcfc3f 100644
--- a/src/asm/asmy.y
+++ b/src/asm/asmy.y
@@ -1090,10 +1090,10 @@ incbin		: T_POP_INCBIN string {
 ;
 
 charmap		: T_POP_CHARMAP string ',' const {
-			if (($4 & 0xFF) != $4)
+			if ($4 < INT8_MIN || $4 > UINT8_MAX)
 				warning(WARNING_TRUNCATION, "Expression must be 8-bit");
 
-			if (charmap_Add($2, $4 & 0xFF) == -1)
+			if (charmap_Add($2, (uint8_t)$4) == -1)
 				yyerror("Error adding new charmap mapping: %s\n", strerror(errno));
 		}
 ;