Add more RGBLINK tests (#1639)

This commit is contained in:
Rangi
2025-01-29 12:53:44 -05:00
committed by GitHub
parent f61019dd68
commit e20347e38c
6 changed files with 26 additions and 13 deletions

View File

@@ -239,7 +239,7 @@ static void readPatch(
tryReadLong(
nodeID,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s node ID: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s node ID: %s",
fileName,
sectName.c_str(),
i
@@ -248,7 +248,7 @@ static void readPatch(
tryReadLong(
patch.lineNo,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s line number: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s line number: %s",
fileName,
sectName.c_str(),
i
@@ -256,7 +256,7 @@ static void readPatch(
tryReadLong(
patch.offset,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s offset: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s offset: %s",
fileName,
sectName.c_str(),
i
@@ -264,7 +264,7 @@ static void readPatch(
tryReadLong(
patch.pcSectionID,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s PC offset: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s PC offset: %s",
fileName,
sectName.c_str(),
i
@@ -272,7 +272,7 @@ static void readPatch(
tryReadLong(
patch.pcOffset,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s PC offset: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s PC offset: %s",
fileName,
sectName.c_str(),
i
@@ -281,7 +281,7 @@ static void readPatch(
PatchType,
type,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s type: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s type: %s",
fileName,
sectName.c_str(),
i
@@ -290,7 +290,7 @@ static void readPatch(
tryReadLong(
rpnSize,
file,
"%s: Unable to read \"%s\"'s patch #%" PRIu32 "'s RPN size: %s",
"%s: Cannot read \"%s\"'s patch #%" PRIu32 "'s RPN size: %s",
fileName,
sectName.c_str(),
i

View File

@@ -258,7 +258,7 @@ static void doSanityChecks(Section &section) {
error(
nullptr,
0,
"%s: ROMX sections must be in bank 1 (if any) with option -t",
"Section \"%s\" has type ROMX, which must be in bank 1 (if any) with option `-t`",
section.name.c_str()
);
} else {
@@ -270,7 +270,7 @@ static void doSanityChecks(Section &section) {
error(
nullptr,
0,
"%s: WRAMX sections must be in bank 1 with options -w or -d",
"Section \"%s\" has type WRAMX, which must be in bank 1 with options `-w` or `-d`",
section.name.c_str()
);
} else {
@@ -278,7 +278,12 @@ static void doSanityChecks(Section &section) {
}
}
if (isDmgMode && section.type == SECTTYPE_VRAM && section.bank == 1) {
error(nullptr, 0, "%s: VRAM bank 1 can't be used with option -d", section.name.c_str());
error(
nullptr,
0,
"Section \"%s\" has type VRAM, which must be in bank 0 with option `-d`",
section.name.c_str()
);
}
// Check if alignment is reasonable, this is important to avoid UB
@@ -292,7 +297,7 @@ static void doSanityChecks(Section &section) {
error(
nullptr,
0,
"%s: %s sections cannot be aligned to $%04x bytes",
"Section \"%s\" has type %s, which cannot be aligned to $%04x bytes",
section.name.c_str(),
sectionTypeInfo[section.type].name.c_str(),
section.alignMask + 1