Clean up #includes

Remove unused headers, and avoid relying on transitive inclusions

`include-what-you-use` has been very useful for this!

src/link/assign.cpp

@@ -2,7 +2,6 @@
 
 #include "link/assign.hpp"
 
-#include <algorithm>
 #include <deque>
 #include <inttypes.h>
 #include <stdio.h>
@@ -14,9 +13,9 @@
 #include "helpers.hpp"
 #include "itertools.hpp"
 #include "linkdefs.hpp"
+#include "platform.hpp"
 
 #include "link/main.hpp"
-#include "link/object.hpp"
 #include "link/output.hpp"
 #include "link/section.hpp"
 #include "link/symbol.hpp"

src/link/object.cpp

@@ -2,7 +2,6 @@
 
 #include "link/object.hpp"
 
-#include <algorithm>
 #include <deque>
 #include <errno.h>
 #include <inttypes.h>
@@ -17,11 +16,11 @@
 #include "error.hpp"
 #include "helpers.hpp"
 #include "linkdefs.hpp"
+#include "platform.hpp"
 #include "version.hpp"
 
 #include "link/assign.hpp"
 #include "link/main.hpp"
-#include "link/patch.hpp"
 #include "link/sdas_obj.hpp"
 #include "link/section.hpp"
 #include "link/symbol.hpp"

src/link/output.cpp

@@ -13,8 +13,9 @@
 
 #include "error.hpp"
 #include "extern/utf8decoder.hpp"
-#include "itertools.hpp"
+#include "helpers.hpp"
 #include "linkdefs.hpp"
+#include "platform.hpp"
 
 #include "link/main.hpp"
 #include "link/symbol.hpp"

src/link/patch.cpp

@@ -5,22 +5,15 @@
 #include <assert.h>
 #include <deque>
 #include <inttypes.h>
-#include <limits.h>
 #include <stdint.h>
-#include <stdlib.h>
-#include <string.h>
 #include <variant>
 #include <vector>
 
-#include "error.hpp"
-#include "helpers.hpp"
 #include "opmath.hpp"
-#include "platform.hpp"
 
 #include "linkdefs.hpp"
 
 #include "link/main.hpp"
-#include "link/object.hpp"
 #include "link/section.hpp"
 #include "link/symbol.hpp"
 

src/link/sdas_obj.cpp

@@ -4,16 +4,13 @@
 
 #include <assert.h>
 #include <ctype.h>
-#include <errno.h>
 #include <inttypes.h>
 #include <memory>
 #include <stdint.h>
-#include <stdlib.h>
 #include <string.h>
 #include <tuple>
 #include <variant>
 
-#include "helpers.hpp"
 #include "linkdefs.hpp"
 #include "platform.hpp"
 

src/link/section.cpp

@@ -9,6 +9,7 @@
 #include <unordered_map>
 
 #include "error.hpp"
+#include "helpers.hpp"
 
 std::vector<std::unique_ptr<Section>> sectionList;
 std::unordered_map<std::string, size_t> sectionMap; // Indexes into `sectionList`

src/link/symbol.cpp

@@ -2,15 +2,10 @@
 
 #include "link/symbol.hpp"
 
-#include <inttypes.h>
 #include <stdlib.h>
 #include <unordered_map>
 
-#include "error.hpp"
-#include "helpers.hpp"
-
 #include "link/main.hpp"
-#include "link/object.hpp"
 #include "link/section.hpp"
 
 std::unordered_map<std::string, Symbol *> symbols;