From e9c800b3bef90bb8e1a3a65c981d5fc0efd159ad Mon Sep 17 00:00:00 2001 From: Rangi Date: Sat, 12 Sep 2026 14:17:33 -0400 Subject: [PATCH] Fix reversing 1bpp images Fixes #2075 --- src/gfx/reverse.cpp | 2 +- test/gfx/reverse_1bit_palette.1bpp | 1 + test/gfx/reverse_1bit_palette.flags | 1 + test/gfx/reverse_1bit_palette.pal | Bin 0 -> 4 bytes 4 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 test/gfx/reverse_1bit_palette.1bpp create mode 100644 test/gfx/reverse_1bit_palette.flags create mode 100644 test/gfx/reverse_1bit_palette.pal diff --git a/src/gfx/reverse.cpp b/src/gfx/reverse.cpp index 9d6a6c35..a99609e7 100644 --- a/src/gfx/reverse.cpp +++ b/src/gfx/reverse.cpp @@ -569,7 +569,7 @@ void reverse() { // If vertically mirrored, fetch the bytes from the other end uint8_t realY = (attribute & 0x40 ? 7 - y : y) * options.bitDepth; uint8_t bitplane0 = tileData[realY]; - uint8_t bitplane1 = options.bitDepth == 2 ? tileData[realY + 1] : bitplane0; + uint8_t bitplane1 = options.bitDepth == 2 ? tileData[realY + 1] : 0; if (attribute & 0x20) { // Handle horizontal flip bitplane0 = flipTable[bitplane0]; bitplane1 = flipTable[bitplane1]; diff --git a/test/gfx/reverse_1bit_palette.1bpp b/test/gfx/reverse_1bit_palette.1bpp new file mode 100644 index 00000000..0a4b2c96 --- /dev/null +++ b/test/gfx/reverse_1bit_palette.1bpp @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/test/gfx/reverse_1bit_palette.flags b/test/gfx/reverse_1bit_palette.flags new file mode 100644 index 00000000..e42e920a --- /dev/null +++ b/test/gfx/reverse_1bit_palette.flags @@ -0,0 +1 @@ +-p reverse_1bit_palette.pal diff --git a/test/gfx/reverse_1bit_palette.pal b/test/gfx/reverse_1bit_palette.pal new file mode 100644 index 0000000000000000000000000000000000000000..e8fb40dd9cbbb6019e8dba2ad6106332f7b1850d GIT binary patch literal 4 Lcmb1VV5k8A0Q>-) literal 0 HcmV?d00001