gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check "left" boundary as well in isLocationSuitable

Browse Source 
"fixed" and "aligned" location checking advanced the target location to places
regardless of the associated free space, potentially breaking the assumption
that the location was always further in memory than the free space's base.

Rather than adding more code to try keeping that assumption true, harden
`isLocationSuitable` and handle that case as well.
This commit is contained in:
ISSOtm
2020-02-03 20:57:12 +01:00
parent 4d2379b3df
commit f2be601a13
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/link/assign.c
View File

@@ -135,6 +135,8 @@ static bool isLocationSuitable(struct Section const *section,
if (section->isAlignFixed && location->address & section->alignMask)
return false;
if (location->address < freeSpace->address)
return false;
return location->address + section->size
<= freeSpace->address + freeSpace->size;
}