diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 5cbadc62..dfc2c36f 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -232,16 +232,15 @@ Each one is a binary RNG file which is passed to the `rgbgfx_test` program. Each `.cfg` file corresponds to one test. Each one defines the parameters for a real external project that builds using RGBDS. -1. Make sure the downstream project supports +1. Ensure that the downstream project supports a `RGBDS` variable to build with + a non-system copy of RGBDS in some directory, i.e. make <target> RGBDS=<path/to/rgbds/>. - While the test suite supports any Make target name, only - [Make](//gnu.org/software/make) is currently supported, and the Makefile must - support a `RGBDS` variable to use a non-system RGBDS directory. + Only [GNU Make](https://www.gnu.org/software/make/) is currently supported. 2. Create the new `.cfg` file, following the existing ones. If an external project does not support `make RGBDS=`, or otherwise fails to -build with current RGBDS, then then you can edit the project to build correctly, -and create a patch with `git diff` to be committed as +build with current RGBDS, then you can edit the project to build correctly, and +create a patch with `git diff` to be committed as test/external/patches/<project>.patch. ## Container images diff --git a/test/external/test.sh b/test/external/test.sh index 8ee76901..a5345ae6 100755 --- a/test/external/test.sh +++ b/test/external/test.sh @@ -22,7 +22,7 @@ if ! cd "$EXT_TEST_REPO"; then fi RGBDS_PATH="RGBDS=../../../" -make clean $RGBDS_PATH +git clean -fdx # Clean any previous build products so `make` rebuilds everything from scratch. make -j4 "$EXT_TEST_TARGET" $RGBDS_PATH hash="$(sha1sum -b "$EXT_TEST_FILE" | head -c 40)"