gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use uncommented sizes for pointer-to-array arguments (#1329)

Browse Source 
This is syntactically valid despite not being enforced, and
is a feature we already use elsewhere.
This commit is contained in:
Sylvie
2024-03-03 19:43:08 -05:00
committed by GitHub
parent 0da216897a
commit f8dab23e8f
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/asm/symbol.hpp
View File

@@ -70,7 +70,7 @@ void sym_SetExportAll(bool set);
Symbol *sym_AddLocalLabel(char const *symName); Symbol *sym_AddLocalLabel(char const *symName);
Symbol *sym_AddLabel(char const *symName); Symbol *sym_AddLabel(char const *symName);
Symbol *sym_AddAnonLabel(); Symbol *sym_AddAnonLabel();
void sym_WriteAnonLabelName(char buf[/* MAXSYMLEN + 1 */], uint32_t ofs, bool neg); void sym_WriteAnonLabelName(char buf[MAXSYMLEN + 1], uint32_t ofs, bool neg);
void sym_Export(char const *symName); void sym_Export(char const *symName);
Symbol *sym_AddEqu(char const *symName, int32_t value); Symbol *sym_AddEqu(char const *symName, int32_t value);
Symbol *sym_RedefEqu(char const *symName, int32_t value); Symbol *sym_RedefEqu(char const *symName, int32_t value);

2
src/asm/symbol.cpp
View File

@@ -493,7 +493,7 @@ Symbol *sym_AddAnonLabel()
} }
// Write an anonymous label's name to a buffer // Write an anonymous label's name to a buffer
void sym_WriteAnonLabelName(char buf[/* MAXSYMLEN + 1 */], uint32_t ofs, bool neg) void sym_WriteAnonLabelName(char buf[MAXSYMLEN + 1], uint32_t ofs, bool neg)
{ {
uint32_t id = 0; uint32_t id = 0;

5
test/gfx/randtilegen.cpp
View File

@@ -75,7 +75,7 @@ static void generate_tile_attributes(Attributes *attributes) {
attributes->nbColors = popcount[pal]; attributes->nbColors = popcount[pal];
} }
static void generate_tile_data(unsigned char tiledata[/* 8 */][8], unsigned colorcount) { static void generate_tile_data(unsigned char tiledata[8][8], unsigned colorcount) {
switch (colorcount) { switch (colorcount) {
case 2: // 1bpp case 2: // 1bpp
for (uint8_t y = 0; y < 8; y++) { for (uint8_t y = 0; y < 8; y++) {
@@ -104,9 +104,8 @@ static void generate_tile_data(unsigned char tiledata[/* 8 */][8], unsigned colo
} }
} }
// Can't mark as `const`, as the array type is otherwise not compatible (augh)
static void static void
copy_tile_data(unsigned char destination[/* 8 */][8], unsigned char /* const */ source[/* 8 */][8]) { copy_tile_data(unsigned char destination[8][8], unsigned char const source[8][8]) {
// Apply a random rotation to the copy // Apply a random rotation to the copy
// coord ^ 7 = inverted coordinate; coord ^ 0 = regular coordinate // coord ^ 7 = inverted coordinate; coord ^ 0 = regular coordinate
unsigned xmask = getRandomBits(1) * 7; unsigned xmask = getRandomBits(1) * 7;