gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer empty braces to semicolons for empty loop bodies

Browse Source
This commit is contained in:
Rangi42
2025-01-17 00:20:33 -05:00
parent a85d6b3b57
commit fac5e35d24
3 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/asm/charmap.cpp
View File

@@ -168,8 +168,7 @@ bool charmap_HasChar(std::string const &input) {
std::vector<int32_t> charmap_Convert(std::string const &input) { std::vector<int32_t> charmap_Convert(std::string const &input) {
std::vector<int32_t> output; std::vector<int32_t> output;
for (std::string_view inputView = input; charmap_ConvertNext(inputView, &output);) for (std::string_view inputView = input; charmap_ConvertNext(inputView, &output);) {}
;
return output; return output;
} }

3
src/asm/parser.y
View File

@@ -2577,8 +2577,7 @@ static size_t charlenUTF8(std::string const &str) {
std::string_view view = str; std::string_view view = str;
size_t len; size_t len;
for (len = 0; charmap_ConvertNext(view, nullptr); len++) for (len = 0; charmap_ConvertNext(view, nullptr); len++) {}
;
return len; return len;
} }

9
src/link/patch.cpp
View File

@@ -250,8 +250,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
// `expression` is not guaranteed to be '\0'-terminated. If it is not, // `expression` is not guaranteed to be '\0'-terminated. If it is not,
// `getRPNByte` will have a fatal internal error. // `getRPNByte` will have a fatal internal error.
char const *name = reinterpret_cast<char const *>(expression); char const *name = reinterpret_cast<char const *>(expression);
while (getRPNByte(expression, size, patch)) while (getRPNByte(expression, size, patch)) {}
;
if (Section const *sect = sect_GetSection(name); !sect) { if (Section const *sect = sect_GetSection(name); !sect) {
error( error(
@@ -281,8 +280,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
case RPN_SIZEOF_SECT: { case RPN_SIZEOF_SECT: {
// This has assumptions commented in the `RPN_BANK_SECT` case above. // This has assumptions commented in the `RPN_BANK_SECT` case above.
char const *name = reinterpret_cast<char const *>(expression); char const *name = reinterpret_cast<char const *>(expression);
while (getRPNByte(expression, size, patch)) while (getRPNByte(expression, size, patch)) {}
;
if (Section const *sect = sect_GetSection(name); !sect) { if (Section const *sect = sect_GetSection(name); !sect) {
error( error(
@@ -302,8 +300,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
case RPN_STARTOF_SECT: { case RPN_STARTOF_SECT: {
// This has assumptions commented in the `RPN_BANK_SECT` case above. // This has assumptions commented in the `RPN_BANK_SECT` case above.
char const *name = reinterpret_cast<char const *>(expression); char const *name = reinterpret_cast<char const *>(expression);
while (getRPNByte(expression, size, patch)) while (getRPNByte(expression, size, patch)) {}
;
if (Section const *sect = sect_GetSection(name); !sect) { if (Section const *sect = sect_GetSection(name); !sect) {
error( error(