gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-24 14:47:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow defining labels outside sections (#2013)

Browse Source 
Creating a `Symbol` with `type = SYM_LABEL` but `section = nullptr`
is inconsistent and dangerous. I was not able to cause any buggy
behavior so far, but it's safer and reasonable to not create such
a symbol in the first place.

The main consequence is that `DEF(LabelOutsideSection)` will now
evaluate as 0.
This commit is contained in:
Rangi
2026-07-06 16:18:42 -04:00
committed by GitHub
parent 46a6966b70
commit fe3b238dea
12 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/asm/symbol.cpp
+8 -5
View File
@@ -537,6 +537,12 @@ Symbol *sym_AddVar(InternedStr symName, int32_t value) {
static Symbol *addLabel(InternedStr symName) {
assumeAlreadyExpanded(symName);
Section *section = sect_GetSymbolSection();
if (!section) {
error("Cannot define label `%s` outside of a `SECTION`", symName.c_str());
return nullptr;
}
Symbol *sym = sym_FindExactSymbol(symName);
if (!sym) {
@@ -547,6 +553,7 @@ static Symbol *addLabel(InternedStr symName) {
} else {
updateSymbolFilename(*sym);
}
// If the symbol already exists as a ref, just "take over" it
sym->type = SYM_LABEL;
sym->data = static_cast<int32_t>(sect_GetSymbolOffset());
@@ -554,11 +561,7 @@ static Symbol *addLabel(InternedStr symName) {
if (options.exportAll && !symName.str().starts_with('!')) {
sym->isExported = true;
}
sym->section = sect_GetSymbolSection();
if (sym && !sym->section) {
error("Label `%s` created outside of a `SECTION`", symName.c_str());
}
sym->section = section;
return sym;
}