gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-12-01 15:27:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,592 Commits 3 Branches 49 Tags
20b7b591d4d459dc95c407f8167fae15c35e5301
Commit Graph

199 Commits

Author SHA1 Message Date
ISSOtm
12ba057b4f Check that colour slot is non-empty before checking for gray-ness 
This is otherwise UB, and trips a GLIBCXX assertion (when enabled).
 2022-10-11 21:39:32 +02:00
ISSOtm
d90a7e4302 Terminate RGBGFX when opening a file fails 
`std::filebuf::open`'s result must be checked, though that's not obvious.
 2022-10-04 13:58:05 +02:00
ISSOtm
b8307432b8 Fix use of bitwise OR instead of logical 
Thanks, Clang!
 2022-10-02 02:50:38 -04:00
Rangi
969412af24 Parse HEX palettes (#1081) 
Addresses one item of #1065
 2022-10-01 12:45:00 -04:00
Rangi
ddb1d0b6aa Parse GPL palettes, and fix PSP palette parsing (#1080) 
Addresses one item of #1065
 2022-10-01 10:46:13 +02:00
Rangi
d86d24bdc1 Remove legacy support for generating a palette with unused colors 
If you need an explicit set of colors, possibly including
unused ones, use `-c`.

Fixes #1062
 2022-10-01 00:51:14 +02:00
Eldred Habert
a1a919579c Add support for GBC palette dumps to -c (#1075) 
Fixes #1063
 2022-09-30 17:09:28 -04:00
Rangi
5ad8a8c958 Warn when a duplicate CLI argument overrides a previous one (#1053) 
Fixes #1050
 2022-09-25 10:04:30 +02:00
Rangi
fa13611bbf Make comments more consistent 
- Changes most `/* comments */` to `// comments`
- Changes `/**` block comments consistently to `/*`
- Adds consistent license comments to all files

Also renames `T_POP_SET` to `T_Z80_SET`
 2022-08-30 07:51:32 +02:00
ISSOtm
92eb0a133b Allow rgbgfx -r to read an infinite amount of tiles without tilemap 
Previously, indices would be wrapped after 256 even without a tilemap;
since RGBGFX can generate arbitrarily large tile data if `-N` is not used,
it should be possible to read those in.

Of course, this won't work if a tilemap is provided, but such "big blobs"
can't generate a meaningful tilemap anyway.
 2022-08-04 20:50:08 +02:00
ISSOtm
b02ccf8f4a Check before attempting to generate empty image 
This causes a libpng warning then error, but print a better error message
Fixes #1016
 2022-08-04 20:40:20 +02:00
ISSOtm
acb33777c6 Sort RGB colors as specified in the docs 2022-07-10 12:36:10 +02:00
ISSOtm
b53c115ec2 Fix width and height being reported in wrong order 2022-07-10 12:14:24 +02:00
ISSOtm
6a51e39a5c Print error if reverse() fails to open a file 2022-07-10 11:55:56 +02:00
ISSOtm
ca8693690a Cancel -U option 
As it turns out, it is really difficult to implement, and can be dealt with later.
 2022-07-02 17:04:17 +02:00
ISSOtm
87092208bc Stop passing options.columnMajor explicitly everywhere 2022-07-02 17:04:17 +02:00
ISSOtm
0d32775a1f Add more sanity checks when reversing an image 2022-07-02 17:04:17 +02:00
ISSOtm
0df07d3688 Add note on supporting extra pal formats 2022-07-02 17:04:17 +02:00
ISSOtm
3f70372308 Implement slicing input image 2022-07-02 17:04:17 +02:00
ISSOtm
9646f15b59 Add error message for nigh-impossible proto-palette overflow 2022-07-02 17:04:17 +02:00
ISSOtm
973fbb91bc Improve error message when a tile has too many colors 2022-07-02 17:04:17 +02:00
ISSOtm
3f5983358c Add proper error message for bad manual palettes 2022-07-02 17:04:17 +02:00
ISSOtm
7a7126f3b8 Implement bit flipping with a lookup table 
Should improve performance.
This version is cooler, and also does not suffer from iteration limits
 2022-07-02 17:04:17 +02:00
ISSOtm
b4dadd35b6 Use an iterator zip 
Simplifies iterating over tiles and attributes at the same time
 2022-07-02 17:04:17 +02:00
ISSOtm
d9b1402ef8 Fix RGBGFX number parsing 2022-07-02 17:04:17 +02:00
ISSOtm
832e0ec972 Report position in color errors 2022-07-02 17:04:17 +02:00
ISSOtm
a5ed0292b1 Reject colors with ambiguous alpha channel 2022-07-02 17:04:17 +02:00
ISSOtm
05e36767b0 Implement "palette map" output 2022-07-02 17:04:17 +02:00
ISSOtm
c4359c1058 Ignore -b and -N when reversing without tilemap 
These offsets should only be applied to a tile ID read as input... but this ain't one!
 2022-07-02 17:04:17 +02:00
ISSOtm
a77b0b396a Fix grayscale sorting not setting palette size 
A black+white palette would turn into white+transparent, removing black pixels
from the palette (the third slot would be empty, and the 4th slot be set directly)
 2022-07-02 17:04:17 +02:00
ISSOtm
568fb5e4c8 Only report "fusing" different colors once per pair 2022-07-02 17:04:17 +02:00
ISSOtm
57ac07b03e Correctly handle fully-transparent tiles when outputting unoptimized tilemap 2022-07-02 17:04:17 +02:00
ISSOtm
c521233499 Fix ProtoPalette::compare 
Some disjoint sets were mistakenly reported not as such
For example, {0} was considered to include {1}.
 2022-07-02 17:04:17 +02:00
ISSOtm
fcce42d3d2 Avoid sorting proto-palettes breaking mappings 
The sorting was performed without updating the mappings, which broke the world.
We can instead sort the IDs as they are inserted into the packing queue,
which should also be faster than moving the actual proto-pal objects around.
 2022-07-02 17:04:17 +02:00
ISSOtm
f5d4126303 Report when an input "tile" contains too many colors 
Which otherwise trips a later assertion in debug mode (phew!)
and crashes in release mode (oops)
 2022-07-02 17:04:17 +02:00
ISSOtm
78e751f022 Fix reading interlaced PNGs 
Either we let libpng handle the transform, or we don't.
But make up your mind!
 2022-07-02 17:04:17 +02:00
ISSOtm
d569c6392c Avoid initializing the PNG row 
It gets overwritten right after, and uncovers an error in the interlaced read
 2022-07-02 17:04:17 +02:00
ISSOtm
5be2b96b40 Remove incorrect check for reversed image width 
That check was when the image width was in tiles, and another check right below
is the correct equivalent for the new pixel-unit argument
 2022-07-02 17:04:17 +02:00
ISSOtm
7fdfbbbbba Fix inverted condition in tile dedup warning 2022-07-02 17:04:17 +02:00
ISSOtm
7fdc6cbced Fix erroneous tabs in rgbgfx usage text 
Thanks @GreenAndEievui!
 2022-07-02 17:04:17 +02:00
ISSOtm
7927dfd2e3 Remove negative values in parseNumber checking 
Including removal of a dead & useless check.
By the way, fuck integer promotion.
 2022-07-02 17:04:17 +02:00
ISSOtm
b1aec91912 Assert that row size is not null 
Silences some static analysis warning
 2022-07-02 17:04:17 +02:00
ISSOtm
02d957278d Document output formats 2022-07-02 17:04:17 +02:00
ISSOtm
6feb1fb73a Retire -f 2022-07-02 17:04:17 +02:00
ISSOtm
913c3dd711 Accept both colons and semicolons in inline pal spec 2022-07-02 17:04:17 +02:00
ISSOtm
32242e0ff2 Switch from colon separators to semicolon 
As documented, oops
 2022-07-02 17:04:17 +02:00
ISSOtm
91071009a8 Implement some external palette specs 
PSP, ACT, and ACO are complete
 2022-07-02 17:04:17 +02:00
ISSOtm
1da884db15 Handle processing errors appropriately 
Alter the return status accordingly, and print the error counts on exit
 2022-07-02 17:04:17 +02:00
ISSOtm
ef473de75a Explicitly error out if no input image is given 2022-07-02 17:04:17 +02:00
ISSOtm
6b0cab32a6 Implement inline palette spec parsing 2022-07-02 17:04:17 +02:00