rgbds

mirror of https://github.com/gbdev/rgbds.git synced 2026-08-27 00:55:15 +00:00

Files

T

Rangi 604c69e048 Fix palette-packing decant logic to avoid UB from invalid iterator (#2031 )

The "Iterate through the component's color sets, and transfer them"
logic shifted `from.begin()`, which would make subsequent `std::advance`
calls go past `_assigned.end()` and cause UB. This rewrite uses absolute
numeric indexes into `_assigned` to avoid that potential problem.

I haven't been able to craft a test case that actually *reaches*
that piece of logic, and I suspect that it's unreachable given how
we sort and process color sets before decanting, but cannot prove
that; so it stays in. (Maybe if we added 4bpp 16-colors-per-palette
support, it would become reachable?)

2026-07-22 23:48:02 -04:00

color_set.cpp

Fix rgbgfx -Z palette overgeneration on merged color sets (#1912 )

2026-06-07 09:55:05 -04:00

main.cpp

Factor out verboseDo to encapsulate magenta output color

2026-07-13 18:05:55 -04:00

pal_packing.cpp

Fix palette-packing decant logic to avoid UB from invalid iterator (#2031 )

2026-07-22 23:48:02 -04:00

pal_sorting.cpp

Mask blue for consistency (avoids transparent bit bugs)