refactor: physpreset codestyle (#928)

* chore: adjust phys preset code to use similar code style * fix: infinity friction for t6 * fix: t6 phys preset canFloat qboolean * chore: move iw5 phys preset enum strings to enum strings header * chore: add phys preset tests for all games * chore: rename PhysPresetFields headers
2026-07-26 18:00:38 +00:00 · 2026-07-22 21:08:36 +02:00
parent 37bb67a3a5
commit 04b6b5b4bf
33 changed files with 916 additions and 329 deletions
@@ -0,0 +1,87 @@
+
+#include "Game/T5/PhysPreset/PhysPresetInfoStringDumperT5.h"
+
+#include "Game/T5/ObjConstantsT5.h"
+#include "InfoString/InfoString.h"
+#include "SearchPath/MockOutputPath.h"
+#include "SearchPath/MockSearchPath.h"
+
+#include <catch2/catch_approx.hpp>
+#include <catch2/catch_test_macros.hpp>
+
+using namespace T5;
+using namespace Catch;
+
+namespace
+{
+    std::unique_ptr<PhysPreset> CreateTestPhysPreset()
+    {
+        auto physPreset = std::make_unique<PhysPreset>();
+
+        physPreset->name = "test_phys_preset";
+        physPreset->mass = 1.25f;
+        physPreset->bounce = 0.25f;
+        physPreset->friction = PHYS_PRESET_MAX_FRICTION;
+        physPreset->bulletForceScale = 0.5f;
+        physPreset->explosiveForceScale = 0.75f;
+        physPreset->piecesSpreadFraction = 0.125f;
+        physPreset->piecesUpwardVelocity = 64.0f;
+        physPreset->canFloat = 1;
+        physPreset->gravityScale = 2.0f;
+        physPreset->centerOfMassOffset.x = 1.5f;
+        physPreset->centerOfMassOffset.y = 2.5f;
+        physPreset->centerOfMassOffset.z = 3.5f;
+        physPreset->buoyancyBoxMin.x = 4.5f;
+        physPreset->buoyancyBoxMin.y = 5.5f;
+        physPreset->buoyancyBoxMin.z = 6.5f;
+        physPreset->buoyancyBoxMax.x = 7.5f;
+        physPreset->buoyancyBoxMax.y = 8.5f;
+        physPreset->buoyancyBoxMax.z = 9.5f;
+
+        return physPreset;
+    }
+
+    std::string DumpPhysPreset(PhysPreset& physPreset)
+    {
+        Zone dumpingZone("DumpingZone", 0, GameId::T5, GamePlatform::PC);
+        dumpingZone.m_pools.AddAsset(std::make_unique<XAssetInfo<PhysPreset>>(ASSET_TYPE_PHYSPRESET, physPreset.name, &physPreset));
+
+        MockSearchPath dumpingObjPath;
+        MockOutputPath dumpingOutput;
+        AssetDumpingContext dumpingContext(dumpingZone, "", dumpingOutput, dumpingObjPath, std::nullopt);
+        phys_preset::InfoStringDumperT5 dumper;
+        dumper.Dump(dumpingContext);
+
+        const auto* dumpedFile = dumpingOutput.GetMockedFile("physic/test_phys_preset");
+        REQUIRE(dumpedFile != nullptr);
+        return dumpedFile->AsString();
+    }
+
+    TEST_CASE("PhysPreset dumper serializes raw fields (T5)", "[t5][physpreset][system]")
+    {
+        const auto testPhysPreset = CreateTestPhysPreset();
+        std::istringstream dumpedStream(DumpPhysPreset(*testPhysPreset));
+
+        InfoString infoString;
+        REQUIRE(infoString.FromStream(INFO_STRING_PREFIX_PHYS_PRESET, dumpedStream));
+        REQUIRE(infoString.GetValueForKey("mass") == "1250");
+        REQUIRE(infoString.GetValueForKey("bounce") == "0.25");
+        REQUIRE(infoString.GetValueForKey("friction") == "0");
+        REQUIRE(infoString.GetValueForKey("isFrictionInfinity") == "1");
+        REQUIRE(infoString.GetValueForKey("bulletForceScale") == "0.5");
+        REQUIRE(infoString.GetValueForKey("explosiveForceScale") == "0.75");
+        REQUIRE(infoString.GetValueForKey("piecesSpreadFraction") == "0.125");
+        REQUIRE(infoString.GetValueForKey("piecesUpwardVelocity") == "64");
+        REQUIRE(infoString.GetValueForKey("canFloat") == "1");
+        REQUIRE(infoString.GetValueForKey("gravityScale") == "2");
+        REQUIRE(infoString.GetValueForKey("massOffsetX") == "1.5");
+        REQUIRE(infoString.GetValueForKey("massOffsetY") == "2.5");
+        REQUIRE(infoString.GetValueForKey("massOffsetZ") == "3.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMinX") == "4.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMinY") == "5.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMinZ") == "6.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMaxX") == "7.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMaxY") == "8.5");
+        REQUIRE(infoString.GetValueForKey("buoyancyMaxZ") == "9.5");
+    }
+} // namespace