Add ZoneScriptString class to store zone script strings

src/ObjLoading/AssetLoading/AssetLoadingManager.cpp

@@ -13,9 +13,17 @@ bool AssetLoadingManager::LoadAssetFromLoader(const asset_type_t assetType, cons
     return LoadDependency(assetType, assetName) != nullptr;
 }
 
-void AssetLoadingManager::AddAsset(const asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*>& dependencies)
+void AssetLoadingManager::AddAsset(const asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings,
+                                   Zone* zone)
 {
-    m_last_dependency_loaded = m_context.m_zone->m_pools->AddAsset(assetType, assetName, asset, dependencies);
+    m_last_dependency_loaded = m_context.m_zone->m_pools->AddAsset(assetType, assetName, asset, std::move(dependencies), std::move(usedScriptStrings), zone);
+    if (m_last_dependency_loaded == nullptr)
+        std::cout << "Failed to add asset of type \"" << m_context.m_zone->m_pools->GetAssetTypeName(assetType) << "\" to pool: \"" << assetName << "\"" << std::endl;
+}
+
+void AssetLoadingManager::AddAsset(const asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings)
+{
+    m_last_dependency_loaded = m_context.m_zone->m_pools->AddAsset(assetType, assetName, asset, std::move(dependencies), std::move(usedScriptStrings));
     if (m_last_dependency_loaded == nullptr)
         std::cout << "Failed to add asset of type \"" << m_context.m_zone->m_pools->GetAssetTypeName(assetType) << "\" to pool: \"" << assetName << "\"" << std::endl;
 }
@@ -29,8 +37,7 @@ XAssetInfoGeneric* AssetLoadingManager::LoadIgnoredDependency(const asset_type_t
     auto* linkAsset = loader->CreateEmptyAsset(assetName, m_context.m_zone->GetMemory());
     if (linkAsset)
     {
-        std::vector<XAssetInfoGeneric*> dependencies;
+        AddAsset(assetType, assetName, linkAsset, std::vector<XAssetInfoGeneric*>(), std::vector<scr_string_t>());
-        AddAsset(assetType, assetName, linkAsset, dependencies);
         auto* lastDependency = m_last_dependency_loaded;
         m_last_dependency_loaded = nullptr;
         return lastDependency;
@@ -40,7 +47,7 @@ XAssetInfoGeneric* AssetLoadingManager::LoadIgnoredDependency(const asset_type_t
     if (existingAsset)
     {
         std::vector<XAssetInfoGeneric*> dependencies;
-        AddAsset(existingAsset->m_type, existingAsset->m_name, existingAsset->m_ptr, dependencies);
+        AddAsset(existingAsset->m_type, existingAsset->m_name, existingAsset->m_ptr, std::vector<XAssetInfoGeneric*>(), std::vector<scr_string_t>(), existingAsset->m_zone);
         auto* lastDependency = m_last_dependency_loaded;
         m_last_dependency_loaded = nullptr;
         return lastDependency;
@@ -79,7 +86,7 @@ XAssetInfoGeneric* AssetLoadingManager::LoadAssetDependency(const asset_type_t a
                 return nullptr;
         }
 
-        AddAsset(existingAsset->m_type, existingAsset->m_name, existingAsset->m_ptr, dependencies);
+        AddAsset(existingAsset->m_type, existingAsset->m_name, existingAsset->m_ptr, std::move(dependencies), existingAsset->m_used_script_strings, existingAsset->m_zone);
         auto* lastDependency = m_last_dependency_loaded;
         m_last_dependency_loaded = nullptr;
         return lastDependency;

src/ObjLoading/AssetLoading/AssetLoadingManager.h

@@ -14,10 +14,12 @@ class AssetLoadingManager final : public IAssetLoadingManager
     XAssetInfoGeneric* LoadIgnoredDependency(asset_type_t assetType, const std::string& assetName, IAssetLoader* loader);
     XAssetInfoGeneric* LoadAssetDependency(asset_type_t assetType, const std::string& assetName, IAssetLoader* loader);
 
+    void AddAsset(asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone);
+
 public:
     AssetLoadingManager(const std::unordered_map<asset_type_t, std::unique_ptr<IAssetLoader>>& assetLoadersByType, AssetLoadingContext& context);
 
     bool LoadAssetFromLoader(asset_type_t assetType, const std::string& assetName);
-    void AddAsset(asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*>& dependencies) override;
+    void AddAsset(asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings) override;
     XAssetInfoGeneric* LoadDependency(asset_type_t assetType, const std::string& assetName) override;
 };

src/ObjLoading/AssetLoading/IAssetLoadingManager.h

@@ -14,11 +14,10 @@ public:
     IAssetLoadingManager& operator=(const IAssetLoadingManager& other) = default;
     IAssetLoadingManager& operator=(IAssetLoadingManager&& other) noexcept = default;
 
-    virtual void AddAsset(asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*>& dependencies) = 0;
+    virtual void AddAsset(asset_type_t assetType, const std::string& assetName, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings) = 0;
     void AddAsset(const asset_type_t assetType, const std::string& assetName, void* asset)
     {
-        std::vector<XAssetInfoGeneric*> dependencies;
+        AddAsset(assetType, assetName, asset, std::vector<XAssetInfoGeneric*>(), std::vector<scr_string_t>());
-        AddAsset(assetType, assetName, asset, dependencies);
     }
     virtual XAssetInfoGeneric* LoadDependency(asset_type_t assetType, const std::string& assetName) = 0;
 };

src/ObjWriting/Game/IW4/AssetDumpers/AssetDumperVehicle.cpp

@@ -218,8 +218,8 @@ InfoString AssetDumperVehicle::CreateInfoString(XAssetInfo<VehicleDef>* asset)
 {
     InfoStringFromVehicleConverter converter(asset->Asset(), vehicle_fields, std::extent<decltype(vehicle_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
         {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+            assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+            if (scrStr >= asset->m_zone->m_script_strings.Count())
                 return "";
 
             return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/IW4/AssetDumpers/AssetDumperWeapon.cpp

@@ -998,8 +998,8 @@ InfoString AssetDumperWeapon::CreateInfoString(XAssetInfo<WeaponCompleteDef>* as
 
     InfoStringFromWeaponConverter converter(fullDef.get(), weapon_fields, std::extent<decltype(weapon_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
         {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+            assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+            if (scrStr >= asset->m_zone->m_script_strings.Count())
                 return "";
 
             return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperPhysConstraints.cpp

@@ -122,8 +122,8 @@ InfoString AssetDumperPhysConstraints::CreateInfoString(XAssetInfo<PhysConstrain
 
     InfoStringFromPhysConstraintsConverter converter(asset->Asset(), phys_constraints_fields, std::extent<decltype(phys_constraints_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
         {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+            assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+            if (scrStr >= asset->m_zone->m_script_strings.Count())
                 return "";
 
             return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperPhysPreset.cpp

@@ -84,8 +84,8 @@ InfoString AssetDumperPhysPreset::CreateInfoString(XAssetInfo<PhysPreset>* asset
 
     InfoStringFromPhysPresetConverter converter(physPresetInfo, physpreset_fields, std::extent<decltype(physpreset_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
         {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+            assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+            if (scrStr >= asset->m_zone->m_script_strings.Count())
                 return "";
 
             return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperTracer.cpp

@@ -75,8 +75,8 @@ InfoString AssetDumperTracer::CreateInfoString(XAssetInfo<TracerDef>* asset)
 {
     InfoStringFromTracerConverter converter(asset->Asset(), tracer_fields, std::extent<decltype(tracer_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
     {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+        assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+        if (scrStr >= asset->m_zone->m_script_strings.Count())
             return "";
 
         return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperVehicle.cpp

@@ -647,8 +647,8 @@ InfoString AssetDumperVehicle::CreateInfoString(XAssetInfo<VehicleDef>* asset)
 {
     InfoStringFromVehicleConverter converter(asset->Asset(), vehicle_fields, std::extent<decltype(vehicle_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
     {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+        assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+        if (scrStr >= asset->m_zone->m_script_strings.Count())
             return "";
 
         return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperWeapon.cpp

@@ -1386,8 +1386,8 @@ InfoString AssetDumperWeapon::CreateInfoString(XAssetInfo<WeaponVariantDef>* ass
 
     InfoStringFromWeaponConverter converter(fullDef.get(), weapon_fields, std::extent<decltype(weapon_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
     {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+        assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+        if (scrStr >= asset->m_zone->m_script_strings.Count())
             return "";
 
         return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperWeaponAttachment.cpp

@@ -128,8 +128,8 @@ InfoString AssetDumperWeaponAttachment::CreateInfoString(XAssetInfo<WeaponAttach
 {
     InfoStringFromAttachmentConverter converter(asset->Asset(), attachment_fields, std::extent<decltype(attachment_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
     {
-        assert(scrStr < asset->m_zone->m_script_strings.size());
+        assert(scrStr < asset->m_zone->m_script_strings.Count());
-        if (scrStr >= asset->m_zone->m_script_strings.size())
+        if (scrStr >= asset->m_zone->m_script_strings.Count())
             return "";
 
         return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperWeaponAttachmentUnique.cpp

@@ -319,8 +319,8 @@ InfoString AssetDumperWeaponAttachmentUnique::CreateInfoString(XAssetInfo<Weapon
         fullDef.get(), attachment_unique_fields, std::extent<decltype(attachment_unique_fields)>::value,
         [asset](const scr_string_t scrStr) -> std::string
         {
-            assert(scrStr < asset->m_zone->m_script_strings.size());
+            assert(scrStr < asset->m_zone->m_script_strings.Count());
-            if (scrStr >= asset->m_zone->m_script_strings.size())
+            if (scrStr >= asset->m_zone->m_script_strings.Count())
                 return "";
 
             return asset->m_zone->m_script_strings[scrStr];

src/ObjWriting/Game/T6/AssetDumpers/AssetDumperZBarrier.cpp

@@ -178,8 +178,8 @@ InfoString AssetDumperZBarrier::CreateInfoString(XAssetInfo<ZBarrierDef>* asset)
 {
     InfoStringFromZBarrierConverter converter(asset->Asset(), zbarrier_fields, std::extent<decltype(zbarrier_fields)>::value, [asset](const scr_string_t scrStr) -> std::string
     {
-        assert(scrStr < asset->m_zone->m_script_strings.size());
+        assert(scrStr < asset->m_zone->m_script_strings.Count());
-        if (scrStr >= asset->m_zone->m_script_strings.size())
+        if (scrStr >= asset->m_zone->m_script_strings.Count())
             return "";
 
         return asset->m_zone->m_script_strings[scrStr];

src/ZoneCommon/Game/IW4/GameAssetPoolIW4.cpp

@@ -260,7 +260,7 @@ void GameAssetPoolIW4::InitPoolDynamic(const asset_type_t type)
 #undef CASE_INIT_POOL_STATIC
 }
 
-XAssetInfoGeneric* GameAssetPoolIW4::AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies)
+XAssetInfoGeneric* GameAssetPoolIW4::AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone)
 {
     XAsset xAsset{};
 
@@ -271,7 +271,7 @@ XAssetInfoGeneric* GameAssetPoolIW4::AddAssetToPool(asset_type_t type, std::stri
     case assetType: \
     { \
         assert((poolName) != nullptr); \
-        return (poolName)->AddAsset(std::move(name), xAsset.header.headerName, m_zone, dependencies); \
+        return (poolName)->AddAsset(std::move(name), xAsset.header.headerName, zone, std::move(dependencies), std::move(usedScriptStrings)); \
     }
 
     switch (xAsset.type)

src/ZoneCommon/Game/IW4/GameAssetPoolIW4.h

@@ -14,7 +14,7 @@ class GameAssetPoolIW4 final : public ZoneAssetPools
     static const char* ASSET_TYPE_NAMES[];
 
 protected:
-    XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies) override;
+    XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone) override;
 
 public:
     std::unique_ptr<AssetPool<IW4::PhysPreset>> m_phys_preset;

src/ZoneCommon/Game/T6/GameAssetPoolT6.cpp

@@ -329,7 +329,8 @@ void GameAssetPoolT6::InitPoolDynamic(const asset_type_t type)
 #undef CASE_INIT_POOL_STATIC
 }
 
-XAssetInfoGeneric* GameAssetPoolT6::AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies)
+XAssetInfoGeneric* GameAssetPoolT6::AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings,
+                                                   Zone* zone)
 {
     XAsset xAsset{};
 
@@ -340,7 +341,7 @@ XAssetInfoGeneric* GameAssetPoolT6::AddAssetToPool(asset_type_t type, std::strin
     case assetType: \
     { \
         assert((poolName) != nullptr); \
-        return (poolName)->AddAsset(std::move(name), xAsset.header.headerName, m_zone, dependencies); \
+        return (poolName)->AddAsset(std::move(name), xAsset.header.headerName, zone, std::move(dependencies), std::move(usedScriptStrings)); \
     }
 
     switch (xAsset.type)

src/ZoneCommon/Game/T6/GameAssetPoolT6.h

@@ -12,7 +12,7 @@ class GameAssetPoolT6 final : public ZoneAssetPools
     static const char* ASSET_TYPE_NAMES[];
 
 protected:
-    XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies) override;
+    XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone) override;
 
 public:
     AssetPool<T6::PhysPreset>* m_phys_preset;

src/ZoneCommon/Pool/AssetPool.h

@@ -47,7 +47,7 @@ public:
 
     virtual ~AssetPool() = default;
 
-    virtual XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*>& dependencies) = 0;
+    virtual XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings) = 0;
 
     XAssetInfo<T>* GetAsset(const std::string& name)
     {

src/ZoneCommon/Pool/AssetPoolDynamic.h

@@ -40,13 +40,14 @@ public:
         m_asset_lookup.clear();
     }
 
-    XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*>& dependencies) override
+    XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings) override
     {
         auto* newInfo = new XAssetInfo<T>();
         newInfo->m_type = m_type;
         newInfo->m_name = std::move(name);
         newInfo->m_zone = zone;
         newInfo->m_dependencies = std::move(dependencies);
+        newInfo->m_used_script_strings = std::move(usedScriptStrings);
 
         T* newAsset = new T();
         memcpy(newAsset, asset, sizeof(T));

src/ZoneCommon/Pool/AssetPoolStatic.h

@@ -82,7 +82,7 @@ public:
         m_capacity = 0;
     }
 
-    XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*>& dependencies) override
+    XAssetInfo<T>* AddAsset(std::string name, T* asset, Zone* zone, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings) override
     {
         if(m_free == nullptr)
         {
@@ -99,6 +99,7 @@ public:
         poolSlot->m_info->m_ptr = &poolSlot->m_entry;
         poolSlot->m_info->m_zone = zone;
         poolSlot->m_info->m_dependencies = std::move(dependencies);
+        poolSlot->m_info->m_used_script_strings = std::move(usedScriptStrings);
 
         m_asset_lookup[poolSlot->m_info->m_name] = poolSlot->m_info;
 

src/ZoneCommon/Pool/XAssetInfo.h

@@ -13,6 +13,7 @@ public:
     std::string m_name;
     Zone* m_zone;
     std::vector<XAssetInfoGeneric*> m_dependencies;
+    std::vector<scr_string_t> m_used_script_strings;
     void* m_ptr;
 };
 

src/ZoneCommon/Pool/ZoneAssetPools.cpp

@@ -5,9 +5,14 @@ ZoneAssetPools::ZoneAssetPools(Zone* zone)
 {
 }
 
-XAssetInfoGeneric* ZoneAssetPools::AddAsset(const asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies)
+XAssetInfoGeneric* ZoneAssetPools::AddAsset(const asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings)
 {
-    auto* assetInfo = AddAssetToPool(type, std::move(name), asset, dependencies);
+    return AddAsset(type, std::move(name), asset, std::move(dependencies), std::move(usedScriptStrings), m_zone);
+}
+
+XAssetInfoGeneric* ZoneAssetPools::AddAsset(const asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone)
+{
+    auto* assetInfo = AddAssetToPool(type, std::move(name), asset, std::move(dependencies), std::move(usedScriptStrings), zone);
     if (assetInfo)
     {
         m_assets_in_order.push_back(assetInfo);

src/ZoneCommon/Pool/ZoneAssetPools.h

@@ -17,17 +17,23 @@ protected:
     Zone* m_zone;
     std::vector<XAssetInfoGeneric*> m_assets_in_order;
 
-    virtual XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies) = 0;
+    virtual XAssetInfoGeneric* AddAssetToPool(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings,
+                                              Zone* zone) = 0;
 
 public:
     using iterator = std::vector<XAssetInfoGeneric*>::const_iterator;
 
     explicit ZoneAssetPools(Zone* zone);
     virtual ~ZoneAssetPools() = default;
+    ZoneAssetPools(const ZoneAssetPools& other) = delete;
+    ZoneAssetPools(ZoneAssetPools&& other) noexcept = default;
+    ZoneAssetPools& operator=(const ZoneAssetPools& other) = delete;
+    ZoneAssetPools& operator=(ZoneAssetPools&& other) noexcept = default;
 
-    XAssetInfoGeneric* AddAsset(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*>& dependencies);
+    XAssetInfoGeneric* AddAsset(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings);
-    virtual XAssetInfoGeneric* GetAsset(asset_type_t type, std::string name) const = 0;
+    XAssetInfoGeneric* AddAsset(asset_type_t type, std::string name, void* asset, std::vector<XAssetInfoGeneric*> dependencies, std::vector<scr_string_t> usedScriptStrings, Zone* zone);
-    virtual const char* GetAssetTypeName(asset_type_t assetType) const = 0;
+    _NODISCARD virtual XAssetInfoGeneric* GetAsset(asset_type_t type, std::string name) const = 0;
+    _NODISCARD virtual const char* GetAssetTypeName(asset_type_t assetType) const = 0;
 
     virtual void InitPoolStatic(asset_type_t type, size_t capacity) = 0;
     virtual void InitPoolDynamic(asset_type_t type) = 0;

src/ZoneCommon/Zone/Zone.h

@@ -2,13 +2,14 @@
 
 #include <memory>
 #include <string>
-#include <vector>
 
+#include "Utils/ClassUtils.h"
 #include "Zone/ZoneTypes.h"
 #include "Pool/ZoneAssetPools.h"
 #include "Game/IGame.h"
 #include "Game/GameLanguage.h"
 #include "ZoneMemory.h"
+#include "ZoneScriptStrings.h"
 
 class IGame;
 class ZoneAssetPools;
@@ -24,7 +25,7 @@ public:
     zone_priority_t m_priority;
     GameLanguage m_language;
     IGame* m_game;
-    std::vector<std::string> m_script_strings;
+    ZoneScriptStrings m_script_strings;
     std::unique_ptr<ZoneAssetPools> m_pools;
 
     Zone(std::string name, zone_priority_t priority, IGame* game);
@@ -36,5 +37,5 @@ public:
 
     void Register();
 
-    ZoneMemory* GetMemory() const;
+    _NODISCARD ZoneMemory* GetMemory() const;
 };

src/ZoneCommon/Zone/ZoneScriptStrings.cpp

@@ -0,0 +1,57 @@
+#include "ZoneScriptStrings.h"
+
+#include <stdexcept>
+#include <sstream>
+
+scr_string_t ZoneScriptStrings::AddScriptString(const std::string& value)
+{
+    if(m_scr_strings.empty())
+    {
+        m_scr_strings.emplace_back("");
+        m_scr_string_lookup[""] = static_cast<scr_string_t>(0);
+    }
+    else
+    {
+        const auto existingScriptString = m_scr_string_lookup.find(value);
+        if (existingScriptString != m_scr_string_lookup.end())
+            return existingScriptString->second;
+    }
+
+    const auto newScrStringIndex = static_cast<scr_string_t>(m_scr_strings.size());
+    m_scr_strings.emplace_back(value);
+    m_scr_string_lookup[value] = newScrStringIndex;
+
+    return newScrStringIndex;
+}
+
+size_t ZoneScriptStrings::Count() const
+{
+    return m_scr_strings.size();
+}
+
+bool ZoneScriptStrings::Empty() const
+{
+    return m_scr_strings.empty();
+}
+
+const std::string& ZoneScriptStrings::operator[](const size_t index) const
+{
+    if(index > m_scr_strings.size())
+    {
+        std::ostringstream str;
+        str << "Script string index '" << index << "' is not inside range of zone script strings (count: " << m_scr_strings.size() << ")";
+        throw std::runtime_error(str.str());
+    }
+
+    return m_scr_strings[index];
+}
+
+std::vector<std::string>::const_iterator ZoneScriptStrings::begin() const
+{
+    return m_scr_strings.cbegin();
+}
+
+std::vector<std::string>::const_iterator ZoneScriptStrings::end() const
+{
+    return m_scr_strings.end();
+}

src/ZoneCommon/Zone/ZoneScriptStrings.h

@@ -0,0 +1,24 @@
+#pragma once
+
+#include <cstddef>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "Utils/ClassUtils.h"
+#include "Zone/ZoneTypes.h"
+
+class ZoneScriptStrings
+{
+    std::vector<std::string> m_scr_strings;
+    std::unordered_map<std::string, scr_string_t> m_scr_string_lookup;
+
+public:
+    scr_string_t AddScriptString(const std::string& value);
+    _NODISCARD size_t Count() const;
+    _NODISCARD bool Empty() const;
+
+    _NODISCARD const std::string& operator[](size_t index) const;
+    _NODISCARD std::vector<std::string>::const_iterator begin() const;
+    _NODISCARD std::vector<std::string>::const_iterator end() const;
+};

src/ZoneLoading/Game/IW4/ContentLoaderIW4.cpp

@@ -50,7 +50,7 @@ ContentLoader::ContentLoader()
 
 void ContentLoader::LoadScriptStringList(const bool atStreamStart)
 {
-    assert(m_zone->m_script_strings.empty());
+    assert(m_zone->m_script_strings.Empty());
 
     m_stream->PushBlock(XFILE_BLOCK_VIRTUAL);
 
@@ -69,18 +69,18 @@ void ContentLoader::LoadScriptStringList(const bool atStreamStart)
         {
             if (varScriptStringList->strings[i])
             {
-                m_zone->m_script_strings.emplace_back(varScriptStringList->strings[i]);
+                m_zone->m_script_strings.AddScriptString(varScriptStringList->strings[i]);
             }
             else
             {
-                m_zone->m_script_strings.emplace_back("");
+                m_zone->m_script_strings.AddScriptString("");
             }
         }
     }
 
     m_stream->PopBlock();
 
-    assert(m_zone->m_script_strings.size() <= SCR_STRING_MAX + 1);
+    assert(m_zone->m_script_strings.Count() <= SCR_STRING_MAX + 1);
 }
 
 void ContentLoader::LoadXAsset(const bool atStreamStart)

src/ZoneLoading/Game/T6/ContentLoaderT6.cpp

@@ -63,7 +63,7 @@ ContentLoader::ContentLoader()
 
 void ContentLoader::LoadScriptStringList(const bool atStreamStart)
 {
-    assert(m_zone->m_script_strings.empty());
+    assert(m_zone->m_script_strings.Empty());
 
     m_stream->PushBlock(XFILE_BLOCK_VIRTUAL);
 
@@ -82,18 +82,18 @@ void ContentLoader::LoadScriptStringList(const bool atStreamStart)
         {
             if (varScriptStringList->strings[i])
             {
-                m_zone->m_script_strings.emplace_back(varScriptStringList->strings[i]);
+                m_zone->m_script_strings.AddScriptString(varScriptStringList->strings[i]);
             }
             else
             {
-                m_zone->m_script_strings.emplace_back("");
+                m_zone->m_script_strings.AddScriptString("");
             }
         }
     }
 
     m_stream->PopBlock();
 
-    assert(m_zone->m_script_strings.size() <= SCR_STRING_MAX + 1);
+    assert(m_zone->m_script_strings.Count() <= SCR_STRING_MAX + 1);
 }
 
 void ContentLoader::LoadXAsset(const bool atStreamStart)

src/ZoneLoading/Loading/AssetLoader.cpp

@@ -30,11 +30,12 @@ void AssetLoader::AddDependency(XAssetInfoGeneric* assetInfo)
 
 scr_string_t AssetLoader::UseScriptString(const scr_string_t scrString)
 {
-    assert(scrString < m_zone->m_script_strings.size());
+    assert(scrString < m_zone->m_script_strings.Count());
 
-    if (scrString >= m_zone->m_script_strings.size())
+    if (scrString >= m_zone->m_script_strings.Count())
         return 0u;
 
+    m_used_script_strings.emplace(scrString);
     return scrString;
 }
 
@@ -55,7 +56,19 @@ void AssetLoader::LoadScriptStringArray(const bool atStreamStart, const size_t c
 
 XAssetInfoGeneric* AssetLoader::LinkAsset(std::string name, void* asset)
 {
-    return m_zone->m_pools->AddAsset(m_asset_type, std::move(name), asset, m_dependencies);
+    std::vector<scr_string_t> usedScriptStrings;
+    if(!m_used_script_strings.empty())
+    {
+        for(auto scrString : m_used_script_strings)
+        {
+            usedScriptStrings.push_back(scrString);
+        }
+
+        std::sort(usedScriptStrings.begin(), usedScriptStrings.end());
+        m_used_script_strings.clear();
+    }
+
+    return m_zone->m_pools->AddAsset(m_asset_type, std::move(name), asset, std::move(m_dependencies), std::move(usedScriptStrings));
 }
 
 XAssetInfoGeneric* AssetLoader::GetAssetInfo(std::string name) const

src/ZoneLoading/Loading/AssetLoader.h

@@ -1,5 +1,8 @@
 #pragma once
 
+#include <vector>
+#include <unordered_set>
+
 #include "Zone/ZoneTypes.h"
 #include "Pool/XAssetInfo.h"
 #include "ContentLoaderBase.h"
@@ -9,6 +12,7 @@ class AssetLoader : public ContentLoaderBase
     asset_type_t m_asset_type;
 
     std::vector<XAssetInfoGeneric*> m_dependencies;
+    std::unordered_set<scr_string_t> m_used_script_strings;
 
 protected:
     scr_string_t* varScriptString;

src/ZoneWriting/Game/IW4/ContentWriterIW4.cpp

@@ -52,13 +52,13 @@ ContentWriter::ContentWriter()
 
 void ContentWriter::CreateXAssetList(XAssetList& xAssetList, MemoryManager& memory) const
 {
-    if (!m_zone->m_script_strings.empty())
+    if (!m_zone->m_script_strings.Empty())
     {
-        assert(m_zone->m_script_strings.size() <= SCR_STRING_MAX + 1);
+        assert(m_zone->m_script_strings.Count() <= SCR_STRING_MAX + 1);
-        xAssetList.stringList.count = m_zone->m_script_strings.size();
+        xAssetList.stringList.count = m_zone->m_script_strings.Count();
-        xAssetList.stringList.strings = static_cast<const char**>(memory.Alloc(sizeof(const char*) * m_zone->m_script_strings.size()));
+        xAssetList.stringList.strings = static_cast<const char**>(memory.Alloc(sizeof(const char*) * m_zone->m_script_strings.Count()));
 
-        for (auto i = 0u; i < m_zone->m_script_strings.size(); i++)
+        for (auto i = 0u; i < m_zone->m_script_strings.Count(); i++)
         {
             xAssetList.stringList.strings[i] = m_zone->m_script_strings[i].c_str();
         }
@@ -93,8 +93,6 @@ void ContentWriter::CreateXAssetList(XAssetList& xAssetList, MemoryManager& memo
 
 void ContentWriter::WriteScriptStringList(const bool atStreamStart)
 {
-    assert(m_zone->m_script_strings.empty());
-
     m_stream->PushBlock(XFILE_BLOCK_VIRTUAL);
 
     if (atStreamStart)

src/ZoneWriting/Game/T6/ContentWriterT6.cpp

@@ -65,13 +65,13 @@ ContentWriter::ContentWriter()
 
 void ContentWriter::CreateXAssetList(XAssetList& xAssetList, MemoryManager& memory) const
 {
-    if (!m_zone->m_script_strings.empty())
+    if (!m_zone->m_script_strings.Empty())
     {
-        assert(m_zone->m_script_strings.size() <= SCR_STRING_MAX + 1);
+        assert(m_zone->m_script_strings.Count() <= SCR_STRING_MAX + 1);
-        xAssetList.stringList.count = m_zone->m_script_strings.size();
+        xAssetList.stringList.count = m_zone->m_script_strings.Count();
-        xAssetList.stringList.strings = static_cast<const char**>(memory.Alloc(sizeof(const char*) * m_zone->m_script_strings.size()));
+        xAssetList.stringList.strings = static_cast<const char**>(memory.Alloc(sizeof(const char*) * m_zone->m_script_strings.Count()));
 
-        for (auto i = 0u; i < m_zone->m_script_strings.size(); i++)
+        for (auto i = 0u; i < m_zone->m_script_strings.Count(); i++)
         {
             xAssetList.stringList.strings[i] = m_zone->m_script_strings[i].c_str();
         }
@@ -109,8 +109,6 @@ void ContentWriter::CreateXAssetList(XAssetList& xAssetList, MemoryManager& memo
 
 void ContentWriter::WriteScriptStringList(const bool atStreamStart)
 {
-    assert(m_zone->m_script_strings.empty());
-
     m_stream->PushBlock(XFILE_BLOCK_VIRTUAL);
 
     if (atStreamStart)

src/ZoneWriting/Writing/AssetWriter.cpp

@@ -13,6 +13,8 @@ AssetWriter::AssetWriter(XAssetInfoGeneric* asset, Zone* zone, IZoneOutputStream
 
 scr_string_t AssetWriter::UseScriptString(const scr_string_t scrString) const
 {
+    assert(scrString < m_asset->m_zone->m_script_strings.Count());
+
     if (m_asset->m_zone == m_zone)
         return scrString;