zone/OpenAssetTools
2
0
Fork 0
mirror of https://github.com/Laupetin/OpenAssetTools.git synced 2026-07-26 18:00:38 +00:00
Code Activity

fix(parser): report unclosed multiline comments (#924)

Browse Source 
* fix(parser): report unclosed multiline comments

* chore: make multi line comment variable names clearer

---------

Co-authored-by: Jan Laupetin <[email protected]>
This commit is contained in:
mo
2026-07-23 18:57:28 +02:00
committed by GitHub
co-authored by Jan Laupetin
parent 04b6b5b4bf
commit 52f557a9bb
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/ParserTests/Parsing/Impl/CommentRemovingStreamProxyTests.cpp
+18
View File
@@ -1,8 +1,13 @@
#include "Parsing/Impl/CommentRemovingStreamProxy.h"
#include "Parsing/Mock/MockParserLineStream.h"
#include "Parsing/ParsingException.h"
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <catch2/matchers/catch_matchers_exception.hpp>
#include <catch2/matchers/catch_matchers_string.hpp>
using namespace Catch::Matchers;
namespace test::parsing::impl::comment_removing_stream_proxy
{
@@ -192,6 +197,19 @@ namespace test::parsing::impl::comment_removing_stream_proxy
REQUIRE(proxy.Eof());
}
TEST_CASE("CommentRemovingStreamProxy: Unclosed multiline comment at end of file throws an error", "[parsing][parsingstream]")
{
const std::vector<std::string> lines{"before /* comment", "still comment"};
MockParserLineStream mockStream(lines);
CommentRemovingStreamProxy proxy(&mockStream);
REQUIRE(proxy.NextLine().m_line == "before ");
REQUIRE(proxy.NextLine().m_line.empty());
REQUIRE_THROWS_MATCHES(
proxy.NextLine(), ParsingException, MessageMatches(ContainsSubstring("L1:8") && ContainsSubstring("Unclosed multi-line comment")));
}
TEST_CASE("CommentRemovingStreamProxy: Can have multiple comment blocks in one line", "[parsing][parsingstream]")
{
const std::vector<std::string> lines{