chore: make GetLanguagePrefixes return a reference instead of a vector copy

This commit is contained in:
Jan 2024-10-19 20:14:26 +02:00
parent 3aaa821b74
commit 897a571a41
No known key found for this signature in database
GPG Key ID: 44B581F78FF5C57C
11 changed files with 49 additions and 47 deletions

View File

@ -42,5 +42,7 @@ public:
virtual void AddZone(Zone* zone) = 0;
virtual void RemoveZone(Zone* zone) = 0;
virtual std::vector<Zone*> GetZones() = 0;
virtual std::vector<GameLanguagePrefix> GetLanguagePrefixes() = 0;
virtual const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() = 0;
static IGame* GetGameById(GameId gameId);
};

View File

@ -41,8 +41,8 @@ std::vector<Zone*> GameIW3::GetZones()
return m_zones;
}
std::vector<GameLanguagePrefix> GameIW3::GetLanguagePrefixes()
const std::vector<GameLanguagePrefix>& GameIW3::GetLanguagePrefixes()
{
std::vector<GameLanguagePrefix> prefixes;
static std::vector<GameLanguagePrefix> prefixes;
return prefixes;
}

View File

@ -10,7 +10,7 @@ public:
void AddZone(Zone* zone) override;
void RemoveZone(Zone* zone) override;
std::vector<Zone*> GetZones() override;
std::vector<GameLanguagePrefix> GetLanguagePrefixes() override;
const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() override;
private:
std::vector<Zone*> m_zones;

View File

@ -41,8 +41,8 @@ std::vector<Zone*> GameIW4::GetZones()
return m_zones;
}
std::vector<GameLanguagePrefix> GameIW4::GetLanguagePrefixes()
const std::vector<GameLanguagePrefix>& GameIW4::GetLanguagePrefixes()
{
std::vector<GameLanguagePrefix> prefixes;
static std::vector<GameLanguagePrefix> prefixes;
return prefixes;
}

View File

@ -10,7 +10,7 @@ public:
void AddZone(Zone* zone) override;
void RemoveZone(Zone* zone) override;
std::vector<Zone*> GetZones() override;
std::vector<GameLanguagePrefix> GetLanguagePrefixes() override;
const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() override;
private:
std::vector<Zone*> m_zones;

View File

@ -41,8 +41,8 @@ std::vector<Zone*> GameIW5::GetZones()
return m_zones;
}
std::vector<GameLanguagePrefix> GameIW5::GetLanguagePrefixes()
const std::vector<GameLanguagePrefix>& GameIW5::GetLanguagePrefixes()
{
std::vector<GameLanguagePrefix> prefixes;
static std::vector<GameLanguagePrefix> prefixes;
return prefixes;
}

View File

@ -10,7 +10,7 @@ public:
void AddZone(Zone* zone) override;
void RemoveZone(Zone* zone) override;
std::vector<Zone*> GetZones() override;
std::vector<GameLanguagePrefix> GetLanguagePrefixes() override;
const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() override;
private:
std::vector<Zone*> m_zones;

View File

@ -41,23 +41,23 @@ std::vector<Zone*> GameT5::GetZones()
return m_zones;
}
std::vector<GameLanguagePrefix> GameT5::GetLanguagePrefixes()
const std::vector<GameLanguagePrefix>& GameT5::GetLanguagePrefixes()
{
std::vector<GameLanguagePrefix> prefixes;
prefixes.emplace_back(GameLanguage::LANGUAGE_ENGLISH, "en_");
prefixes.emplace_back(GameLanguage::LANGUAGE_FRENCH, "fr_");
prefixes.emplace_back(GameLanguage::LANGUAGE_FRENCH_CAN, "fc_");
prefixes.emplace_back(GameLanguage::LANGUAGE_GERMAN, "ge_");
prefixes.emplace_back(GameLanguage::LANGUAGE_AUSTRIAN, "ge_");
prefixes.emplace_back(GameLanguage::LANGUAGE_ITALIAN, "it_");
prefixes.emplace_back(GameLanguage::LANGUAGE_SPANISH, "sp_");
prefixes.emplace_back(GameLanguage::LANGUAGE_BRITISH, "br_");
prefixes.emplace_back(GameLanguage::LANGUAGE_RUSSIAN, "ru_");
prefixes.emplace_back(GameLanguage::LANGUAGE_POLISH, "po_");
prefixes.emplace_back(GameLanguage::LANGUAGE_KOREAN, "ko_");
prefixes.emplace_back(GameLanguage::LANGUAGE_JAPANESE, "ja_");
prefixes.emplace_back(GameLanguage::LANGUAGE_CZECH, "cz_");
static std::vector<GameLanguagePrefix> prefixes{
{GameLanguage::LANGUAGE_ENGLISH, "en_"},
{GameLanguage::LANGUAGE_FRENCH, "fr_"},
{GameLanguage::LANGUAGE_FRENCH_CAN, "fc_"},
{GameLanguage::LANGUAGE_GERMAN, "ge_"},
{GameLanguage::LANGUAGE_AUSTRIAN, "ge_"},
{GameLanguage::LANGUAGE_ITALIAN, "it_"},
{GameLanguage::LANGUAGE_SPANISH, "sp_"},
{GameLanguage::LANGUAGE_BRITISH, "br_"},
{GameLanguage::LANGUAGE_RUSSIAN, "ru_"},
{GameLanguage::LANGUAGE_POLISH, "po_"},
{GameLanguage::LANGUAGE_KOREAN, "ko_"},
{GameLanguage::LANGUAGE_JAPANESE, "ja_"},
{GameLanguage::LANGUAGE_CZECH, "cz_"},
};
return prefixes;
}

View File

@ -10,7 +10,7 @@ public:
void AddZone(Zone* zone) override;
void RemoveZone(Zone* zone) override;
std::vector<Zone*> GetZones() override;
std::vector<GameLanguagePrefix> GetLanguagePrefixes() override;
const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() override;
private:
std::vector<Zone*> m_zones;

View File

@ -41,26 +41,26 @@ std::vector<Zone*> GameT6::GetZones()
return m_zones;
}
std::vector<GameLanguagePrefix> GameT6::GetLanguagePrefixes()
const std::vector<GameLanguagePrefix>& GameT6::GetLanguagePrefixes()
{
std::vector<GameLanguagePrefix> prefixes;
prefixes.emplace_back(GameLanguage::LANGUAGE_ENGLISH, "en_");
prefixes.emplace_back(GameLanguage::LANGUAGE_FRENCH, "fr_");
prefixes.emplace_back(GameLanguage::LANGUAGE_FRENCH_CAN, "fc_");
prefixes.emplace_back(GameLanguage::LANGUAGE_GERMAN, "ge_");
prefixes.emplace_back(GameLanguage::LANGUAGE_AUSTRIAN, "as_");
prefixes.emplace_back(GameLanguage::LANGUAGE_ITALIAN, "it_");
prefixes.emplace_back(GameLanguage::LANGUAGE_SPANISH, "sp_");
prefixes.emplace_back(GameLanguage::LANGUAGE_BRITISH, "br_");
prefixes.emplace_back(GameLanguage::LANGUAGE_RUSSIAN, "ru_");
prefixes.emplace_back(GameLanguage::LANGUAGE_POLISH, "po_");
prefixes.emplace_back(GameLanguage::LANGUAGE_KOREAN, "ko_");
prefixes.emplace_back(GameLanguage::LANGUAGE_JAPANESE, "ja_");
prefixes.emplace_back(GameLanguage::LANGUAGE_CZECH, "cz_");
prefixes.emplace_back(GameLanguage::LANGUAGE_FULL_JAPANESE, "fj_");
prefixes.emplace_back(GameLanguage::LANGUAGE_PORTUGUESE, "bp_");
prefixes.emplace_back(GameLanguage::LANGUAGE_MEXICAN_SPANISH, "ms_");
static std::vector<GameLanguagePrefix> prefixes{
{GameLanguage::LANGUAGE_ENGLISH, "en_"},
{GameLanguage::LANGUAGE_FRENCH, "fr_"},
{GameLanguage::LANGUAGE_FRENCH_CAN, "fc_"},
{GameLanguage::LANGUAGE_GERMAN, "ge_"},
{GameLanguage::LANGUAGE_AUSTRIAN, "as_"},
{GameLanguage::LANGUAGE_ITALIAN, "it_"},
{GameLanguage::LANGUAGE_SPANISH, "sp_"},
{GameLanguage::LANGUAGE_BRITISH, "br_"},
{GameLanguage::LANGUAGE_RUSSIAN, "ru_"},
{GameLanguage::LANGUAGE_POLISH, "po_"},
{GameLanguage::LANGUAGE_KOREAN, "ko_"},
{GameLanguage::LANGUAGE_JAPANESE, "ja_"},
{GameLanguage::LANGUAGE_CZECH, "cz_"},
{GameLanguage::LANGUAGE_FULL_JAPANESE, "fj_"},
{GameLanguage::LANGUAGE_PORTUGUESE, "bp_"},
{GameLanguage::LANGUAGE_MEXICAN_SPANISH, "ms_"},
};
return prefixes;
}

View File

@ -10,7 +10,7 @@ public:
void AddZone(Zone* zone) override;
void RemoveZone(Zone* zone) override;
std::vector<Zone*> GetZones() override;
std::vector<GameLanguagePrefix> GetLanguagePrefixes() override;
const std::vector<GameLanguagePrefix>& GetLanguagePrefixes() override;
private:
std::vector<Zone*> m_zones;