zone/OpenAssetTools
zone/OpenAssetTools
2
0
Fork 0
mirror of https://github.com/Laupetin/OpenAssetTools.git synced 2025-04-20 00:02:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip unnecessary outer parenthesis for if clauses and expressions

Browse Source
This commit is contained in:
Jan 2021-10-23 15:35:17 +02:00
parent 601b683f8a
commit a89492d636
1 changed files with 39 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
src/ObjWriting/Game/IW4/AssetDumpers/AssetDumperMenuDef.cpp
View File

@ -593,6 +593,32 @@ class MenuDumperIw4 : public MenuDumper
WriteStatementEntryRange(statement, 0, static_cast<size_t>(statement->numEntries));
}
void WriteStatementSkipInitialUnnecessaryParenthesis(const Statement_s* statementValue) const
{
if (statementValue == nullptr || statementValue->numEntries < 0)
return;
const auto statementEnd = static_cast<size_t>(statementValue->numEntries);
if (statementValue->numEntries >= 1
&& statementValue->entries[0].type == EET_OPERATOR
&& statementValue->entries[0].data.op == OP_LEFTPAREN)
{
const auto parenthesisEnd = FindStatementClosingParenthesis(statementValue, 0);
if (parenthesisEnd >= statementEnd)
WriteStatementEntryRange(statementValue, 1, statementEnd);
else if (parenthesisEnd == statementEnd - 1)
WriteStatementEntryRange(statementValue, 1, statementEnd - 1);
else
WriteStatementEntryRange(statementValue, 0, statementEnd);
}
else
{
WriteStatementEntryRange(statementValue, 0, statementEnd);
}
}
void WriteStatementProperty(const std::string& propertyKey, const Statement_s* statementValue, const bool isBooleanStatement) const
{
if (statementValue == nullptr || statementValue->numEntries < 0)
@ -601,25 +627,18 @@ class MenuDumperIw4 : public MenuDumper
Indent();
WriteKey(propertyKey);
const auto statementEnd = static_cast<size_t>(statementValue->numEntries);
if (isBooleanStatement)
{
m_stream << "when";
// Add a space when first entry is not (
if (statementEnd < 1
|| statementValue->entries[0].type != EET_OPERATOR
|| statementValue->entries[0].data.op != OP_LEFTPAREN)
m_stream << "when(";
WriteStatementSkipInitialUnnecessaryParenthesis(statementValue);
m_stream << ");\n";
}
else
{
m_stream << " ";
}
}
WriteStatementEntryRange(statementValue, 0, statementEnd);
WriteStatementSkipInitialUnnecessaryParenthesis(statementValue);
m_stream << ";\n";
}
}
void WriteSetLocalVarData(const std::string& setFunction, const SetLocalVarData* setLocalVarData) const
{
@ -757,7 +776,7 @@ class MenuDumperIw4 : public MenuDumper
Indent();
m_stream << "if (";
WriteStatement(eventHandler->eventData.conditionalScript->eventExpression);
WriteStatementSkipInitialUnnecessaryParenthesis(eventHandler->eventData.conditionalScript->eventExpression);
m_stream << ")\n";
WriteMenuEventHandlerSet(eventHandler->eventData.conditionalScript->eventHandlerSet);
break;