Merge pull request #199 from Laupetin/fix/iw5-leaderboard-col-ids

fix: iw4/iw5 leaderboard column ids
This commit is contained in:
Jan 2024-05-19 13:49:53 +02:00 committed by GitHub
commit d36ec97295
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 10 deletions

View File

@ -34,7 +34,7 @@ namespace IW4
{
public:
std::string name;
int id;
int colId;
int propertyId;
bool hidden;
std::string statName;
@ -43,7 +43,7 @@ namespace IW4
LbAggType aggregationFunction;
};
NLOHMANN_DEFINE_TYPE_EXTENSION(JsonColumnDef, name, id, propertyId, hidden, statName, type, precision, aggregationFunction);
NLOHMANN_DEFINE_TYPE_EXTENSION(JsonColumnDef, name, colId, propertyId, hidden, statName, type, precision, aggregationFunction);
class JsonLeaderboardDef
{

View File

@ -54,7 +54,7 @@ namespace IW5
{
public:
std::string name;
int id;
int colId;
std::optional<int> propertyId;
std::optional<bool> hidden;
std::optional<std::string> statName;
@ -65,7 +65,7 @@ namespace IW5
std::optional<int> uiCalColY;
};
NLOHMANN_DEFINE_TYPE_EXTENSION(JsonColumnDef, name, id, propertyId, hidden, statName, type, precision, aggregationFunction, uiCalColX, uiCalColY);
NLOHMANN_DEFINE_TYPE_EXTENSION(JsonColumnDef, name, colId, propertyId, hidden, statName, type, precision, aggregationFunction, uiCalColX, uiCalColY);
class JsonLeaderboardDef
{

View File

@ -36,7 +36,7 @@ namespace
static void CreateJsonColumnDef(JsonColumnDef& jColumnDef, const LbColumnDef& lbColumnDef)
{
jColumnDef.name = lbColumnDef.name;
jColumnDef.id = lbColumnDef.id;
jColumnDef.colId = lbColumnDef.id;
if (lbColumnDef.propertyId != 0)
jColumnDef.propertyId = lbColumnDef.propertyId;
@ -59,9 +59,9 @@ namespace
{
jLeaderboardDef.id = leaderboardDef.id;
if (leaderboardDef.xpColId != 0)
if (leaderboardDef.xpColId >= 0)
jLeaderboardDef.xpColId = leaderboardDef.xpColId;
if (leaderboardDef.prestigeColId != 0)
if (leaderboardDef.prestigeColId >= 0)
jLeaderboardDef.prestigeColId = leaderboardDef.prestigeColId;
jLeaderboardDef.columns.resize(leaderboardDef.columnCount);

View File

@ -36,7 +36,7 @@ namespace
static void CreateJsonColumnDef(JsonColumnDef& jColumnDef, const LbColumnDef& lbColumnDef)
{
jColumnDef.name = lbColumnDef.name;
jColumnDef.id = lbColumnDef.id;
jColumnDef.colId = lbColumnDef.id;
if (lbColumnDef.propertyId != 0)
jColumnDef.propertyId = lbColumnDef.propertyId;
@ -65,9 +65,9 @@ namespace
{
jLeaderboardDef.id = leaderboardDef.id;
if (leaderboardDef.xpColId != 0)
if (leaderboardDef.xpColId >= 0)
jLeaderboardDef.xpColId = leaderboardDef.xpColId;
if (leaderboardDef.prestigeColId != 0)
if (leaderboardDef.prestigeColId >= 0)
jLeaderboardDef.prestigeColId = leaderboardDef.prestigeColId;
jLeaderboardDef.columns.resize(leaderboardDef.columnCount);