zone/OpenAssetTools
zone/OpenAssetTools
2
0
Fork 0
mirror of https://github.com/Laupetin/OpenAssetTools.git synced 2025-04-19 15:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make file name verification consider max file name length in zone properly

Browse Source
This commit is contained in:
Jan 2025-01-15 00:46:22 +01:00
parent a1d3e64813
commit d9f23a0b76
No known key found for this signature in database
GPG Key ID: 44B581F78FF5C57C
4 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ZoneLoading/Loading/Exception/InvalidFileNameException.cpp
View File

@ -1,6 +1,8 @@
#include "InvalidFileNameException.h" #include "InvalidFileNameException.h"
InvalidFileNameException::InvalidFileNameException(std::string& actualFileName, std::string& expectedFileName) #include <format>
InvalidFileNameException::InvalidFileNameException(const std::string& actualFileName, const std::string& expectedFileName)
{ {
m_actual_file_name = actualFileName; m_actual_file_name = actualFileName;
m_expected_file_name = expectedFileName; m_expected_file_name = expectedFileName;
@ -8,7 +10,7 @@ InvalidFileNameException::InvalidFileNameException(std::string& actualFileName,
std::string InvalidFileNameException::DetailedMessage() std::string InvalidFileNameException::DetailedMessage()
{ {
return "Name verification failed: The fastfile was created as '" + m_expected_file_name + "' but loaded as '" + m_actual_file_name + "'"; return std::format("Name verification failed: The fastfile was created as '{}' but loaded as '{}'", m_expected_file_name, m_actual_file_name);
} }
char const* InvalidFileNameException::what() const noexcept char const* InvalidFileNameException::what() const noexcept

8
src/ZoneLoading/Loading/Exception/InvalidFileNameException.h
View File

@ -3,12 +3,12 @@
class InvalidFileNameException final : public LoadingException class InvalidFileNameException final : public LoadingException
{ {
std::string m_actual_file_name;
std::string m_expected_file_name;
public: public:
InvalidFileNameException(std::string& actualFileName, std::string& expectedFileName); InvalidFileNameException(const std::string& actualFileName, const std::string& expectedFileName);
std::string DetailedMessage() override; std::string DetailedMessage() override;
char const* what() const noexcept override; char const* what() const noexcept override;
std::string m_actual_file_name;
std::string m_expected_file_name;
}; };

13
src/ZoneLoading/Loading/Steps/StepVerifyFileName.cpp
View File

@ -5,12 +5,11 @@
#include <sstream> #include <sstream>
StepVerifyFileName::StepVerifyFileName(std::string fileName, const size_t fileNameBufferSize) StepVerifyFileName::StepVerifyFileName(std::string fileName, const size_t fileNameBufferSize)
: m_expected_file_name(std::move(fileName)),
m_file_name_buffer_size(fileNameBufferSize)
{ {
m_file_name = std::move(fileName); if (m_expected_file_name.length() > (m_file_name_buffer_size - 1))
m_file_name_buffer_size = fileNameBufferSize; m_expected_file_name.erase(m_file_name_buffer_size - 1);
if (m_file_name.length() > m_file_name_buffer_size)
m_file_name.erase(m_file_name_buffer_size);
} }
void StepVerifyFileName::PerformStep(ZoneLoader* zoneLoader, ILoadingStream* stream) void StepVerifyFileName::PerformStep(ZoneLoader* zoneLoader, ILoadingStream* stream)
@ -42,6 +41,6 @@ void StepVerifyFileName::PerformStep(ZoneLoader* zoneLoader, ILoadingStream* str
std::string originalFileName = originalFilenameStream.str(); std::string originalFileName = originalFilenameStream.str();
if (originalFileName != m_file_name) if (originalFileName != m_expected_file_name)
throw InvalidFileNameException(m_file_name, originalFileName); throw InvalidFileNameException(m_expected_file_name, originalFileName);
} }

2
src/ZoneLoading/Loading/Steps/StepVerifyFileName.h
View File

@ -4,7 +4,7 @@
class StepVerifyFileName final : public ILoadingStep class StepVerifyFileName final : public ILoadingStep
{ {
std::string m_file_name; std::string m_expected_file_name;
size_t m_file_name_buffer_size; size_t m_file_name_buffer_size;
public: public: