From f5ed7880b0404bdbf4ac5f370bcd88e14f377694 Mon Sep 17 00:00:00 2001
From: Jan <jan@laupetin.net>
Date: Wed, 1 Dec 2021 23:19:20 +0100
Subject: [PATCH] Fix defines proxy not being able to process parameters with
 underscores

---
 src/Parser/Parsing/Impl/DefinesStreamProxy.cpp  |  2 +-
 .../Parsing/Impl/DefinesStreamProxyTests.cpp    | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/Parser/Parsing/Impl/DefinesStreamProxy.cpp b/src/Parser/Parsing/Impl/DefinesStreamProxy.cpp
index f0926825..3bbcabc1 100644
--- a/src/Parser/Parsing/Impl/DefinesStreamProxy.cpp
+++ b/src/Parser/Parsing/Impl/DefinesStreamProxy.cpp
@@ -70,7 +70,7 @@ void DefinesStreamProxy::Define::IdentifyParameters(const std::vector<std::strin
     for (auto i = 0u; i < m_value.size(); i++)
     {
         const auto c = m_value[i];
-        if (!isalnum(c))
+        if (!isalnum(c) && c != '_')
         {
             if (inWord)
             {
diff --git a/test/ParserTests/Parsing/Impl/DefinesStreamProxyTests.cpp b/test/ParserTests/Parsing/Impl/DefinesStreamProxyTests.cpp
index 28eb3a0e..ff016c6b 100644
--- a/test/ParserTests/Parsing/Impl/DefinesStreamProxyTests.cpp
+++ b/test/ParserTests/Parsing/Impl/DefinesStreamProxyTests.cpp
@@ -471,6 +471,23 @@ namespace test::parsing::impl::defines_stream_proxy
         REQUIRE(proxy.Eof());
     }
 
+    TEST_CASE("DefinesStreamProxy: Ensure can define parameters with underscore", "[parsing][parsingstream]")
+    {
+        const std::vector<std::string> lines
+        {
+            "#define test(test_parameter) this is test_parameter",
+            "Apparently test(a very cool text);"
+        };
+
+        MockParserLineStream mockStream(lines);
+        DefinesStreamProxy proxy(&mockStream);
+
+        ExpectLine(&proxy, 1, "");
+        ExpectLine(&proxy, 2, "Apparently this is a very cool text;");
+
+        REQUIRE(proxy.Eof());
+    }
+
     TEST_CASE("DefinesStreamProxy: Ensure simple if is working with truthy value", "[parsing][parsingstream]")
     {
         const std::vector<std::string> lines