Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-09 12:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

(grammar_current_rule_check):

Browse Source 
Don't worry about the default action if $$ is untyped.
Prevents bogus warnings reported by Jim Gifford in
<http://mail.gnu.org/pipermail/bug-bison/2002-October/001673.html>.
This commit is contained in:
Paul Eggert
2002-10-13 03:52:53 +00:00
parent 14904b8965
commit 3f4c0f8017
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/reader.c
View File

@@ -246,18 +246,22 @@ static void
grammar_current_rule_check (void)
{
symbol_t *lhs = current_rule->sym;
char const *lhs_type = lhs->type_name;
symbol_t *first_rhs = current_rule->next->sym;
/* If there is an action, then there is nothing we can do: the user
is allowed to shoot in her foot. */
is allowed to shoot herself in the foot. */
if (current_rule->action)
return;
/* If $$ is being set in default way, report if any type mismatch.
*/
/* Don't worry about the default action if $$ is untyped, since $$'s
value can't be used. */
if (! lhs_type)
return;
/* If $$ is being set in default way, report if any type mismatch. */
if (first_rhs)
{
const char *lhs_type = lhs->type_name ? lhs->type_name : "";
const char *rhs_type = first_rhs->type_name ? first_rhs->type_name : "";
if (strcmp (lhs_type, rhs_type))
complain_at (current_rule->location,
@@ -266,11 +270,8 @@ grammar_current_rule_check (void)
}
/* Warn if there is no default for $$ but we need one. */
else
{
if (lhs->type_name)
complain_at (current_rule->location,
_("empty rule for typed nonterminal, and no action"));
}
complain_at (current_rule->location,
_("empty rule for typed nonterminal, and no action"));
}