Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct wrong and misleading comments about enemy trainer AI (#1149)

Browse Source
This commit is contained in:
Hannabart Pekopon
2024-12-26 05:59:18 -08:00
committed by GitHub
parent 61c9ba5f6c
commit 3f686e67da
6 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
data/battle/ai/rain_dance_moves.asm
View File

@@ -1,4 +1,4 @@
; AI_SMART prefers these moves during rain. ; AI_SMART encourages Rain Dance if it also knows these moves.
RainDanceMoves: RainDanceMoves:
db WATER_GUN db WATER_GUN

2
data/battle/ai/stall_moves.asm
View File

@@ -1,5 +1,5 @@
; AI_OPPORTUNIST discourages these moves ; AI_OPPORTUNIST discourages these moves
; when the player's HP is low. ; when its HP is low.
StallMoves: StallMoves:
db SWORDS_DANCE db SWORDS_DANCE

4
data/battle/ai/sunny_day_moves.asm
View File

@@ -1,7 +1,7 @@
; AI_SMART prefers these moves during harsh sunlight. ; AI_SMART encourages Sunny Day if it also knows these moves.
SunnyDayMoves: SunnyDayMoves:
; BUG: "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day (see docs/bugs_and_glitches.md) ; BUG: "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight (see docs/bugs_and_glitches.md)
db FIRE_PUNCH db FIRE_PUNCH
db EMBER db EMBER
db FLAMETHROWER db FLAMETHROWER

3
data/battle/ai/useful_moves.asm
View File

@@ -1,4 +1,5 @@
; AI_SMART knows these moves are usable all-around. ; AI_SMART tries to use Mirror Move, Mimic, and Disable
; after the player uses these moves.
UsefulMoves: UsefulMoves:
db DOUBLE_EDGE db DOUBLE_EDGE

4
docs/bugs_and_glitches.md
View File

@@ -1267,13 +1267,13 @@ Pryce's dialog ("That BADGE will raise the SPECIAL stats of POKéMON.") implies
``` ```
### "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day ### "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight
**Fix:** Edit `SunnyDayMoves` in [data/battle/ai/sunny_day_moves.asm](https://github.com/pret/pokecrystal/blob/master/data/battle/ai/sunny_day_moves.asm): **Fix:** Edit `SunnyDayMoves` in [data/battle/ai/sunny_day_moves.asm](https://github.com/pret/pokecrystal/blob/master/data/battle/ai/sunny_day_moves.asm):
```diff ```diff
SunnyDayMoves: SunnyDayMoves:
-; BUG: "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day (see docs/bugs_and_glitches.md) -; BUG: "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight (see docs/bugs_and_glitches.md)
db FIRE_PUNCH db FIRE_PUNCH
db EMBER db EMBER
db FLAMETHROWER db FLAMETHROWER

2
engine/battle/ai/scoring.asm
View File

@@ -54,7 +54,7 @@ AI_Basic:
and a and a
jr nz, .discourage jr nz, .discourage
; Dismiss Safeguard if it's already active. ; Dismiss status moves if the player is Safeguarded.
ld a, [wPlayerScreens] ld a, [wPlayerScreens]
bit SCREENS_SAFEGUARD, a bit SCREENS_SAFEGUARD, a
jr z, .checkmove jr z, .checkmove