Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix/update sprite y-coord offscreen definitions (#1108)

Browse Source
This commit is contained in:
vulcandth
2024-04-14 15:55:46 -05:00
committed by GitHub
parent e8079e6d48
commit b0b5ed2eb8
5 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
constants/gfx_constants.asm
View File

@@ -55,3 +55,5 @@ DEF SPRITE_GFX_LIST_CAPACITY EQU 32 ; see wUsedSprites
const ANIM_MON_HOF const ANIM_MON_HOF
const ANIM_MON_EGG1 const ANIM_MON_EGG1
const ANIM_MON_EGG2 const ANIM_MON_EGG2
DEF OAM_YCOORD_HIDDEN EQU 160 ; hides an OAM offscreen

2
engine/movie/splash.asm
View File

@@ -93,7 +93,7 @@ GameFreakPresentsInit:
call InitSpriteAnimStruct call InitSpriteAnimStruct
ld hl, SPRITEANIMSTRUCT_YOFFSET ld hl, SPRITEANIMSTRUCT_YOFFSET
add hl, bc add hl, bc
ld [hl], 160 ld [hl], OAM_YCOORD_HIDDEN
ld hl, SPRITEANIMSTRUCT_VAR1 ld hl, SPRITEANIMSTRUCT_VAR1
add hl, bc add hl, bc
ld [hl], 96 ld [hl], 96

2
engine/overworld/map_objects.asm
View File

@@ -2757,7 +2757,7 @@ _UpdateSprites::
ld h, HIGH(wShadowOAM) ld h, HIGH(wShadowOAM)
ld de, SPRITEOAMSTRUCT_LENGTH ld de, SPRITEOAMSTRUCT_LENGTH
ld a, b ld a, b
ld c, SCREEN_HEIGHT_PX + 2 * TILE_WIDTH ld c, OAM_YCOORD_HIDDEN
.loop .loop
ld [hl], c ; y ld [hl], c ; y
add hl, de add hl, de

2
engine/pokemon/switchpartymons.asm
View File

@@ -31,7 +31,7 @@ _SwitchPartyMons:
ld de, SPRITEOAMSTRUCT_LENGTH ld de, SPRITEOAMSTRUCT_LENGTH
ld c, 4 ld c, 4
.gfx_loop .gfx_loop
ld [hl], SCREEN_WIDTH_PX ; y (off-screen) ld [hl], OAM_YCOORD_HIDDEN
add hl, de add hl, de
dec c dec c
jr nz, .gfx_loop jr nz, .gfx_loop

2
home/clear_sprites.asm
View File

@@ -14,7 +14,7 @@ HideSprites::
ld hl, wShadowOAMSprite00YCoord ld hl, wShadowOAMSprite00YCoord
ld de, SPRITEOAMSTRUCT_LENGTH ld de, SPRITEOAMSTRUCT_LENGTH
ld b, NUM_SPRITE_OAM_STRUCTS ld b, NUM_SPRITE_OAM_STRUCTS
ld a, SCREEN_WIDTH_PX ld a, OAM_YCOORD_HIDDEN
.loop .loop
ld [hl], a ; y ld [hl], a ; y
add hl, de add hl, de