Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Document bug with Mania's Shuckie (#1187)

Browse Source
This commit is contained in:
Brianum
2025-06-06 16:59:47 +02:00
committed by GitHub
parent efceed1338
commit b34b4c3291
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
docs/bugs_and_glitches.md
View File

@@ -101,6 +101,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category
- [`CheckOwnMon` only checks the first five letters of OT names](#checkownmon-only-checks-the-first-five-letters-of-ot-names)
- [`CheckOwnMonAnywhere` does not check the Day-Care](#checkownmonanywhere-does-not-check-the-day-care)
- [The unused `phonecall` script command may crash](#the-unused-phonecall-script-command-may-crash)
- [Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon](#mania-uses-wrong-dialogue-for-trying-to-return-shuckie-with-no-other-pok%C3%A9mon)
- [Internal engine routines](#internal-engine-routines)
- [Saves corrupted by mid-save shutoff are not handled](#saves-corrupted-by-mid-save-shutoff-are-not-handled)
- [`ScriptCall` can overflow `wScriptStack` and crash](#scriptcall-can-overflow-wscriptstack-and-crash)
@@ -2563,6 +2564,17 @@ The `phonecall` script command calls the `PhoneCall` routine, which calls the `B
You can also delete the now-unused `BrokenPlaceFarString` routine in the same file.
### Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon
**Fix**: Edit `ManiaScript.returnshuckie` in [maps/ManiasHouse.asm](https://github.com/pret/pokecrystal/blob/master/maps/ManiasHouse.asm):
```diff
-; BUG: Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon (see docs/bugs_and_glitches.md)
- ifequal SHUCKIE_FAINTED, .default_postevent
+ ifequal SHUCKIE_FAINTED, .nothingleft
```
## Internal engine routines

1
maps/ManiasHouse.asm
View File

@@ -56,6 +56,7 @@ ManiaScript:
ifequal SHUCKIE_WRONG_MON, .wrong
ifequal SHUCKIE_REFUSED, .refused
ifequal SHUCKIE_HAPPY, .superhappy
; BUG: Mania uses wrong dialogue for trying to return Shuckie with no other Pokémon (see docs/bugs_and_glitches.md)
ifequal SHUCKIE_FAINTED, .default_postevent
; SHUCKIE_RETURNED
writetext ManiaText_ThankYou