* Rename MON_ID to MON_TRAINER_ID
The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.
The original definition of MON_ID is preserved in macros/legacy.asm
* Remove MON_ID from macros/legacy.asm
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
* Apply rename to missed file
* Rename to `MON_OT_ID`
---------
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY
The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).
* Rename to BATTLETYPE_FORCESHINY
Align name of BATTLETYPE with BATTLETYPE_FORCEITEM
---------
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
* Macro loop for EmptyAllSRAMBanks
* Many things labeled and magic numbers removed
* Conform to the style guide
* Rename URLs in mobile_46
* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS
* Update engine/menus/empty_sram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update ram/wram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Remove underscore from Set*DownloadURL symbols
* Begin Labeling TradeCornerHoldMon routines
* Add wMobileMon party_struct
* Add TRADE_CORNER_REQUEST_LENGTH constant
* Name battle tower action functions
* Label trade corner send/receive buffer
* Label the saved copy of the trade corner pokemon
also fix mailmsg_jp
* So many copies of decodeBase64Character
* Label another buffer
* Fix Alignment and use MOBILE_EMAIL_LENGTH
* `Function11ad8a` -> `MobileIncJumptableIndex`
* Apply Rangi Suggestions pass 1
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
* Apply Suggestions 2
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
