alterware/iw6-mod
1
0
Fork 2
Code Issues Pull Requests 13 Packages Projects Releases Wiki Activity

Clean colored overhead name agent #4

Closed
anomaly wants to merge 2 commits from anomaly/iw6-mod:clean_agent_name into master
pull from: anomaly/iw6-mod:clean_agent_name
merge into: alterware:master
Conversation 6 Commits 2 Files Changed 19 +148 -135
anomaly commented 2024-12-31 19:11:05 +00:00
First-time contributor
Copy Link

Clean colored overhead names of agents.

Clean colored overhead names of agents.
anomaly added 2 commits 2024-12-31 19:11:06 +00:00
anomaly changed title from clean agent name to Clean colored overhead name agent 2024-12-31 20:03:03 +00:00
Future commented 2025-01-01 17:37:54 +00:00
Owner
Copy Link

When is this ever an issue in the game? When have you ever encountered an entity spawned by the game to have a coloured name on a default game? What if a modder wanted to spawn such an entity via GSC with whatever name and now they can't if I allow this PR to be merged?

When is this ever an issue in the game? When have you ever encountered an entity spawned by the game to have a coloured name on a default game? What if a modder wanted to spawn such an entity via GSC with whatever name and now they can't if I allow this PR to be merged?
anomaly commented 2025-01-01 18:18:46 +00:00
Author
First-time contributor
Copy Link

I don't know why your line of questioning feels weirdly antagonistic, but perhaps that's just me.

Would you say the overhead name in the attached image isn't bugged?

I don't know why your line of questioning feels weirdly antagonistic, but perhaps that's just me. Would you say the overhead name in the attached image isn't bugged?
agent.overhead.name.png
406 KiB
agent.overhead.name.png
Future commented 2025-01-09 13:25:29 +00:00
Owner
Copy Link

I don't know why your line of questioning feels weirdly antagonistic, but perhaps that's just me.

Would you say the overhead name in the attached image isn't bugged?

It's normal for me, I prioritize stability over anything when it comes to these clients. Even if an innocent change such as 'removing colour' from agent names appears as one hook, one line change, I need to understand the whole reason behind it which means me asking a lot of questions.
I was unable to understand just by looking at the code alone why this was needed.

How did you spawn the agent with the name hmnn would be my next question, because the answer to your question would be "well you gave it the name hmmm with colors from a GSC script(?) or another method I'm not aware of?" if the answer is yes, then my logical question would be, cant you add ^7 at the end of the name so the trailing square bracket appears white like the first one and the agents can keep colored names?

If you wish to give me some GSC script I can look at this myself as well and see for myself if anything can be done via GSC only without requiring a c++ code change

> I don't know why your line of questioning feels weirdly antagonistic, but perhaps that's just me. > > Would you say the overhead name in the attached image isn't bugged? It's normal for me, I prioritize stability over anything when it comes to these clients. Even if an innocent change such as 'removing colour' from agent names appears as one hook, one line change, I need to understand the whole reason behind it which means me asking a lot of questions. I was unable to understand just by looking at the code alone why this was needed. How did you spawn the agent with the name hmnn would be my next question, because the answer to your question would be "well you gave it the name hmmm with colors from a GSC script(?) or another method I'm not aware of?" if the answer is yes, then my logical question would be, cant you add ^7 at the end of the name so the trailing square bracket appears white like the first one and the agents can keep colored names? If you wish to give me some GSC script I can look at this myself as well and see for myself if anything can be done via GSC only without requiring a c++ code change
anomaly commented 2025-01-09 13:30:29 +00:00
Author
First-time contributor
Copy Link

I would have mentioned if I had taken any steps of my own to spawn this juggernaut; in other words, this is just the result of using a colored user name and calling in a juggernaut or dog killstreak reward.

I would have mentioned if I had taken any steps of my own to spawn this juggernaut; in other words, this is just the result of using a colored user name and calling in a juggernaut or dog killstreak reward.
Future commented 2025-01-09 13:43:29 +00:00
Owner
Copy Link

I will check this out in private match

I will check this out in private match
Future commented 2025-01-09 14:44:26 +00:00
Owner
Copy Link

Thanks, this led me to discover another bug with the game (or client).

I will close this as completed via 09866fd7d1

(had you co-author it)

Thanks, this led me to discover another bug with the game (or client). I will close this as completed via https://git.alterware.dev/alterware/iw6-mod/commit/09866fd7d1c08047a02c23869bce02a4765a4eed (had you co-author it)
Future closed this pull request 2025-01-09 14:44:27 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alterware/iw6-mod#4
No description provided.
Delete Branch "anomaly/iw6-mod:clean_agent_name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?