Fixed two bugs in the old color strip function. #7

2024-12-31T19:12:47Z

anomaly commented

2024-12-31 19:12:47 +00:00

First-time contributor

No description provided.

anomaly added 5 commits 2024-12-31 19:12:47 +00:00

Changed all game struct suffixes from _s to _t. d0003da606

Added hook and fn stub to clean color from agent overhead name. 27d1f61789

Improved naming for function 'get_client_name_stub'. adc33983a8

Added helper function to strip colors from strings. e5a547650c

Fixed two bugs in the old color strip function. 50aa4097bb

Future commented

2025-01-09 14:46:04 +00:00

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function:

I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function: I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?

anomaly commented

2025-01-09 14:58:44 +00:00

First-time contributor

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function:

I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?

Check this out: https://godbolt.org/z/EGnofMn7q
It'd seem to me that the behavior with the cast is the intended behavior.

> I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function: > > I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function? Check this out: https://godbolt.org/z/EGnofMn7q It'd seem to me that the behavior **with** the cast is the intended behavior.

anomaly commented

2025-01-09 15:02:49 +00:00

First-time contributor

https://github.com/iw4x/iw4x-client/blob/develop/src/Components/Modules/TextRenderer.cpp#L1327-L1332

With the cast would also be consistent with iw4x.

https://github.com/iw4x/iw4x-client/blob/develop/src/Components/Modules/TextRenderer.cpp#L1327-L1332 **With** the cast would also be consistent with iw4x.

Future commented

2025-01-11 08:59:11 +00:00

Interesting, I'm glad I asked.

Future commented

2025-01-11 09:23:14 +00:00

Okay, i played with godbolt a bit so yeah iw4x way is better as laupetin took a bit more care than the original xlabs dev when they coded this strip function

so I remove your email address as well from the commit history I hope you like your new email

completed via 199206ee5a

Okay, i played with godbolt a bit so yeah iw4x way is better as laupetin took a bit more care than the original xlabs dev when they coded this strip function so I remove your email address as well from the commit history I hope you like your new email completed via https://git.alterware.dev/alterware/iw6-mod/commit/199206ee5ae6919cdd101f2f5e5aa76a1f676ce3

Future closed this pull request

2025-01-11 09:23:14 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: alterware/iw6-mod#7

Allow edits from maintainers