alterware/iw6-mod
1
0
Fork 2
Code Issues Pull Requests 13 Packages Projects Releases Wiki Activity

Fixed two bugs in the old color strip function. #7

Closed
anomaly wants to merge 5 commits from anomaly/iw6-mod:color_strip_bug_fixes into master
pull from: anomaly/iw6-mod:color_strip_bug_fixes
merge into: alterware:master
Conversation 5 Commits 5 Files Changed 21 +184 -143
anomaly commented 2024-12-31 19:12:47 +00:00
First-time contributor
Copy Link
No description provided.
anomaly added 5 commits 2024-12-31 19:12:47 +00:00
Future commented 2025-01-09 14:46:04 +00:00
Owner
Copy Link

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function:

I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function: I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?
anomaly commented 2025-01-09 14:58:44 +00:00
Author
First-time contributor
Copy Link

I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function:

I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function?

Check this out: https://godbolt.org/z/EGnofMn7q
It'd seem to me that the behavior with the cast is the intended behavior.

> I have this completed as well but I haven't closed it yet because I am pretty sure there is just one bug in this function: > > I have added !max check because it can happen if whoever invokes this function is not careful but I am unable to understand why the static cast is needed. isn't it fine to keep everything between signed integers like the rest of the function? Check this out: https://godbolt.org/z/EGnofMn7q It'd seem to me that the behavior **with** the cast is the intended behavior.
anomaly commented 2025-01-09 15:02:49 +00:00
Author
First-time contributor
Copy Link

https://github.com/iw4x/iw4x-client/blob/develop/src/Components/Modules/TextRenderer.cpp#L1327-L1332

With the cast would also be consistent with iw4x.

https://github.com/iw4x/iw4x-client/blob/develop/src/Components/Modules/TextRenderer.cpp#L1327-L1332 **With** the cast would also be consistent with iw4x.
Future commented 2025-01-11 08:59:11 +00:00
Owner
Copy Link

Interesting, I'm glad I asked.

Interesting, I'm glad I asked.
Future commented 2025-01-11 09:23:14 +00:00
Owner
Copy Link

Okay, i played with godbolt a bit so yeah iw4x way is better as laupetin took a bit more care than the original xlabs dev when they coded this strip function

so I remove your email address as well from the commit history I hope you like your new email

completed via 199206ee5a

Okay, i played with godbolt a bit so yeah iw4x way is better as laupetin took a bit more care than the original xlabs dev when they coded this strip function so I remove your email address as well from the commit history I hope you like your new email completed via https://git.alterware.dev/alterware/iw6-mod/commit/199206ee5ae6919cdd101f2f5e5aa76a1f676ce3
Future closed this pull request 2025-01-11 09:23:14 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alterware/iw6-mod#7
No description provided.
Delete Branch "anomaly/iw6-mod:color_strip_bug_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?