gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-23 03:22:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Redefine the trig functions to divide circles into 1.0 turns (#1060)

Browse Source 
This makes their behavior consistent across Q settings

Fixes #1059
This commit is contained in:
Rangi
2022-09-29 04:57:29 -04:00
committed by GitHub
parent 3567faf395
commit 023884d2b0
6 changed files with 72 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/asm/fixpoint.c
View File

@@ -24,9 +24,9 @@
#define fix2double(i) ((double)((i) / fix_PrecisionFactor()))
#define double2fix(d) ((int32_t)round((d) * fix_PrecisionFactor()))
// pi*2 radians == 2**fixPrecision fixed-point "degrees"
#define fdeg2rad(f) ((f) * (M_PI * 2) / fix_PrecisionFactor())
#define rad2fdeg(r) ((r) * fix_PrecisionFactor() / (M_PI * 2))
// 2*pi radians == 1 turn
#define turn2rad(f) ((f) * (M_PI * 2))
#define rad2turn(r) ((r) / (M_PI * 2))
uint8_t fixPrecision;
@@ -51,37 +51,37 @@ void fix_Print(int32_t i)
int32_t fix_Sin(int32_t i)
{
return double2fix(sin(fdeg2rad(fix2double(i))));
return double2fix(sin(turn2rad(fix2double(i))));
}
int32_t fix_Cos(int32_t i)
{
return double2fix(cos(fdeg2rad(fix2double(i))));
return double2fix(cos(turn2rad(fix2double(i))));
}
int32_t fix_Tan(int32_t i)
{
return double2fix(tan(fdeg2rad(fix2double(i))));
return double2fix(tan(turn2rad(fix2double(i))));
}
int32_t fix_ASin(int32_t i)
{
return double2fix(rad2fdeg(asin(fix2double(i))));
return double2fix(rad2turn(asin(fix2double(i))));
}
int32_t fix_ACos(int32_t i)
{
return double2fix(rad2fdeg(acos(fix2double(i))));
return double2fix(rad2turn(acos(fix2double(i))));
}
int32_t fix_ATan(int32_t i)
{
return double2fix(rad2fdeg(atan(fix2double(i))));
return double2fix(rad2turn(atan(fix2double(i))));
}
int32_t fix_ATan2(int32_t i, int32_t j)
{
return double2fix(rad2fdeg(atan2(fix2double(i), fix2double(j))));
return double2fix(rad2turn(atan2(fix2double(i), fix2double(j))));
}
int32_t fix_Mul(int32_t i, int32_t j)