gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-22 05:37:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix repeated "And N more" in overlay error message (#2118)

Browse Source
This commit is contained in:
Rangi
2026-09-18 17:35:30 -04:00
committed by GitHub
parent 89403ca23b
commit 142eae4558
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/link/assign.cpp
+3 -1
View File
@@ -445,8 +445,9 @@ static void checkOverlayCompat() {
unfixedList += "\n- and ";
unfixedList += std::to_string(nbUnfixedSections - nbListed);
unfixedList += " more";
break;
goto finish;
}
unfixedList += "\n- \"";
unfixedList += section->name;
unfixedList += "\" (";
@@ -463,6 +464,7 @@ static void checkOverlayCompat() {
}
}
finish: // Can't `break` out of a nested loop
fatal(
"All sections must be fixed when using an overlay file; %zu %s not:%s",
nbUnfixedSections,
test/link/overlay/unfixed/a.asm
+3
View File
@@ -8,3 +8,6 @@ FOR n, 1, 5
SECTION "ROMX #{d:n}", ROMX
db n
ENDR
SECTION "aligned", ROMX, ALIGN[4]
SECTION "unconstrained", ROMX
test/link/overlay/unfixed/out.err
+3 -3
View File
@@ -1,4 +1,4 @@
FATAL: All sections must be fixed when using an overlay file; 12 are not:
FATAL: All sections must be fixed when using an overlay file; 14 are not:
- "ROMX BANK[4]" (address not specified)
- "ROMX BANK[3]" (address not specified)
- "ROMX BANK[2]" (address not specified)
@@ -7,7 +7,7 @@ FATAL: All sections must be fixed when using an overlay file; 12 are not:
- "ROMX[$4003]" (bank not specified)
- "ROMX[$4002]" (bank not specified)
- "ROMX[$4001]" (bank not specified)
- "aligned" (bank and address not specified)
- "ROMX #4" (bank and address not specified)
- "ROMX #3" (bank and address not specified)
- and 2 more
- and 4 more
Linking aborted with 1 error