gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use more const references when possible

Browse Source
This commit is contained in:
Rangi42
2025-02-14 16:30:06 +01:00
committed by Rangi
parent 2aef09c8d9
commit 1489854932
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
include/asm/section.hpp
View File

@@ -91,11 +91,11 @@ void sect_ByteString(std::vector<int32_t> const &string);
void sect_WordString(std::vector<int32_t> const &string); void sect_WordString(std::vector<int32_t> const &string);
void sect_LongString(std::vector<int32_t> const &string); void sect_LongString(std::vector<int32_t> const &string);
void sect_Skip(uint32_t skip, bool ds); void sect_Skip(uint32_t skip, bool ds);
void sect_RelByte(Expression &expr, uint32_t pcShift); void sect_RelByte(Expression const &expr, uint32_t pcShift);
void sect_RelBytes(uint32_t n, std::vector<Expression> &exprs); void sect_RelBytes(uint32_t n, std::vector<Expression> const &exprs);
void sect_RelWord(Expression &expr, uint32_t pcShift); void sect_RelWord(Expression const &expr, uint32_t pcShift);
void sect_RelLong(Expression &expr, uint32_t pcShift); void sect_RelLong(Expression const &expr, uint32_t pcShift);
void sect_PCRelByte(Expression &expr, uint32_t pcShift); void sect_PCRelByte(Expression const &expr, uint32_t pcShift);
void sect_BinaryFile(std::string const &name, int32_t startPos); void sect_BinaryFile(std::string const &name, int32_t startPos);
void sect_BinaryFileSlice(std::string const &name, int32_t startPos, int32_t length); void sect_BinaryFileSlice(std::string const &name, int32_t startPos, int32_t length);

14
src/asm/section.cpp
View File

@@ -768,7 +768,7 @@ void sect_Skip(uint32_t skip, bool ds) {
} }
// Output a byte that can be relocatable or constant // Output a byte that can be relocatable or constant
void sect_RelByte(Expression &expr, uint32_t pcShift) { void sect_RelByte(Expression const &expr, uint32_t pcShift) {
if (!requireCodeSection()) { if (!requireCodeSection()) {
return; return;
} }
@@ -782,15 +782,13 @@ void sect_RelByte(Expression &expr, uint32_t pcShift) {
} }
// Output several bytes that can be relocatable or constant // Output several bytes that can be relocatable or constant
void sect_RelBytes(uint32_t n, std::vector<Expression> &exprs) { void sect_RelBytes(uint32_t n, std::vector<Expression> const &exprs) {
if (!requireCodeSection()) { if (!requireCodeSection()) {
return; return;
} }
for (uint32_t i = 0; i < n; i++) { for (uint32_t i = 0; i < n; i++) {
Expression &expr = exprs[i % exprs.size()]; if (Expression const &expr = exprs[i % exprs.size()]; !expr.isKnown()) {
if (!expr.isKnown()) {
createPatch(PATCHTYPE_BYTE, expr, i); createPatch(PATCHTYPE_BYTE, expr, i);
writeByte(0); writeByte(0);
} else { } else {
@@ -800,7 +798,7 @@ void sect_RelBytes(uint32_t n, std::vector<Expression> &exprs) {
} }
// Output a word that can be relocatable or constant // Output a word that can be relocatable or constant
void sect_RelWord(Expression &expr, uint32_t pcShift) { void sect_RelWord(Expression const &expr, uint32_t pcShift) {
if (!requireCodeSection()) { if (!requireCodeSection()) {
return; return;
} }
@@ -814,7 +812,7 @@ void sect_RelWord(Expression &expr, uint32_t pcShift) {
} }
// Output a long that can be relocatable or constant // Output a long that can be relocatable or constant
void sect_RelLong(Expression &expr, uint32_t pcShift) { void sect_RelLong(Expression const &expr, uint32_t pcShift) {
if (!requireCodeSection()) { if (!requireCodeSection()) {
return; return;
} }
@@ -828,7 +826,7 @@ void sect_RelLong(Expression &expr, uint32_t pcShift) {
} }
// Output a PC-relative byte that can be relocatable or constant // Output a PC-relative byte that can be relocatable or constant
void sect_PCRelByte(Expression &expr, uint32_t pcShift) { void sect_PCRelByte(Expression const &expr, uint32_t pcShift) {
if (!requireCodeSection()) { if (!requireCodeSection()) {
return; return;
} }