gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix symbol length checking

Browse Source 
When the while loop in `ParseSymbol` stops because of the symbol length,
`copied` will have the value of `MAXSYMLEN`, which is obviously not
greater than `MAXSYMLEN`. Changing the condition to `>=` fixes the
issue.

As a bonus, the correct union field will now be used. It shouldn't
matter, but it's technically UB to use a wrong one.
This commit is contained in:
Jakub Kądziołka
2019-03-02 19:11:53 +01:00
parent c59cb6a828
commit 2f2f14bf80
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/asm/globlex.c
View File

@@ -188,7 +188,7 @@ uint32_t ParseSymbol(char *src, uint32_t size)
}
}
if (copied > MAXSYMLEN)
if (copied >= MAXSYMLEN)
fatalerror("Symbol too long");
dest[copied] = 0;
@@ -206,7 +206,7 @@ uint32_t ParseSymbol(char *src, uint32_t size)
return 0;
}
strcpy(yylval.tzString, dest);
strcpy(yylval.tzSym, dest);
return 1;
}