mirror of
https://github.com/gbdev/rgbds.git
synced 2025-11-25 04:22:07 +00:00
Remove signoff step from contributing guide.
This commit is contained in:
@@ -75,24 +75,22 @@ copyright and the reference to the MIT License.
|
||||
new warning (but it may be possible to remove some warning checks if it makes
|
||||
the code much easier).
|
||||
|
||||
5. Sign off your commits: ``git commit -s``
|
||||
|
||||
6. Follow the Linux kernel coding style, which can be found in the file
|
||||
5. Follow the Linux kernel coding style, which can be found in the file
|
||||
``Documentation/process/coding-style.rst`` in the Linux kernel repository.
|
||||
Note that the coding style isn't writen on stone, if there is a good reason
|
||||
to deviate from it, it should be fine.
|
||||
|
||||
7. Download the files ``checkpatch.pl``, ``const_structs.checkpatch`` and
|
||||
6. Download the files ``checkpatch.pl``, ``const_structs.checkpatch`` and
|
||||
``spelling.txt`` from the folder ``scripts`` in the Linux kernel repository.
|
||||
|
||||
8. To use ``checkpatch.pl`` you can use ``make checkpatch``, which will check
|
||||
7. To use ``checkpatch.pl`` you can use ``make checkpatch``, which will check
|
||||
the coding style of all patches between the current one and the upstream
|
||||
code. By default, the Makefile expects the script (and associate files) to be
|
||||
located in ``../linux/scripts/``, but you can place them anywhere you like as
|
||||
long as you specify it when executing the command:
|
||||
``CHECKPATCH=../path/to/folder make checkpatch``.
|
||||
|
||||
9. Create a pull request against the branch ``develop``.
|
||||
8. Create a pull request against the branch ``develop``.
|
||||
|
||||
10. Be prepared to get some comments about your code and to modify it. Tip: Use
|
||||
9. Be prepared to get some comments about your code and to modify it. Tip: Use
|
||||
``git rebase -i origin/develop`` to modify chains of commits.
|
||||
|
||||
Reference in New Issue
Block a user