Merge pull request #374 from Ben10do/pushs-outside-of-section

Allow PUSHS to be used before a section

CONTRIBUTORS.rst

@@ -22,7 +22,7 @@ Main contributors
 Other contributors
 ------------------
 
-- Ben10do
+- Ben Hetherington <dev@ben-h.uk>
 
 - Björn Höhrmann <bjoern@hoehrmann.de>
 

src/asm/output.c

@@ -1,7 +1,7 @@
 /*
  * This file is part of RGBDS.
  *
- * Copyright (c) 1997-2018, Carsten Sorensen and RGBDS contributors.
+ * Copyright (c) 1997-2019, Carsten Sorensen and RGBDS contributors.
  *
  * SPDX-License-Identifier: MIT
  */
@@ -655,7 +655,7 @@ void out_SetCurrentSection(struct Section *pSect)
 		fatalerror("Cannot change the section within a UNION");
 
 	pCurrentSection = pSect;
-	nPC = pSect->nPC;
+	nPC = (pSect != NULL) ? pSect->nPC : 0;
 
 	pPCSymbol->nValue = nPC;
 	pPCSymbol->pSection = pCurrentSection;

test/asm/pops-no-pushed-sections.asm

@@ -0,0 +1 @@
+POPS

test/asm/pops-no-pushed-sections.out

@@ -0,0 +1,2 @@
+ERROR: pops-no-pushed-sections.asm(1):
+    No entries in the section stack

test/asm/pops-no-pushed-sections.out.pipe

@@ -0,0 +1,2 @@
+ERROR: -(1):
+    No entries in the section stack

test/asm/pops-restore-no-section.asm

@@ -0,0 +1,10 @@
+PUSHS
+
+SECTION "Test", ROM0
+SomeContent:
+	db 1, 2, 3, 4, 5, 6, 7, 8, 9
+
+POPS
+
+DisallowedContent:
+	db 0

test/asm/pops-restore-no-section.out

@@ -0,0 +1,2 @@
+ERROR: pops-restore-no-section.asm(10):
+    Code generation before SECTION directive

test/asm/pops-restore-no-section.out.pipe

@@ -0,0 +1,2 @@
+ERROR: -(10):
+    Code generation before SECTION directive

test/asm/pushs-outside-section.asm

@@ -0,0 +1,2 @@
+PUSHS
+POPS