gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer snprintf to sprintf

Browse Source 
This also simplifies advancing `ptr`
This commit is contained in:
Rangi42
2024-09-15 00:00:39 -04:00
parent 02439b18c0
commit 9b3d19c3f2
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/gfx/process.cpp
View File

@@ -627,8 +627,7 @@ static std::tuple<DefaultInitVec<size_t>, std::vector<Palette>>
static char buf[sizeof(", $XXXX, $XXXX, $XXXX, $XXXX")]; static char buf[sizeof(", $XXXX, $XXXX, $XXXX, $XXXX")];
char *ptr = buf; char *ptr = buf;
for (uint16_t cgbColor : list) { for (uint16_t cgbColor : list) {
sprintf(ptr, ", $%04x", cgbColor); ptr += snprintf(ptr, sizeof(", $XXXX"), ", $%04x", cgbColor);
ptr += QUOTEDSTRLEN(", $XXXX");
} }
return &buf[QUOTEDSTRLEN(", ")]; return &buf[QUOTEDSTRLEN(", ")];
}; };