gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-21 21:27:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,549 Commits 3 Branches 52 Tags
255cd7f7f6db28d205b4924fd27ea72f78880f44
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ISSOtm 3eb8c7e8f2 Let tests know they are being run under Cygwin 2026-07-05 20:58:50 -04:00
ISSOtm 4a77c42ed7 Remove redundant labels from tests 
It's possible to filter tests by name (`-R`)
 2026-07-02 10:39:59 -04:00
ISSOtm b12eac356e Try to automatically determine the test OS name 2026-07-02 10:39:59 -04:00
ISSOtm 82702d8149 Point out an ordering dep isn't a success one 2026-07-02 10:39:59 -04:00
ISSOtm 1f9cc9651a Avoid fetching some repos twice 
Also enables a nice bit of logic cleanup
 2026-07-02 10:39:59 -04:00
ISSOtm 04b9c7fa3d Move external tests files to tests/external/ 2026-07-02 10:39:59 -04:00
ISSOtm 5e8a6cde20 Remove the need to explicitly list external tests 
I like having a single source of truth!
 2026-07-02 10:39:59 -04:00
ISSOtm d59081a918 Shorten external test prop names slightly 
Makes the scripts a bit easier to read, I think
 2026-07-02 10:39:59 -04:00
ISSOtm e3fc46f933 Remove static compile flags 
We support CMake now, which can generate a more accurate `compile_commands.json` database
(and our `develop` preset automatically enables them)
 2026-06-30 16:52:31 +02:00
ISSOtm 0ed8c2f8ee Docu-comment an implicit correctness assumption 2026-05-14 14:47:23 +02:00
ISSOtm d5186b088b Link against (non-debug) MSVC runtime statically 2026-05-14 14:47:23 +02:00
ISSOtm fee177d0b9 Link zlib and libpng statically by default 
Only when we are building them ourselves, that is.
 2026-05-14 14:47:23 +02:00
ISSOtm 1af8bdda16 Have CMake put RGBDS executables in our own dir 
Not the top-level if we are part of a larger project!
 2026-05-06 18:49:19 +02:00
ISSOtm fa22b78e7d Use type instead of which in shell scripts 
The latter is not a Bash built-in,
and some environments turn out to produce non-conforming
return codes.

`type` is provided by Bash itself,
so we can rely on it better.
 2026-05-05 16:03:33 +02:00
ISSOtm 37d39f91f6 Build using GCC 9 in CI 
Checking that we don't regress this later.
Ubuntu doesn't package GCC 8, and we don't support it either,
so that is a good compromise for now.
 2026-04-26 23:30:59 +02:00
ISSOtm d5ce5329ea Fix compilation with GCC 9 2026-04-26 23:30:59 +02:00
ISSOtm 6bcd79b997 Revert "Derive operator!= from operator== (#1660)" 
This reverts commit 993879a2ed.
 2026-04-26 23:30:59 +02:00
ISSOtm decc5f7153 Let parallelism be determined automatically 
Ninja is parallel by default;
however, it is not used on FreeBSD, so we still have to specify it there.
 2026-04-20 15:32:54 +02:00
ISSOtm a3c953ea46 Pass C++ compiler to CMake via env var 
This is a little terser
 2026-04-20 15:32:54 +02:00
ISSOtm d43049c84d Imply CMake source dir 
Shortening our command lines slightly
 2026-04-20 15:32:54 +02:00
ISSOtm b6ff54acc3 Avoid libpng compilation on Windows spamming the Microsoft banner 2026-04-20 15:32:54 +02:00
ISSOtm 71fc449452 Use Ninja on Unix platforms 
It has nicer UX, only showing full command lines when they fail.
It could also be slightly faster, though I've seen no measurable improvement.
 2026-04-20 15:32:54 +02:00
ISSOtm 59dd1fbbf8 Correct naming of MSBuild CMake presets 
You can build with MSVC without MSBuild
 2026-04-20 15:32:54 +02:00
ISSOtm 2502d130eb Use Ninja on Windows 
MSBuild is slow, and its output is hard to parse visually
(it's all interwoven, like Make without `--output-sync`).
Since we use CMake anyway, we don't care about the build system.
 2026-04-20 15:32:54 +02:00
ISSOtm a78a268cb4 Pass convenience options to Make invoked via CMake 
Can't pass them to plain Make invocations,
because we try to be compatible with macOS' old Make.
 2026-04-20 15:32:54 +02:00
ISSOtm aeedfb35a6 Set up Cygwin before cloning our repo 
Otherwise different Gits set up and tear down the repo,
leading to issues.
 2026-04-16 03:16:56 +02:00
ISSOtm 63609871f4 Cache downloaded dependencies for MinGW build also 
Forgot about you!
 2026-04-16 02:56:14 +02:00
ISSOtm 393eaa9dc1 Fix a Fix typo ;) 2026-04-16 02:54:40 +02:00
ISSOtm 185a5c5369 Add necessary flags to apt install for checkformat 2026-04-16 01:58:42 +02:00
ISSOtm 4ea15ed85a Touch up checkformat.bash 
The logic can be slightly simplified,
and the script doesn't require Bash after all.
 2026-04-16 01:05:03 +02:00
ISSOtm b218fd65a0 Install clang-format on ubuntu-slim runner 
Unlike the “fat” runners, that's not installed by default.
Why that causes `find` to nonetheless exit normally, I have no idea.
 2026-04-16 01:02:30 +02:00
ISSOtm 81edc27b6e Fix two warnings on MinGW 2026-04-16 00:57:33 +02:00
ISSOtm dc52487d31 Make -Wformat non-fatal on MinGW 
See the comment for a rationale.
 2026-04-16 00:57:33 +02:00
ISSOtm 6b994b1737 Fix some warnings raised by MSVC 2026-04-16 00:57:33 +02:00
ISSOtm 0849eb801e Decouple -Werror from MORE_WARNINGS 2026-04-16 00:57:33 +02:00
ISSOtm e6916360f4 Set some flags only for our own code 2026-04-16 00:57:33 +02:00
ISSOtm a802bcb320 Switch MinGW building to CMake 
Automatically grabs and compiles libpng, and avoids having hacky lines in our Makefile
(the compiler specification *should* be orthogonal to the build target!)

Also move the MinGW package install to the `install_deps.sh` script,
to move logic off of the YAML.
 2026-04-16 00:57:33 +02:00
ISSOtm 846aa975f1 Stop trying to install md5sha1sum 
macOS already provides it and Homebrew doesn't override it,
so that's a no-op anyway.
 2026-04-16 00:25:58 +02:00
ISSOtm b65649ca73 Tidy up system info 2026-04-16 00:25:58 +02:00
ISSOtm 62ddabb570 Avoid hardcoding Brew's prefix 2026-04-16 00:25:58 +02:00
ISSOtm d48d6fe5d9 Bump our macOS CI runners 2026-04-16 00:25:58 +02:00
Eldred Habert ac0f93ffda Delete GCC static analyzer workflow (#1950) 
As for GCC 15, it is stated not to be suitable for C++ code,
and we have gotten annoyingly many false positives out of it,
so let's just disable it (as per
https://github.com/gbdev/rgbds/pull/1950#issuecomment-4243959126).
 2026-04-14 22:04:20 +02:00
ISSOtm a1712cb6d9 Run patch format check on ubuntu-slim 2026-04-14 22:03:29 +02:00
Eldred Habert 2968bee86f Run macos-static tests using CTest (#1947) 
We can, so why not? It has benefits.
 2026-04-14 01:25:47 +02:00
ISSOtm dec7a74166 Fix macOS static build 
- Turns out the variable wasn't being set, and thus the flags weren't being passed
- Passing the flags via those variables is basically a bad idea, and it
  turns out to break libpng's config script
- The flags need to be passed during link as well, otherwise the binary
  isn't linked as a fat one
 2026-04-14 00:01:14 +02:00
Eldred Habert 9c4e53d1c4 Transition CI from pkg-config to pkgconf (#1942) 
Upstream has changed the providing implementation,
so that package will eventually be removed.
 2026-04-13 19:46:05 +02:00
Eldred HabertandRangi 463edc3c01 Enable color output in our Linux and macOS CI tests (#1939) 
Co-authored-by: Rangi <[email protected]>
 2026-04-13 19:31:01 +02:00
Eldred Habert 65ec1af1e8 Switch macOS static build to CMake (#1938) 
This moves the tortuous flags out of our CI scripts,
and allows us to benefit from the libpng download caching.
 2026-04-12 22:26:15 -04:00
Eldred Habert bc3572ec37 Stop trying to explicitly install pkg-config in CI (#1940) 
Turns out it's already installed by default,
but under a different name that's causing extra ops
for no real gain.
 2026-04-12 22:08:38 -04:00
Eldred Habert 78281a4aaa Break down CTest cases into each test suite (#1931) 
This allows parallelising the individual programs'
test suites, which can save a few minutes!
 2026-04-12 21:29:12 -04:00
ISSOtm 6e51ab6f55 Remove a duplicate warning flag 
We always pass this one
 2026-04-13 01:52:25 +02:00
ISSOtm 52aaf7e3b3 Fix MSVC dependent option syntax 
This is not how CMake works lol
 2026-04-13 01:37:38 +02:00
ISSOtm 09db4f25dd Bump the maximum version of CMake tested with 
Future-proofing!
This is both the version on my own machine,
and what's distributed by Homebrew (thus on GitHub's runners).
 2026-04-13 00:33:31 +02:00
Eldred Habert fed5db7743 Move documentation outside of the root directory (#1936) 2026-04-12 18:09:40 -04:00
ISSOtm c6dbec7830 Stop trying to run version test on Cygwin and FreeBSD 
Fixes #1934
 2026-04-12 23:40:39 +02:00
Eldred Habert 017b0119e6 Overhaul checkdiff CI (#1930) 2026-04-12 16:06:28 -04:00
Eldred Habert 0e6e91d048 Avoid copying RGBFIX binary when testing it (#1933) 
This is just cleaner in general,
and also avoids separating it from any DLLs it may be needing.
 2026-04-12 13:23:51 -04:00
Eldred Habert 123201ecc6 Avoid repeatedly specifying bash as the command shell in CI (#1926) 2026-04-10 22:04:16 -04:00
Eldred Habert 422e8eec20 Generate Bison output in CMake build tree (#1929) 
Again, moving away from in-tree builds
 2026-04-10 18:46:57 -04:00
ISSOtm 4577ff16bc Generate Bison output in CMake build tree 
Again, moving away from in-tree builds
 2026-04-10 22:56:59 +02:00
ISSOtm b430d5a8b8 Note why we are not using a CMake list to pass Bison flags 2026-04-10 22:33:54 +02:00
ISSOtmandvulcandth a5be1d886e Copy DLLs to appropriate dir for install-less Windows testing 
Co-authored-by: vulcandth <[email protected]>
 2026-04-10 18:01:16 +02:00
ISSOtm ace2f3e613 Document why lib src cache is cross-OS 
See https://github.com/gbdev/rgbds/pull/1919#discussion_r3048475606
 2026-04-08 12:25:43 +02:00
ISSOtm 8d1a60d6b5 Switch release process to a lightweight runner 
Easier to provision, less concurrency overhead for us
 2026-04-08 12:25:43 +02:00
ISSOtm 11ac22d8f5 Switch from an Action to gh release 
Fewer supply chain risks whooooo
 2026-04-08 12:25:43 +02:00
ISSOtm 812e1f6d4b Remove dead code checking for version tag 
It was also vulnerable to template injection attacks.
 2026-04-08 12:25:43 +02:00
ISSOtm 8dc052475b Avoid caching in our release workflow 
This is a malware distrib vector,
and we run this workflow sporadically enough
that we can afford to do so uncached.
 2026-04-08 12:25:43 +02:00
ISSOtm 133eaa4e92 Build Windows release in, well, Release mode 2026-04-08 12:25:43 +02:00
ISSOtm 57f1894fbd Fix installing Windows build deps on release 2026-04-08 12:25:43 +02:00
ISSOtm 021fe01eb0 Avoid CMake looking at test dir if testing is disabled 
This saves building the two test support programs.
 2026-04-08 12:25:43 +02:00
ISSOtm bcff14b596 Clean up docs workflows 
Usethe `ubuntu-slim` runner to (hopefully) get faster setup times
 2026-04-07 21:48:26 +02:00
Eldred Habert 44b6a2c453 Add a key that turns out to be required 
The documentation is super flaky tbh
 2026-03-31 02:14:24 +02:00
Eldred Habert 3fc3130364 Fix some YAML syntax 
I prefer TOML and JSON anyway...
 2026-03-31 02:12:29 +02:00
Eldred Habert 5090395ca7 Enable GH Actions to be automatically bumped 
Turns out those get new major releases somewhat often, and we get deprecation warnings and brownouts and all that.
Automatic bumps should help us avoid that, though I've set a *very* large scan interval to shield us from churn.
 2026-03-31 02:03:37 +02:00
ISSOtm 8025c2ae66 Require uploaded artifacts to be non-empty 
We can get silent failures otherwise
 2026-03-28 11:31:49 +01:00
ISSOtm f7831ce8da Simplify CTest pre-run test command 2026-03-28 01:21:08 +01:00
ISSOtm b736fa22ff Suppress status messages when fetching test deps 
Let's avoid status message spam.
 2026-03-27 22:07:28 +01:00
ISSOtm 0692d1d28c Avoid passing a C++-only flag when compiling C files 
Avoids compiler warnings. This can happen because zlib and libpng are both C projects,
and we build them from source if they are unavailable.
 2026-03-25 17:11:46 +01:00
Eldred Habert 4b69d5cc8a Fix name of test repo cache used by macos-static (#1909) 2026-03-24 09:02:28 -04:00
Eldred Habert 52aa518e20 Enable Git colours in CI 2026-03-24 12:40:34 +01:00
Eldred Habert d9932b9031 Always clone deps with --depth=1 (#1908) 2026-03-23 11:02:29 -04:00
ISSOtm b8e425b41d Avoid passing irrelevant flags to our deps 2026-03-19 20:30:12 +01:00
ISSOtm 6b0658fb59 Cache library deps on Windows 
Besides the immediate performance improvement, reducing
the frequency of downloads should make spurious
failures (network, rate-limiting...) less bothersome.
 2026-03-19 20:30:12 +01:00
ISSOtm 91fdfcd179 Specify MSVC architecture using presets 
Shortens CI command lines slightly,
and documents the requirement.
 2026-03-19 20:30:12 +01:00
ISSOtm 5abebcf61f Specify build type implicitly 
Again, shortening the CMake command line.
Unfortunately, this doesn't apply to `--install`.
 2026-03-19 20:30:12 +01:00
ISSOtm 145473d9bd Use develop preset on FreeBSD 
Leak detection is not supported, so we have to disable it.
 2026-03-19 20:30:12 +01:00
ISSOtm 2fb64816a9 Indicate more clearly that LTO is not used in debug mode 
This has made me worried once or twice
 2026-03-19 20:30:12 +01:00
ISSOtm 7cf330e3f9 Enable CMake parallelism in a central place 
Shortening command lines is useful
 2026-03-19 20:30:12 +01:00
ISSOtm 2e66515096 Invoke CTest directly 
This allows passing it arguments directly, like `--verbose` here
(which is more appropriate for CI use).
 2026-03-19 20:30:12 +01:00
ISSOtm c93f377bfb Enable colour diagnostics in CI 
At least for CMake.
 2026-03-19 20:30:12 +01:00
ISSOtm d6d1844d60 Seek lib deps via CMake FetchContent 
`FetchContent` respects existing installs, and downloads and compiles the libs
if they aren't found.
This is admittedly a little finicky, since this ignores the usual `Find*`
modules provided by CMake, requiring a bit of glue on our side.

But, one upside is that this moves that logic from our CI into the build system,
which can thus benefit other downstream users.
This also opens the door to some improvements in upcoming commits.

Doing this with Bison turned out to be much more painful, however, due to
`FindBISON` providing the specific `bison_target` command; thus, it remains
installed externally, so that it can be picked up by `FindBISON`.

This also bumps our CMake version requirement slightly, though it's
possible that older versions keep working, or could be supported with small patches;
however, our CI doesn't provide anything below 3.31, so we can't check.
 2026-03-19 20:30:12 +01:00
ISSOtm fd38a3dbc4 Add CMake and YAML files to EditorConfig 
Since we use a different style for those
 2026-03-19 20:30:12 +01:00
ISSOtm 60d58723aa Use a modern GNU Make for CMake CI on macOS 
We can assume that CMake handles old Make correctly,
but we'd like to benefit from improvements
like output batching.
 2026-03-19 20:30:12 +01:00
ISSOtm a9b6cda77b Reorder CMakeLists commands by topic 2026-03-17 08:18:50 +01:00
ISSOtm 091452d591 Remove call to configuring version file 
Missed in 5c4ca36c5a
 2026-03-17 05:28:23 +01:00
ISSOtm df1d909853 Improve documentation of CMake bin output dir 2026-03-17 05:27:39 +01:00
ISSOtm fb4e08ce71 Tidy up CMake sanitizer flags 
Set the flags in the build itself instead of trying to override the cache
(this was an artifact of when I didn't understand the CMake variable model),
which avoids them being duplicated on each re-configuration.

Also remove `-g`, since it's defined by the build type by default
(we leave it up to the user to choose Debug or RelWithDebInfo).
 2026-03-16 20:23:47 -04:00
ISSOtm 7244b9d17e Silence the same warning as in the Makefile 
As requested by https://github.com/gbdev/rgbds/pull/1899#discussion_r2943039607
 2026-03-16 20:23:47 -04:00
ISSOtm 5c4ca36c5a Harmonise passing build version 
Avoid running some configure step, instead pass it as a define like the Makefile
 2026-03-16 20:23:47 -04:00
ISSOtm 292c297518 Sync Windows release steps with new CI 2026-03-16 20:23:47 -04:00