gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-08-20 05:44:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,288 Commits 3 Branches 52 Tags
b299f6fb3b8fcf24dc339caf0074707befdbfbce
Commit Graph
1288 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ISSOtm b299f6fb3b Fix uninitialized memory use with -MT and -MQ 
This didn't break unless the first uninitialized byte was non-zero,
which happened to be the case on someone's Windows machine.

Would it be worth it setting up Valgrind in CI?
 2020-05-06 19:19:10 +02:00
Eldred Habert 645473e336 Merge pull request #518 from JL2210/warn-parameterless-dx 
Add empty data directive warning
 2020-05-06 16:25:03 +02:00
James Larrowe bdf397bba7 Add empty data directive warning 
Fixes #516
 2020-05-06 09:50:28 -04:00
ISSOtm 781a65ee49 Fix hashmap collisions sometimes hanging deletion 2020-05-03 19:13:12 +02:00
ISSOtm c135e2c6a0 Fix local sym names not being expanded by PURGE 
And an additional bug that broke the attached test
 2020-05-03 19:06:48 +02:00
ISSOtm 12693081c9 Use colons for hour symbols 2020-04-28 13:05:06 +02:00
Eldred Habert 7c22954fd5 Merge pull request #513 from JL2210/disable-padding-option 
Add option to disable padding in rgblink
 2020-04-27 11:05:55 +02:00
ISSOtm 8958e352df Update documentation for new -x option 2020-04-27 11:04:29 +02:00
ISSOtm 573003113b Fix 0-byte sections incorrectly printed in map files 
Fixes #515
 2020-04-17 11:38:28 +02:00
JL2210 8b1351fc3e Add option to disable padding in rgblink 
Fixes #307

RGBFIX can handle padding, so there's no reason why
we can't add an option to disable padding in rgblink.

Signed-off-by: JL2210 <[email protected]>
 2020-04-15 09:34:51 -04:00
Eldred Habert 106ef895ee Merge pull request #514 from JL2210/fix-gfx-gb-leak 
Add error checking and fix memory leak in gfx/gb.c
 2020-04-14 21:31:12 +02:00
JL2210 7f9bd12f76 Add error checking and fix memory leak in gfx/gb.c 
It's possible that tile could be leaked, so free it.

Fix sizeof convention and check the result of malloc.

Signed-off-by: JL2210 <[email protected]>
 2020-04-13 22:02:24 -04:00
ISSOtm 5fe3a0adb6 Remove non-OPT options from Options struct 2020-04-13 17:15:00 +02:00
Eldred Habert cdb4c5f553 Merge pull request #509 from JL2210/zero-alloc-use-fix-3 
Fix use of zero-allocated memory
 2020-04-13 02:50:58 +02:00
ISSOtm 57639f3765 Change comment style and use errx instead of err 2020-04-13 02:50:11 +02:00
Eldred Habert 9bec983923 Merge pull request #511 from JL2210/memory-errors 
Fix memory errors in makepng
 2020-04-13 02:39:17 +02:00
ISSOtm 2220f19fa7 Fix use-after-free with include in linker scripts 
Fixes #510, and further proves that you *really* should not entrust memory
ownership management to humans :P
 2020-04-13 02:36:19 +02:00
JL2210 2a734ecba2 Fix memory errors 
This includes not checking the result of malloc and
using the wrong type in sizeof. Only the latter was
caught by scan-build.

Also use more idiomatic sizeof().

Signed-off-by: JL2210 <[email protected]>
 2020-04-12 19:45:37 -04:00
JL2210 d21015e34a Fix use of zero-allocated memory 
It's possible that the unsigned integer may overflow to zero,
and then we might use zero-allocated memory.

This is incredibly unlikely, and I would even go so far as to say
that this is a false positive. Fix it anyway, to silence this warning:

src/link/patch.c:92:24: warning: Use of zero-allocated memory
        stack.buf[stack.size] = value;
        ~~~~~~~~~~~~~~~~~~~~~ ^

Deal with overflow, and check for zero to get rid of the warning.

Signed-off-by: JL2210 <[email protected]>
 2020-04-12 19:36:47 -04:00
ISSOtm 023a3c037f Properly handle missing symbols 
Fixes #512
 2020-04-12 22:52:32 +02:00
ISSOtm 828edb7403 Remove spurious error from div by zero test 2020-04-12 01:05:06 +02:00
ISSOtm a034ce0478 Deprecate '*' for comments 2020-04-09 17:57:15 +02:00
Eldred Habert d6cd5823e3 Merge pull request #508 from JL2210/mod-by-zero-fix-2 
Fix modulo by zero
 2020-04-09 14:52:12 +02:00
JL2210 5dd941b311 Fix modulo by zero 
Yet another case caught by scan-build:

src/link/patch.c:188:21: warning: Division by zero
                        value = popRPN() % value;
                                ~~~~~~~~~^~~~~~~

Just copy over the code from the division case, with a few modifications.

Signed-off-by: JL2210 <[email protected]>
 2020-04-09 08:50:23 -04:00
ISSOtm f9f27d6f5a Clean up symbol system 
Get rid of Hungarian notation
Improve encapsulation (the rest of the world should not touch PC directly)
 2020-04-09 10:42:37 +02:00
Eldred Habert 5ea8490e2b Merge pull request #507 from JL2210/null-pointer-fix-1 
Fix possible null pointer dereference
 2020-04-08 23:35:21 +02:00
JL2210 5863cd10b8 Fix possible null pointer dereference 
It's possible that if the FILE passed to yy_create_buffer is at the
end-of file, there may be a null pointer dereference.

This should hopefully fix that.

Found with clang-tools' scan-build:

src/asm/lexer.c:281:25: warning: Array access (via field 'pBuffer')
 results in a null pointer dereference
        pBuffer->pBuffer[size] = 0;
                 ~~~~~~~       ^
1 warning generated.

Signed-off-by: JL2210 <[email protected]>
 2020-04-08 17:30:43 -04:00
ISSOtm 40f8e33e6c Fix periods not being accepted as second char of label names 2020-04-08 15:14:07 +02:00
ISSOtm 0157ba63d3 Document whitespace before local labels 2020-04-08 15:08:29 +02:00
ISSOtm 9e3d8b22cb Document new intra-section align 
Also sneak in two code style fixes forgotten in last commit
 2020-04-08 15:01:36 +02:00
ISSOtm 665412c073 Implement mid-section alignment directive 
Fixes #254.
 2020-04-08 12:29:00 +02:00
ISSOtm 2b0c34ecb5 Fix a few code style errors 2020-04-08 00:44:41 +02:00
ISSOtm b0ec8468e6 Allow specifying offset in addition to alignment 2020-04-08 00:40:41 +02:00
ISSOtm e82ad21704 Use a single byte for alignment 2020-04-07 21:19:09 +02:00
ISSOtm e098bf47ba Allow references to be overridden by constant symbols 
RGBLINK is capable of handling it now.
Though it'd be ideal for RGBASM to directly catch it.

Fixes #496.
 2020-04-07 20:57:20 +02:00
ISSOtm 190678107b Prevent RGBLINK from crashing when getting the bank of a constant 2020-04-07 20:41:29 +02:00
ISSOtm 9f82fa4cf7 Fix BANK(@) outside sections causing crashes 2020-04-07 15:51:17 +02:00
Eldred Habert 562835308b Merge pull request #504 from runlevel5/gcc10-fix 
Fix multiple definitions for GCC10
 2020-04-07 15:18:23 +02:00
ISSOtm 927c65e863 Fix incorrect PC in LOAD blocks at link time 2020-04-07 14:44:51 +02:00
ISSOtm 5b6c1569a4 Make failure to open file a fatal error 2020-04-07 11:36:44 +02:00
Trung Lê 65121e6d5d Fix multiple definitions for GCC10 2020-04-07 14:48:30 +10:00
ISSOtm 82e0e4ffaf Make some RGBLINK errors non-fatal 2020-04-06 00:48:10 +02:00
ISSOtm ffb199a26a Avoid Useless Use of backticks in rgblink testing 2020-04-06 00:44:59 +02:00
ISSOtm 175933d2b1 Remove old scripts for updating references for tests 
I much rather prefer correcting everything by hand, and gauging
whether the change is good on a case by case basis
 2020-04-06 00:41:37 +02:00
Eldred Habert c86e6fef0a Merge pull request #502 from JL2210/more-conventional-permissions 
Use more conventional permissions and man-page directory
 2020-04-06 00:25:33 +02:00
JL2210 1e3ce2a36f Use more conventional permissions and man-page directory 
As 444 and 555 seem to be used for no apparent reason, use the more
conventional 644 and 755.

/man is typically unused or a symlink to /share/man now, so just use
/share/man.

Signed-off-by: JL2210 <[email protected]>
 2020-04-05 17:02:12 -04:00
ISSOtm 153915dc2f Improve portability of new make dist 2020-04-04 14:48:15 +02:00
ISSOtm ced38bc6ee Add new Makefile target for release tarballs 2020-04-04 14:23:28 +02:00
ISSOtm 4e96cf9875 Release 0.4.0 v0.4.0 2020-04-03 12:11:50 +02:00
ISSOtm 80170eb6eb Regenerate man page HTML renders 2020-04-03 12:03:59 +02:00