gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-20 12:47:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,503 Commits 3 Branches 52 Tags
e4f5df1306c4eb09de57728f9756b951b41565aa
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Eldred Habert e4f5df1306 Merge pull request #603 from NieDzejkob/rpn-realloc 
reserveSpace: don't assume one doubling is enough
 2020-10-12 12:26:44 +02:00
ISSOtm 71d8aeb4c2 Add CMake defines to enable tracing lexer and parser 2020-10-12 09:02:21 +02:00
Eldred Habert 0836f67d42 Merge pull request #601 from NieDzejkob/utf8decoder 
utf8decoder: Use byte-sized byte argument
 2020-10-12 01:49:57 +02:00
Eldred Habert 176a57a1e9 Merge pull request #600 from NieDzejkob/stray-shift 
Report error when shifting outside a macro
 2020-10-12 01:44:10 +02:00
Eldred Habert 0d02355dbf Merge pull request #599 from NieDzejkob/stray-align 
Report error when aligning outside of a section
 2020-10-12 01:43:35 +02:00
ISSOtm 2dd9015dc6 Remove two stale variables from parser.y 
They were made useless with the lexer rewrite
 2020-10-12 00:52:12 +02:00
ISSOtm 0b1d01792d Indicate cur offset in linkerscript "backwards org" message 2020-10-12 00:04:08 +02:00
ISSOtm 01637768cf Rename asmy to more explicit parser 
This should make the purpose of that file clearer to newcomers
 2020-10-11 21:03:41 +02:00
ISSOtm 6a8ae643d5 Mention that SHIFT updates _NARG 
Fixes #598
 2020-10-11 02:13:30 +02:00
ISSOtm fd83d46ba0 Enable master docs update workflow always 
There seems to be no way to make the check work, and Actions are disabled
in forks by default anyways.
 2020-10-11 02:04:09 +02:00
ISSOtm 914856342c Fix incorrect documentation of accepted sym names 
No, they cannot start with a digit!
 2020-10-11 01:57:27 +02:00
Eldred Habert 91889fc14a Merge pull request #593 from Rangi42/issue586 
Fix #586: Update the `charmaps` hashmap when an existing charmap is resized
 2020-10-10 02:15:04 +02:00
Eldred Habert f9daf27511 Merge pull request #585 from ISSOtm/msvc-ci 
Add MSVC in CI
 2020-10-06 17:48:13 +02:00
ISSOtm 06f7387466 Avoid using VLA in EQUS dumping 
MSVC does not support those...
Also add a `develop` warning about VLAs, to avoid future incidents
 2020-10-06 08:55:45 +02:00
ISSOtm 21e50eeff1 Have lexer not require <unistd.h> on MSVC 
Required for `open`, `close`, `read`, and `STDIN_FILENO`,
which are defined elsewhere on MSVC.
 2020-10-06 08:55:45 +02:00
ISSOtm fd4cec93cd Compile with MSVC as well in CI 2020-10-06 08:55:41 +02:00
ISSOtm 92f2055a6c Fix implicit cast between enums 
This caused `make develop` to fail
 2020-10-05 01:53:54 +02:00
Eldred Habert be9b1198e9 Merge pull request #584 from Xeyler/master 
Add directory summary to README.rst
 2020-10-04 20:20:08 +02:00
Eldred Habert fdfc02ab96 Merge pull request #583 from JL2210/cmake-build-type 
Modularize CMake build configuration
 2020-10-04 19:45:20 +02:00
Eldred Habert fc7f042ad6 Merge pull request #551 from NieDzejkob/errors-after-unknown-symbol 
link: Suppress cascading errors.
 2020-10-04 19:43:38 +02:00
Eldred Habert 3036b58598 Merge pull request #557 from ISSOtm/new-lexer-electric-boogaloo 
New lexer 2 — Electric Boogaloo
 2020-10-04 16:45:47 +02:00
ISSOtm 2eca43cd2d Fix critical oversight in lexer buffer refilling 
Since the lexer buffer wraps, the refilling gets handled in two steps:
First, iff the buffer would wrap, the buffer is refilled until its end.
Then, if more characters are requested, that amount is refilled too.

An important detail is that `read()` may not return as many characters as
requested; for this reason, the first step checks if its `read()` was
"full", and skips the second step otherwise.
This is also where a bug lied.

After a *lot* of trying, I eventually managed to reproduce the bug on an
OpenBSD VM, and after adding a couple of `assert`s in `peekInternal`, this
is what happened, starting at line 724:

0. `lexerState->nbChars` is 0, `lexerState->index` is 19;
1. We end up with `target` = 42, and `writeIndex` = 19;
2. 42 + 19 is greater than `LEXER_BUF_SIZE` (= 42), so the `if` is entered;
3. Within the first `readChars`, **`read` only returns 16 bytes**,
   advancing `writeIndex` to 35 and `target` to 26;
4. Within the second `readChars`, a `read(26)` is issued, overflowing the
   buffer.

The bug should be clear now: **the check at line 750 failed to work!** Why?
Because `readChars` modifies `writeIndex`.
The fix is simply to cache the number of characters expected, and use that.
 2020-10-04 16:10:32 +02:00
ISSOtm c24694233f Fix incomplete duplication of REPT nodes 
"Initialization, sizeof, and the assignment operator ignore the flexible array member."
Oops!
 2020-10-04 04:46:01 +02:00
ISSOtm 423a7c4899 Handle \\r better 
Translate it to \\n regardless of the lexer mode
 2020-10-04 04:46:01 +02:00
ISSOtm ee9e45b3d4 Change assertion condition in __FILE__ buf dumping 
Removes a false positive from Clang static analysis
 2020-10-04 04:46:01 +02:00
ISSOtm 5a65188ca9 Implement compact file stacks in object files 
Gets rid of `open_memstream`, enabling Windows compatibility again
Also fixes #491 as a nice bonus!
 2020-10-04 04:46:01 +02:00
ISSOtm 930080f556 Mark not unmapping macro-containing files as okay 
There isn't really a better alternative.
Making several mappings instead requires too much bookkeeping.
 2020-10-04 04:46:01 +02:00
ISSOtm 8e7afb0ab3 Move some MSVC-specific defines to platform.h 2020-10-04 04:46:01 +02:00
ISSOtm 138523570e Fix possible uninitialized read on Windows 2020-10-04 04:46:01 +02:00
ISSOtm 82469ac0fd Shim around mmap on Windows 2020-10-04 04:46:01 +02:00
ISSOtm 96cb5e10ed Fix range-dependent dead code in recursion depth check 2020-10-04 04:46:01 +02:00
ISSOtm b224cab3e0 Harmonize printing distance 2020-10-04 04:46:01 +02:00
ISSOtm 7381d7b92f Remove unnecessarily nested symbol data union 2020-10-04 04:46:01 +02:00
ISSOtm dbef51ba05 Move isWhitespace to a place where it makes more sense 2020-10-04 04:46:01 +02:00
ISSOtm c952dd8a6e Fix fixed-point constants not working correctly 
And added a test to check their behavior
 2020-10-04 04:46:01 +02:00
ISSOtm b65ea64a58 Add newlines to all test output 
MacOS treats them differently, for some reason.
 2020-10-04 04:46:01 +02:00
ISSOtm 542b5d18f1 Fix possible capture buffer size overflow 
Attempt to grow it to the max size first.
Seriously, if this triggers, *how*
 2020-10-04 04:46:01 +02:00
ISSOtm 71a0a42cfb Fix C2x use of static_assert 2020-10-04 04:46:01 +02:00
ISSOtm ac011fe69f Use common function to discard comments in macro args 2020-10-04 04:46:01 +02:00
ISSOtm 9e3d7a50e6 Handle comments in line continuations 2020-10-04 04:46:00 +02:00
ISSOtm e33c2ad6a2 Fix INCLUDE ignoring -MG 2020-10-04 04:46:00 +02:00
ISSOtm 615f1072d9 Fix readFractionalPart never shifting characters 2020-10-04 04:46:00 +02:00
ISSOtm f7b7a97407 Prevent expanding macro args in comments 
Also use a cleaner way, instead of hardcoding to capture
 2020-10-04 04:46:00 +02:00
ISSOtm ece6853e0f Implement opt b and opt g 2020-10-04 04:46:00 +02:00
ISSOtm b7b03ee451 Fix "REPT 0" not being a no-op 2020-10-04 04:45:59 +02:00
ISSOtm f9b48c0cad Fix else working incorrectly from macros 
Since the "skip ELSE blocks" variable is global, it used to get carried
over from the macro's `if` to the outer's.
 2020-10-04 04:45:59 +02:00
ISSOtm aa76603da9 Add line+col trace info to lexer 2020-10-04 04:45:59 +02:00
ISSOtm b83b9825f8 Fix _NARG crashing outside of macros 
And add a test for it
 2020-10-04 04:45:59 +02:00
ISSOtm d641972cde Fix macro args not being restored when exiting macros 2020-10-04 04:45:59 +02:00
ISSOtm 4d1333e124 Fix incorrect error reporting of INCLUDEd files 2020-10-04 04:45:59 +02:00
ISSOtm 35396e6410 Fix files being unmapped when still referenced by macros 2020-10-04 04:45:59 +02:00
ISSOtm 8d18b39eee Support missing register tokens 
Made possible by #491
 2020-10-04 04:45:59 +02:00
ISSOtm ae77893021 Fix file name reporting 
As noted in the function's code, this is very error-prone, but
will do the job; this needs rewriting due to #491 anyways, so, temporary.
 2020-10-04 04:45:59 +02:00
ISSOtm baeb180acd Apply error reporting changes to tests 2020-10-04 04:45:58 +02:00
ISSOtm fd02ffb7bd Implement __FILE__ symbol 
Also clean up built-in symbol creation
This is not great, but currently okay.
Should be fixed later, like the rest...
 2020-10-04 04:45:58 +02:00
ISSOtm 62ecdce0b0 Fix line-continuation-macro test 2020-10-04 04:45:58 +02:00
ISSOtm e4f2fad215 Support line continuations in main scope 2020-10-04 04:45:58 +02:00
ISSOtm 3f5f9bcaf0 Fix numeric constant overflow checks 2020-10-04 04:45:58 +02:00
ISSOtm 08867b3cec Enable catching invalid macro arg 0 2020-10-04 04:45:55 +02:00
ISSOtm 9081feab51 Reinstate macro arg scan distance 
Used to be broken, so it was removed, but doing so prevents escaping them.
So it was instead put back in, but with corrected behavior
 2020-10-04 04:39:27 +02:00
ISSOtm cf992164f7 Fix lexer capture sometimes not being reset 2020-10-04 04:39:27 +02:00
ISSOtm b27b821e7f Fix RAW lexer length underflow 
Also added an assertion to check against more such overflows
 2020-10-04 04:39:26 +02:00
ISSOtm d9ecaabac1 Add debug tracing code to lexer 
Hidden behind a #define, like YYDEBUG
 2020-10-04 04:39:26 +02:00
ISSOtm cd747d8175 Fix many lexer bugs 
More to come...
 2020-10-04 04:39:25 +02:00
ISSOtm df75fd2ec2 Fix expansion reporting being incorrect 2020-10-04 04:38:53 +02:00
ISSOtm adcaf4cd46 Fix crash when no macro args are being used 2020-10-04 04:38:53 +02:00
ISSOtm 81a77a9b88 Re-implement block copy to avoid expanding macro args 
They were expanded during the capture, and there was no easy way to
avoid expanding them (believe me, after three hours and somehow an OOM, I
gave up trying).
 2020-10-04 04:38:53 +02:00
ISSOtm 6e805cd318 Implement macro args 
This finally allows running 90% of the test suite, debugging time!
 2020-10-04 04:38:53 +02:00
ISSOtm e11f25024e Add test for built-in file symbol 
It's currently defined in fstack.c, making it more prone to accidental
dropping. Let's not repeat the 0.3.9 scenario...
 2020-10-04 04:38:53 +02:00
ISSOtm 7c895f8a1b Fix diagnostic formatting 
Missing colon and space after the file stack
 2020-10-04 04:38:53 +02:00
ISSOtm 38bda7e1bb Fix string expansion reporting 
More expansions were allowed than the limit specified, and reporting code
did not account for the extra one that caused overflow
 2020-10-04 04:38:52 +02:00
ISSOtm 149db9a022 Fix incorrect freeing of expansions 
Freeing an expansion should free its children, not its siblings...
Fixes a use-after-free reported by scan-build. Nice catch!
 2020-10-04 04:38:52 +02:00
ISSOtm fed252bc49 Fix nested expansions being incorrectly handled 
The biggest problem was simply that the length of children expansions was
not accounted for when skipping over the parent... this took a lot of
arduous debugging, but it finally works!
 2020-10-04 04:38:52 +02:00
ISSOtm 61b2fd9816 Add string expansion reporting 
And fix line counting with expansion-made newlines.
This has the same bug as the old lexer (equs-newline's output does not
print the second warning as being part of the expansion).
Additionally, we regress equs-recursion, as we are no longer able to
catch this specific EQUS recursion. Simply enough, the new expansion
begins **after** the old one ends! I have found no way to handle that.
 2020-10-04 04:38:52 +02:00
ISSOtm 5ad7a93750 Add EQUS expansion 2020-10-04 04:38:52 +02:00
ISSOtm 2ec10012b6 Fix mmap read offset not being initialized 2020-10-04 04:38:52 +02:00
ISSOtm e56c6cc291 Fix PC's name not being passed to parser 2020-10-04 04:38:52 +02:00
ISSOtm 4c9a929a14 Implement almost all functionality 
Add keywords and identifiers
Add comments
Add number literals
Add strings
Add a lot of new tokens
Add (and clean up) IF etc.
Improve reporting of unexpected chars / garbage bytes
Fix bug with and improved error messages when failing to open file
Add verbose-level messages about how files are opened
Enforce that files finish with a newline
Fix chars returned not being cast to unsigned char (may conflict w/ EOF)
Return null path when no file is open, rather than crash
Unify and improve error printing slightly

Known to be missing: macro expansion, REPT blocks, EQUS expansions
 2020-10-04 04:38:50 +02:00
ISSOtm 71f8871702 Implement more functionality 
Macro arg detection, first emitted tokens, primitive (bad) column counting
 2020-10-04 04:37:58 +02:00
ISSOtm 6dc4ce6599 Implement infrastructure around new lexer 
The lexer itself is very much incomplete, but this is intended to be a
safe point to revert to should further implementation go south.
 2020-10-04 04:37:58 +02:00
Eldred Habert 3a44cc7722 Merge pull request #582 from ISSOtm/rewrite-charmap 
Rewrite charmap system
 2020-10-04 04:37:06 +02:00
ISSOtm 4cfed3c98f Rewrite charmap system 
Avoid allocating a *ton* of data per charmap
Stop relying on uninitialized data in charmap nodes
Only initialize charmap nodes lazily
 2020-10-04 04:31:10 +02:00
Eldred Habert 6af57ff026 Merge pull request #581 from JL2210/cmake-docs 
Install manpages with CMake
 2020-10-03 22:15:17 +02:00
ISSOtm 2e3db9d56a Clean up label generation 
Only check for localness when we already know we have a local
 2020-10-03 21:33:30 +02:00
ISSOtm f53ad359a6 Remove whoami step from Windows CI 
A carry-over from testing
 2020-10-03 02:17:18 +02:00
ISSOtm 84de86beb5 Enable make develop on Ubuntu 20.04 CI as well 2020-10-03 01:05:09 +02:00
Eldred Habert 04e7af2675 Merge pull request #579 from ISSOtm/cmake-ci 
Enable CMake in CI
 2020-10-02 23:30:26 +02:00
Eldred Habert 4f13a336b9 Merge pull request #578 from JL2210/cmake-pkgconfig 
Use pkg-config to detect libpng
 2020-10-02 22:30:30 +02:00
ISSOtm 03508119e5 Use CMake in CI as well 2020-10-02 22:24:02 +02:00
ISSOtm 8e4a9a5c21 Remove assertions from release builds 
I believe the CMakeLists already did that, but the Makefile did not.
 2020-09-27 17:05:52 +02:00
ISSOtm a1286e6f0e Make newlines explicit in error messages 
In preparation for a change a PR is about to make
 2020-09-27 10:54:06 +02:00
ISSOtm c0808246e5 Silence the mingw test 
Use "quiet" instead of "count"...
 2020-09-27 10:51:52 +02:00
ISSOtm ba051e10fb Factor printing assert failures into functions 
Saves some code duplication
 2020-09-27 09:24:24 +02:00
ISSOtm 9fee0603b1 Fix typo in object file format doc 
Thanks @ax6!
 2020-09-24 16:43:13 +02:00
ISSOtm be8ebe6db9 Fix master docs update CI script 
GitHub documentation about the syntax is unclear, this should be right
according to the examples I saw.
 2020-09-24 16:41:23 +02:00
ISSOtm 548e3dc31c Correct previously-introduced test being a no-op 
Forgot to invoke the macro due to a copy-paste error
 2020-09-24 16:35:45 +02:00
ISSOtm 9440086d77 Add a test for purging a macro while running 
This could cause a crash if the macro name is then used for error reporting
 2020-09-24 16:14:18 +02:00
ISSOtm ec5a1bc71f Fix incorrect obj file documentation 
Bit 7 of section types was actually documented in the symbol type
Bit 6 of section types was not documented at all
 2020-09-24 10:26:02 +02:00
ISSOtm 9742fa731c Run the quote in file name except on Windows 
This should make the CI function again
 2020-09-22 18:13:26 +02:00
ISSOtm 91a3c538d9 Enable running regression tests on PRs as well 2020-09-22 17:27:29 +02:00