Compare commits

..

2 Commits

Author SHA1 Message Date
Rangi
1eb4eb3339 Reuse the usage.name for printing version info 2025-11-18 22:32:45 -05:00
Rangi
a3d3e1525a Fix RGBLINK object type detection 2025-11-18 22:01:43 -05:00
5 changed files with 22 additions and 21 deletions

View File

@@ -296,7 +296,7 @@ static void parseArg(int ch, char *arg) {
// LCOV_EXCL_START
case 'V':
printf("rgbasm %s\n", get_package_version_string());
printf("%s %s\n", usage.name.c_str(), get_package_version_string());
exit(0);
case 'v':
@@ -381,7 +381,7 @@ static void verboseOutputConfig() {
style_Set(stderr, STYLE_MAGENTA, false);
fprintf(stderr, "rgbasm %s\n", get_package_version_string());
fprintf(stderr, "%s %s\n", usage.name.c_str(), get_package_version_string());
printVVVVVVerbosity();

View File

@@ -252,7 +252,7 @@ static void parseArg(int ch, char *arg) {
// LCOV_EXCL_START
case 'V':
printf("rgbfix %s\n", get_package_version_string());
printf("%s %s\n", usage.name.c_str(), get_package_version_string());
exit(0);
case 'v':

View File

@@ -409,7 +409,7 @@ static void parseArg(int ch, char *arg) {
// LCOV_EXCL_START
case 'V':
printf("rgbgfx %s\n", get_package_version_string());
printf("%s %s\n", usage.name.c_str(), get_package_version_string());
exit(0);
case 'v':
@@ -481,7 +481,7 @@ static void verboseOutputConfig() {
style_Set(stderr, STYLE_MAGENTA, false);
fprintf(stderr, "rgbgfx %s\n", get_package_version_string());
fprintf(stderr, "%s %s\n", usage.name.c_str(), get_package_version_string());
printVVVVVVerbosity();

View File

@@ -283,7 +283,7 @@ static void parseArg(int ch, char *arg) {
// LCOV_EXCL_START
case 'V':
printf("rgblink %s\n", get_package_version_string());
printf("%s %s\n", usage.name.c_str(), get_package_version_string());
exit(0);
case 'v':
@@ -330,7 +330,7 @@ static void verboseOutputConfig() {
style_Set(stderr, STYLE_MAGENTA, false);
fprintf(stderr, "rgblink %s\n", get_package_version_string());
fprintf(stderr, "%s %s\n", usage.name.c_str(), get_package_version_string());
printVVVVVVerbosity();

View File

@@ -420,19 +420,15 @@ void obj_ReadFile(std::string const &filePath, size_t fileID) {
}
Defer closeFile{[&] { fclose(file); }};
// First, check if the object is a RGBDS object or a SDCC one. If the first byte is 'R',
// we'll assume it's a RGBDS object file, and otherwise, that it's a SDCC object file.
int c = getc(file);
ungetc(c, file); // Guaranteed to work
switch (c) {
// First, check if the object is a RGBDS object, a SDCC one, or neither.
// A single `ungetc` is guaranteed to work.
switch (ungetc(getc(file), file)) {
case EOF:
fatal("File \"%s\" is empty!", fileName);
case 'R':
break;
default:
case 'X':
case 'D':
case 'Q': {
// This is (probably) a SDCC object file, defer the rest of detection to it.
// Since SDCC does not provide line info, everything will be reported as coming from the
// object file. It's better than nothing.
@@ -450,11 +446,16 @@ void obj_ReadFile(std::string const &filePath, size_t fileID) {
return;
}
// Begin by reading the magic bytes
int matchedElems;
case 'R':
// Check the magic byte signature for a RGB object file.
if (char magic[literal_strlen(RGBDS_OBJECT_VERSION_STRING)];
fread(magic, 1, sizeof(magic), file) == sizeof(magic)
&& !memcmp(magic, RGBDS_OBJECT_VERSION_STRING, sizeof(magic))) {
break;
}
[[fallthrough]];
if (fscanf(file, RGBDS_OBJECT_VERSION_STRING "%n", &matchedElems) == 1
&& matchedElems != literal_strlen(RGBDS_OBJECT_VERSION_STRING)) {
default:
fatal("%s: Not a RGBDS object file", fileName);
}