zone/OpenAssetTools
zone/OpenAssetTools
2
0
Fork 0
mirror of https://github.com/Laupetin/OpenAssetTools.git synced 2025-04-19 15:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: add unit test for ImageIwdPostProcessor

Browse Source
This commit is contained in:
Jan 2025-01-08 18:35:39 +01:00
parent 8c8ceae0bd
commit 3b5ca86b0d
No known key found for this signature in database
GPG Key ID: 44B581F78FF5C57C
4 changed files with 284 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ObjCompiling/Image/ImageIwdPostProcessor.cpp
View File

@ -4,7 +4,6 @@
#include <algorithm>
#include <format>
#include <ranges>
AbstractImageIwdPostProcessor::AbstractImageIwdPostProcessor(const ZoneDefinitionContext& zoneDefinition,
ISearchPath& searchPath,
@ -58,7 +57,7 @@ void AbstractImageIwdPostProcessor::PostProcessAsset(XAssetInfoGeneric& assetInf
while (m_current_iwd && m_zone_definition.m_asset_index_in_definition >= m_current_iwd_end_index)
FindNextObjContainer();
if (m_current_iwd && m_zone_definition.m_asset_index_in_definition <= m_current_iwd_start_index)
if (m_current_iwd && m_zone_definition.m_asset_index_in_definition >= m_current_iwd_start_index)
m_current_iwd->AddFile(std::format("images/{}.iwi", assetInfo.m_name));
}

5
src/ObjCompiling/Iwd/IwdCreator.cpp
View File

@ -79,6 +79,11 @@ void IwdToCreate::Build(ISearchPath& searchPath, IOutputPath& outPath)
std::cout << std::format("Created iwd {} with {} entries\n", m_name, m_file_paths.size());
}
const std::vector<std::string>& IwdToCreate::GetFilePaths() const
{
return m_file_paths;
}
IwdToCreate* IwdCreator::GetOrAddIwd(const std::string& iwdName)
{
const auto existingIwd = m_iwd_lookup.find(iwdName);

1
src/ObjCompiling/Iwd/IwdCreator.h
View File

@ -15,6 +15,7 @@ public:
void AddFile(std::string filePath);
void Build(ISearchPath& searchPath, IOutputPath& outPath);
[[nodiscard]] const std::vector<std::string>& GetFilePaths() const;
private:
std::string m_name;

277
test/ObjCompilingTests/Image/ImageIwdPostProcessorTest.cpp Normal file
View File

@ -0,0 +1,277 @@
#include "Image/ImageIwdPostProcessor.h"
#include "Game/T6/T6.h"
#include "SearchPath/MockOutputPath.h"
#include "SearchPath/MockSearchPath.h"
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <catch2/matchers/catch_matchers_floating_point.hpp>
#include <filesystem>
#include <memory>
using namespace T6;
using namespace std::string_literals;
namespace
{
class TestContext
{
public:
TestContext()
: m_zone("test", 0, IGame::GetGameById(GameId::T6)),
m_zone_definition(),
m_zone_definition_context(m_zone_definition),
m_zone_states(m_zone),
m_creators(m_zone),
m_ignored_assets(),
m_out_dir(),
m_context(m_zone, &m_creators, &m_ignored_assets),
m_iwd_creator(m_zone_states.GetZoneAssetCreationState<IwdCreator>())
{
}
std::unique_ptr<IAssetPostProcessor> CreateSut()
{
return std::make_unique<ImageIwdPostProcessor<AssetImage>>(m_zone_definition_context, m_search_path, m_zone_states, m_out_dir);
}
Zone m_zone;
ZoneDefinition m_zone_definition;
ZoneDefinitionContext m_zone_definition_context;
MockSearchPath m_search_path;
ZoneAssetCreationStateContainer m_zone_states;
AssetCreatorCollection m_creators;
IgnoredAssetLookup m_ignored_assets;
MockOutputPath m_out_dir;
AssetCreationContext m_context;
IwdCreator& m_iwd_creator;
};
} // namespace
namespace test::image
{
TEST_CASE("ImageIwdPostProcessor: Handles asset type of specified asset", "[image]")
{
TestContext testContext;
const auto sut = testContext.CreateSut();
REQUIRE(sut->GetHandlingAssetType() == ASSET_TYPE_IMAGE);
}
TEST_CASE("ImageIwdPostProcessor: Adds images to iwd when obj container is specified", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd", ZoneDefinitionObjContainerType::IWD, 0, 2);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
auto result = testContext.m_iwd_creator.GetOrAddIwd("testIwd");
REQUIRE(result);
const auto& filePaths = result->GetFilePaths();
REQUIRE(filePaths.size() == 2u);
REQUIRE(filePaths[0] == "images/testImage0.iwi");
REQUIRE(filePaths[1] == "images/testImage1.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Respects lower obj container boundary when adding images to iwd", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd", ZoneDefinitionObjContainerType::IWD, 1, 3);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset2(ASSET_TYPE_IMAGE, "testImage2", nullptr);
sut->PostProcessAsset(imageAsset2, testContext.m_context);
auto result = testContext.m_iwd_creator.GetOrAddIwd("testIwd");
REQUIRE(result);
const auto& filePaths = result->GetFilePaths();
REQUIRE(filePaths.size() == 2u);
REQUIRE(filePaths[0] == "images/testImage1.iwi");
REQUIRE(filePaths[1] == "images/testImage2.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Respects upper obj container boundary when adding images to iwd", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd", ZoneDefinitionObjContainerType::IWD, 0, 2);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset2(ASSET_TYPE_IMAGE, "testImage2", nullptr);
sut->PostProcessAsset(imageAsset2, testContext.m_context);
auto result = testContext.m_iwd_creator.GetOrAddIwd("testIwd");
REQUIRE(result);
const auto& filePaths = result->GetFilePaths();
REQUIRE(filePaths.size() == 2u);
REQUIRE(filePaths[0] == "images/testImage0.iwi");
REQUIRE(filePaths[1] == "images/testImage1.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Respects upper and lower obj container boundary when adding images to iwd", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd", ZoneDefinitionObjContainerType::IWD, 1, 3);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset2(ASSET_TYPE_IMAGE, "testImage2", nullptr);
sut->PostProcessAsset(imageAsset2, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset3(ASSET_TYPE_IMAGE, "testImage3", nullptr);
sut->PostProcessAsset(imageAsset3, testContext.m_context);
auto result = testContext.m_iwd_creator.GetOrAddIwd("testIwd");
REQUIRE(result);
const auto& filePaths = result->GetFilePaths();
REQUIRE(filePaths.size() == 2u);
REQUIRE(filePaths[0] == "images/testImage1.iwi");
REQUIRE(filePaths[1] == "images/testImage2.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Can add images to multiple iwd", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd0", ZoneDefinitionObjContainerType::IWD, 0, 2);
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd1", ZoneDefinitionObjContainerType::IWD, 2, 4);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset2(ASSET_TYPE_IMAGE, "testImage2", nullptr);
sut->PostProcessAsset(imageAsset2, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset3(ASSET_TYPE_IMAGE, "testImage3", nullptr);
sut->PostProcessAsset(imageAsset3, testContext.m_context);
auto result0 = testContext.m_iwd_creator.GetOrAddIwd("testIwd0");
REQUIRE(result0);
const auto& filePaths0 = result0->GetFilePaths();
REQUIRE(filePaths0.size() == 2u);
REQUIRE(filePaths0[0] == "images/testImage0.iwi");
REQUIRE(filePaths0[1] == "images/testImage1.iwi");
auto result1 = testContext.m_iwd_creator.GetOrAddIwd("testIwd1");
REQUIRE(result1);
const auto& filePaths1 = result1->GetFilePaths();
REQUIRE(filePaths1.size() == 2u);
REQUIRE(filePaths1[0] == "images/testImage2.iwi");
REQUIRE(filePaths1[1] == "images/testImage3.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Can add images to multiple iwd with gap between", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd0", ZoneDefinitionObjContainerType::IWD, 0, 2);
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd1", ZoneDefinitionObjContainerType::IWD, 3, 5);
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset2(ASSET_TYPE_IMAGE, "testImage2", nullptr);
sut->PostProcessAsset(imageAsset2, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset3(ASSET_TYPE_IMAGE, "testImage3", nullptr);
sut->PostProcessAsset(imageAsset3, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset4(ASSET_TYPE_IMAGE, "testImage4", nullptr);
sut->PostProcessAsset(imageAsset4, testContext.m_context);
auto result0 = testContext.m_iwd_creator.GetOrAddIwd("testIwd0");
REQUIRE(result0);
const auto& filePaths0 = result0->GetFilePaths();
REQUIRE(filePaths0.size() == 2u);
REQUIRE(filePaths0[0] == "images/testImage0.iwi");
REQUIRE(filePaths0[1] == "images/testImage1.iwi");
auto result1 = testContext.m_iwd_creator.GetOrAddIwd("testIwd1");
REQUIRE(result1);
const auto& filePaths1 = result1->GetFilePaths();
REQUIRE(filePaths1.size() == 2u);
REQUIRE(filePaths1[0] == "images/testImage3.iwi");
REQUIRE(filePaths1[1] == "images/testImage4.iwi");
}
TEST_CASE("ImageIwdPostProcessor: Writes Iwd when finalizing", "[image]")
{
TestContext testContext;
testContext.m_zone_definition.m_obj_containers.emplace_back("testIwd", ZoneDefinitionObjContainerType::IWD, 0, 2);
testContext.m_search_path.AddFileData("images/testImage0.iwi", "asdf0");
testContext.m_search_path.AddFileData("images/testImage1.iwi", "asdf1");
const auto sut = testContext.CreateSut();
XAssetInfo<GfxImage> imageAsset0(ASSET_TYPE_IMAGE, "testImage0", nullptr);
sut->PostProcessAsset(imageAsset0, testContext.m_context);
++testContext.m_zone_definition_context.m_asset_index_in_definition;
XAssetInfo<GfxImage> imageAsset1(ASSET_TYPE_IMAGE, "testImage1", nullptr);
sut->PostProcessAsset(imageAsset1, testContext.m_context);
sut->FinalizeZone(testContext.m_context);
const auto* mockFile = testContext.m_out_dir.GetMockedFile("testIwd.iwd");
REQUIRE(mockFile);
}
} // namespace test::image