zone/OpenAssetTools
2
0
Fork 0
mirror of https://github.com/Laupetin/OpenAssetTools.git synced 2026-08-23 07:24:29 +00:00
Code Activity

chore!: change unlinker output default (#958)

Browse Source 
* chore!: change default --output-folder of Unlinker

* chore: log where the zone is being dumped to
This commit is contained in:
Jan Laupetin
2026-08-08 07:33:28 +02:00
committed by GitHub
parent 7d8611893d
commit ec5aa248c3
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Unlinking/Unlinker.cpp
+1
View File
@@ -254,6 +254,7 @@ namespace
auto* objWriter = IObjWriter::GetObjWriterForGame(zone.m_game_id); auto* objWriter = IObjWriter::GetObjWriterForGame(zone.m_game_id);
con::info("Dumping zone {} into folder \"{}\"", zone.m_name, outputFolderPath.string());
auto result = objWriter->DumpZone(context); auto result = objWriter->DumpZone(context);
if (m_args.m_use_gdt) if (m_args.m_use_gdt)
src/Unlinking/UnlinkerArgs.h
+1 -1
View File
@@ -13,7 +13,7 @@
class UnlinkerArgs class UnlinkerArgs
{ {
public: public:
static constexpr const char* DEFAULT_OUTPUT_FOLDER = "zone_dump/zone_raw/?zone?"; static constexpr const char* DEFAULT_OUTPUT_FOLDER = "zone_dump/?game?/?zone?";
private: private:
ArgumentParser m_argument_parser; ArgumentParser m_argument_parser;
test/UnlinkingTests/UnlinkerArgsTests.cpp
+3 -3
View File
@@ -20,7 +20,7 @@ namespace
REQUIRE(args.m_output_folder == UnlinkerArgs::DEFAULT_OUTPUT_FOLDER); REQUIRE(args.m_output_folder == UnlinkerArgs::DEFAULT_OUTPUT_FOLDER);
const Zone zone("test_zone", 0, GameId::IW4, GamePlatform::PC); const Zone zone("test_zone", 0, GameId::IW4, GamePlatform::PC);
REQUIRE(args.GetOutputFolderPathForZone(zone) == "zone_dump/zone_raw/test_zone"); REQUIRE(args.GetOutputFolderPathForZone(zone) == "zone_dump/iw4/test_zone");
} }
TEST_CASE("Unlinker output folder remains unchanged without placeholders", "[unlinker][arguments]") TEST_CASE("Unlinker output folder remains unchanged without placeholders", "[unlinker][arguments]")
@@ -36,10 +36,10 @@ namespace
TEST_CASE("Unlinker output folder replaces game and zone placeholders", "[unlinker][arguments]") TEST_CASE("Unlinker output folder replaces game and zone placeholders", "[unlinker][arguments]")
{ {
UnlinkerArgs args; UnlinkerArgs args;
args.m_output_folder = "zone_dump/?game?/?zone?"; args.m_output_folder = "zone_dump/?game?/?game?/?zone?";
const Zone zone("test_zone", 0, GameId::IW4, GamePlatform::PC); const Zone zone("test_zone", 0, GameId::IW4, GamePlatform::PC);
REQUIRE(args.GetOutputFolderPathForZone(zone) == "zone_dump/iw4/test_zone"); REQUIRE(args.GetOutputFolderPathForZone(zone) == "zone_dump/iw4/iw4/test_zone");
} }
} // namespace } // namespace