Commit Graph

186 Commits

Author SHA1 Message Date
Giulia Sanguineti
4c8d3e962f chore: fix bugs
Some checks failed
CI / build (push) Failing after 1m18s
2025-10-01 10:11:42 +02:00
Linus Unnebäck
b1f8d423a2 Inline NoSwarmWildmon label (#1199) 2025-08-15 16:08:52 -04:00
Linus Unnebäck
b0d56dff91 Document time of day bug in RandomUnseenWildMon (#1196) 2025-08-03 13:57:07 -04:00
Rangi42
5abf8d01fb Update hardware.inc to 5.1.0 2025-06-30 12:47:36 -04:00
Rangi
4c540aa43b Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Rangi
85ddf0e90a Don't pass redundant label names to table_width and list_start (#1160) 2024-12-27 12:35:35 -05:00
Rangi42
41045d0266 Crystal-only jumptable exit bits 2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0 Identify more bit flags (#1153) 2024-11-29 19:29:30 -05:00
Sylvie
4d0e928c6f Label the unused daily flag (#1143) 2024-09-26 00:17:12 -04:00
Sylvie
8819f7b117 Identify various "????"s (#1125) 2024-06-11 20:54:45 -04:00
Idain
4432df05cb Add more assert cases in the codebase (#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:17:07 -05:00
vulcandth
b0b5ed2eb8 Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
xCrystal
17d3a1a8ae Address PR suggestions (#1078) 2024-01-28 21:19:32 +01:00
xCrystal
e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal
7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal
f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal
cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
2024-01-07 13:36:28 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi
dbf6044650 Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
Tiddlywinks
b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
Idain
94df3c5aa3 Replace magic numbers with TILE_WIDTH (#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-26 19:50:16 -05:00
vulcandth
438c48daad Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
vulcandth
c01409be5a Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
vulcandth
c4e3f2bbc2 TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020) 2022-11-22 21:03:24 -05:00
vulcandth
f7d26fbe9c .CheckNPC label and comment correction 2022-11-07 20:27:09 -06:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi
41d5ea0482 Rename the object_struct field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
Colton G. Rushton
145d8dd5c2 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437 Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Colton G. Rushton
84a3b335aa Document that farcall returns c in a for some code (#937) 2022-06-17 22:30:53 -04:00
vulcandth
3648afda16 RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
vulcandth
31c3c94d64 Build the Virtual Console patch with make crystal11_vc (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
Idain
5ac4a51751 Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Rangi
e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi
f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi
e4d82e92d0 Rename prioritysjump to sdefer 2021-06-08 20:35:04 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
dc18e188b2 Sync some files with pokegold 2021-03-24 10:24:52 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
6c8f8609cb Assert some more table widths 2021-03-17 11:38:01 -04:00
Rangi
ec1fe073a3 $11 = wTempMonStructEnd - wTempMonLevel 2021-03-15 15:40:48 -04:00
Rangi
97a11c623e Sync some files with pokegold 2021-03-11 17:43:20 -05:00
Rangi
d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi
dbabd8b4a9 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:16:54 -05:00
Rangi
e791c5392b Merge pull request #806 from Rangi42/tables
Verify data table sizes with table_width and assert_table_length macros
2021-03-08 07:01:31 -08:00
Rangi
c1c609ec4a Identify scrolling menu lists in WRAM
Fixes #809
2021-03-08 09:41:55 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00