Rangi42
de396249e1
Use combined joypad masks
2025-06-30 12:47:36 -04:00
Rangi42
5abf8d01fb
Update hardware.inc to 5.1.0
2025-06-30 12:47:36 -04:00
Rangi
4c540aa43b
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 ( #1186 )
2025-06-23 09:11:33 -04:00
Rangi
b035d9fb89
Define constants for wBillsPCPokemonList
entries ( #1183 )
2025-05-31 15:07:44 -04:00
Brianum
f480cb9e24
Rename and document `BrokenPlacePPUnits
` ( #1179 )
2025-04-29 08:18:10 +02:00
Rangi
85ddf0e90a
Don't pass redundant label names to table_width
and list_start
( #1160 )
2024-12-27 12:35:35 -05:00
Rangi42
41045d0266
Crystal-only jumptable exit bits
2024-12-02 12:16:30 -05:00
Rangi42
e1e7cbd838
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F
2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0
Identify more bit flags ( #1153 )
2024-11-29 19:29:30 -05:00
abcboy101
2408579942
Correct European mail documentation ( #1142 )
2024-09-26 00:20:30 -04:00
Sylvie
8819f7b117
Identify various "????"s ( #1125 )
2024-06-11 20:54:45 -04:00
Idain
4432df05cb
Add more assert cases in the codebase ( #1115 )
...
* Add assert for FACING_GRASS_1 and FACING_GRASS_2
* Add more assert cases
* Add assert for HP bar colors
* Assert LINK_NULL == 0
* Fix assert syntax
* Add asserts for WILD_BATTLE == 1
* Add additional WILD assert
- I need to sleep more...
* Revert asserts for WILD_BATTLE and LINK_NULL
* Commit suggested changes
* Add more assert cases
* Fix syntax error
2024-04-27 12:17:07 -05:00
SnorlaxMonster
b9dce73573
Rename MON_ID
to MON_OT_ID
( #1114 )
...
* Rename MON_ID to MON_TRAINER_ID
The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.
The original definition of MON_ID is preserved in macros/legacy.asm
* Remove MON_ID from macros/legacy.asm
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com >
* Apply rename to missed file
* Rename to `MON_OT_ID`
---------
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com >
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com >
Co-authored-by: vulcandth <vulcandth@gmail.com >
2024-04-27 12:16:34 -05:00
vulcandth
b0b5ed2eb8
Fix/update sprite y-coord offscreen definitions ( #1108 )
2024-04-14 15:55:46 -05:00
xCrystal
7f3b87950a
more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap ( #1078 )
2024-01-07 14:37:46 +01:00
xCrystal
f72f078c0e
Rename wVramState to wStateFlags and use flag constants ( #1078 )
2024-01-07 14:27:22 +01:00
xCrystal
5be9856f3a
In labels, stick to Place for text without delay, and Print for text with letter delay ( #1078 )
2024-01-07 14:06:40 +01:00
xCrystal
bd6ceec193
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371 ]
2024-01-07 13:36:05 +01:00
vulcandth
aba1f14044
Sync sprite and battle anim consts/labels ( #1055 )
...
* Sync sprite and battle anim consts/labels
* Add `; 00` comments
* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
Idain
94df3c5aa3
Replace magic numbers with TILE_WIDTH ( #1056 )
...
* Replace magic numbers with TILE_WIDTH
* Address more instances
2023-07-26 19:50:16 -05:00
Idain
5e983d32aa
Use NO_INPUT instead of magic number ( #1051 )
...
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
2023-05-28 09:12:33 -05:00
mid-kid
a6ac67dea2
IsMailEuropean → ParseMailLanguage (and give it constants)
2023-04-19 19:12:14 +02:00
mid-kid
cf1c505555
GetNicknamenamePointer -> GetNicknamePointer
...
Found this commit on an old drive
2023-02-26 12:28:06 +01:00
Idain
a9869f1896
Replace hardcoded wMonType constants ( #1011 )
2022-09-28 19:51:39 -05:00
Rangi
4883950318
Use for
loops to generate box pointer tables
...
Fixes #996
2022-08-31 18:03:49 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM ( #971 )
2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com >
2022-07-09 16:12:02 -05:00
Rangi
a1498e63e2
Rename search.asm and search2.asm
2022-06-17 23:27:53 -04:00
vulcandth
66d84ff021
MobileCheckOwnMonAnywhere
& CheckOwnMonAnywhere
Label, comments, formatting (#927 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com >
2022-06-17 23:21:08 -04:00
vulcandth
5f0597e944
Rename SLP
to SLP_MASK
( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com >
2022-06-17 22:25:56 -04:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers ( #907 )
2022-06-06 17:22:48 -04:00
Idain
dc121712fe
Fix misspelled label ( #904 )
2022-04-17 11:36:30 -04:00
Idain
9b4ebe9400
Replace magic numbers with constants ( #894 )
2022-03-20 19:58:18 -04:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc
( #882 )
...
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
Rangi
187b120007
Add assertions to some more tables
2021-10-24 18:28:54 -04:00
Rangi
f59f1bdb88
Standardize capitalization of ".Jumptable"
2021-06-19 19:52:05 -04:00
Rangi
a41dac9a2f
"ld [MON_LEVEL], a" in ComputeNPCTrademonStats should be "ld [wCurPartyLevel], a"
2021-06-07 19:36:03 -04:00
Rangi
316fa4b695
Use rgbds 0.5.0
2021-04-19 16:31:37 -04:00
Rangi
dc18e188b2
Sync some files with pokegold
2021-03-24 10:24:52 -04:00
Rangi
0506e5b1b9
Assert the sBox1-14 tables have NUM_BOXES entries
2021-03-21 17:47:53 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
c1c609ec4a
Identify scrolling menu lists in WRAM
...
Fixes #809
2021-03-08 09:41:55 -05:00
Rangi
287d893d22
Use PARTY_LENGTH and MAILBOX_CAPACITY constants
2021-02-10 08:50:39 -05:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
5db892782a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:28 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
fa3712ea34
Remove "XXX" comments (various "???+" still mark unclear code)
2020-11-09 16:38:11 -05:00