Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,216 Commits 1 Branch 0 Tags
b39cdd6c97a8d23ee92d64b4337751dfeb66ba58
Commit Graph

274 Commits

Author SHA1 Message Date
Rangi
efceed1338 Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) (#1184) 2025-05-31 15:07:56 -04:00
Rangi
fd2af282b6 Add a CANNOT_MOVE constant (#1182) 2025-05-31 15:07:34 -04:00
Hannabart Pekopon
34aae0d20f Added bug fix for: "Cautious" AI may fail to discourage residual moves (#1178) 2025-05-31 15:07:23 -04:00
Jordan Moore
86a87a355e Remove "skip" prefix from AI move score labels (#1163) 2024-12-29 15:31:50 -05:00
Hannabart Pekopon
3f686e67da Correct wrong and misleading comments about enemy trainer AI (#1149) 2024-12-26 08:59:18 -05:00
Rangi
61c9ba5f6c Use RGBDS 0.9.0 (#1159) 2024-12-25 21:24:37 -05:00
Jordan Moore
d323aa83dd Rename checkcurl to checkrollout 2024-12-25 12:17:14 +01:00
Rangi42
cbfd48b8d1 Use SERIAL_RNS_LENGTH in _BattleRandom 2024-12-21 21:04:21 -05:00
Rangi42
e1e7cbd838 Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F 2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0 Identify more bit flags (#1153) 2024-11-29 19:29:30 -05:00
Rangi42
961fad9e15 Fix AI_Smart_Curse labels 
Fixes #1130
 2024-10-17 17:12:19 -04:00
vulcandth
9ae05312d6 Use NUM_TRAINER_ATTRIBUTES const in AI scoring Layers 2024-07-27 21:58:54 -05:00
Rangi42
4f57e96f31 Consolidate the duplicate stat level data files 2024-06-12 13:13:58 -04:00
Rangi42
b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
Idain
4432df05cb Add more assert cases in the codebase (#1115) 
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
 2024-04-27 12:17:07 -05:00
SnorlaxMonster
b9dce73573 Rename MON_ID to MON_OT_ID (#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:16:34 -05:00
xCrystal
5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-07 13:36:05 +01:00
Rangi42
804fa846e0 Fix bug doc formatting 2024-01-01 21:47:57 -05:00
SoupPotato
184c53e8ca Document SFX_RUN does not play correctly when a wild Pokemon flees from battle (#1099) 
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
 2024-01-01 20:25:30 -06:00
Idain
3866716980 Use proper constant for battle stats (#1088) 2023-10-23 14:06:04 -05:00
Idain
5db85badf8 Replace hardcoded numbers for stats (#1073) 2023-08-21 10:53:32 -05:00
Idain
6926900f0f Document fix about AI item pointer overflowing (#1066) 2023-08-10 13:29:03 -04:00
SatoMew
768b3bdec1 Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster
c931b98a81 Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-26 19:51:34 -05:00
Idain
94df3c5aa3 Replace magic numbers with TILE_WIDTH (#1056) 
* Replace magic numbers with TILE_WIDTH

* Address more instances
 2023-07-26 19:50:16 -05:00
vulcandth
25e12c9391 wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
vulcandth
b232b4be5f Bug: PRZ and BRN stat reductions don't apply to switched Pokémon (#1021) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-12-01 16:54:01 -05:00
Idain
a9869f1896 Replace hardcoded wMonType constants (#1011) 2022-09-28 19:51:39 -05:00
Rangi
f7507b7782 $f -> BATTLEACTION_FORFEIT 
(thanks, Vulcandth)
 2022-09-23 23:10:24 -04:00
Idain
bc4fec0694 Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi
07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Colton G. Rushton
145d8dd5c2 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437 Clean up bugs commented in the source code (#912) 
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
 2022-07-09 16:12:02 -05:00
vulcandth
5f0597e944 Rename SLP to SLP_MASK (#918) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 22:25:56 -04:00
vulcandth
73c020074e Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth
3648afda16 RGBDS syntax updates (#905) 
New MACRO and DEF syntax
 2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Idain
b06cfe78fd Use NUM_BATTLE_STATS instead of raw numbers 2022-04-06 10:28:18 +00:00
vulcandth
31c3c94d64 Build the Virtual Console patch with make crystal11_vc (#882) 
Fixes #813
 2022-03-12 18:34:04 -05:00
mid-kid
418b73bc6d Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:30:57 +01:00
Idain
e949477089 Document Return/Frustration bug and its fix (#872) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-01-24 20:48:21 -05:00
Rangi
0ffdb65210 Better comments for enemy health percentage code 2022-01-10 21:25:43 -05:00
Idain
67207fab94 Identify why five of six enemy mon base stats are copied (#866) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-01-08 13:42:40 -05:00
Rangi
e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
IIMarckus
a283f44954 More EFFECTIVEness. 2021-08-16 14:44:57 -06:00
IIMarckus
52290d8e03 Use EFFECTIVE constant for 1.0× battle damage. 2021-08-16 14:42:45 -06:00
Nescientist
80a3f7e1ba Fixing comments in BattleCommand_Teleport 2021-06-20 10:56:11 -04:00
Rangi
1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi
efd1006917 Use {interpolation} to generate sequences of RAM labels 
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
 2021-04-27 12:11:39 -04:00