Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,150 Commits 1 Branch 0 Tags
de0d5c29e536101845cb1ecee7055dcd2572cb94
Commit Graph

1434 Commits

Author SHA1 Message Date
Rangi42
de0d5c29e5 wPrinterQueueLength values are divisible by 2 2024-05-22 21:02:55 -04:00
Rangi42
b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
Idain
4432df05cb Add more assert cases in the codebase (#1115) 
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
 2024-04-27 12:17:07 -05:00
SnorlaxMonster
b9dce73573 Rename MON_ID to MON_OT_ID (#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:16:34 -05:00
vulcandth
b0b5ed2eb8 Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
xCrystal
17d3a1a8ae Address PR suggestions (#1078) 2024-01-28 21:19:32 +01:00
xCrystal
e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal
7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal
f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal
5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal
cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-07 13:36:28 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-07 13:36:05 +01:00
Rangi
dbf6044650 Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
Idain
bbfb4ab60e Fix magic numbers in Celebi event code 2024-01-03 15:34:29 +01:00
Rangi42
804fa846e0 Fix bug doc formatting 2024-01-01 21:47:57 -05:00
SoupPotato
184c53e8ca Document SFX_RUN does not play correctly when a wild Pokemon flees from battle (#1099) 
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
 2024-01-01 20:25:30 -06:00
SnorlaxMonster
a82dfd81bb Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
Idain
2907d65a47 Improve use of palette macro and use PAL_* constants (#1087) 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 12:24:09 -06:00
SnorlaxMonster
75f0ad3955 Correct macro for default Mystery Gift item (#1084) 
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-11-17 12:18:49 -06:00
Idain
3866716980 Use proper constant for battle stats (#1088) 2023-10-23 14:06:04 -05:00
vulcandth
aba1f14044 Sync sprite and battle anim consts/labels (#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 13:09:28 -05:00
Tiddlywinks
b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
SoupPotato
6180be355e Labeled framesets and related constants (#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:09:23 -05:00
Idain
5db85badf8 Replace hardcoded numbers for stats (#1073) 2023-08-21 10:53:32 -05:00
Idain
6926900f0f Document fix about AI item pointer overflowing (#1066) 2023-08-10 13:29:03 -04:00
SatoMew
768b3bdec1 Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster
c931b98a81 Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-26 19:51:34 -05:00
Idain
94df3c5aa3 Replace magic numbers with TILE_WIDTH (#1056) 
* Replace magic numbers with TILE_WIDTH

* Address more instances
 2023-07-26 19:50:16 -05:00
vulcandth
438c48daad Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
Idain
5e983d32aa Use NO_INPUT instead of magic number (#1051) 
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
 2023-05-28 09:12:33 -05:00
mid-kid
354fefaefb Use time capsule label for time capsule copies 2023-04-19 19:12:14 +02:00
mid-kid
a1e711b80d Use more appropriate labels for link operations 2023-04-19 19:12:14 +02:00
mid-kid
4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid
5ae35e5770 Label wOTLinkBattleRNData 2023-04-19 19:12:14 +02:00
mid-kid
08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid
c8e9a82190 Make wMysteryGift*GameVersion constants consistent 2023-04-19 19:12:14 +02:00
mid-kid
a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00
mid-kid
cfd432f468 Minor battle tower fixes 2023-03-08 13:52:47 +01:00
mid-kid
cf1c505555 GetNicknamenamePointer -> GetNicknamePointer 
Found this commit on an old drive
 2023-02-26 12:28:06 +01:00
vulcandth
c01409be5a Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
vulcandth
cb8505e022 Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391 wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
vulcandth
f739f8b1ac Add table assert DoBattleAnimFrame.Jumptable 2022-12-23 18:48:14 -06:00
Rangi
4387298b2c Comment the Crystal 1.0 bugs as "BUG:" too 2022-12-14 22:30:20 -05:00
vulcandth
b232b4be5f Bug: PRZ and BRN stat reductions don't apply to switched Pokémon (#1021) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-12-01 16:54:01 -05:00
vulcandth
c4e3f2bbc2 TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020) 2022-11-22 21:03:24 -05:00
vulcandth
f7d26fbe9c .CheckNPC label and comment correction 2022-11-07 20:27:09 -06:00
Idain
a95336d9e7 Fix Spelling Typos in engine/battle_anims/functions.asm 2022-10-16 23:16:12 -05:00
Rangi
ce004be92c Revise constants in CheckShininess 2022-10-12 21:41:08 -04:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00