Commit Graph

1470 Commits

Author SHA1 Message Date
Brianum
b8d0c93213 Make town map limits more intuitive (#1185) 2025-06-07 13:51:32 -04:00
Rangi
efceed1338 Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) (#1184) 2025-05-31 15:07:56 -04:00
Rangi
b035d9fb89 Define constants for wBillsPCPokemonList entries (#1183) 2025-05-31 15:07:44 -04:00
Rangi
fd2af282b6 Add a CANNOT_MOVE constant (#1182) 2025-05-31 15:07:34 -04:00
Hannabart Pekopon
34aae0d20f Added bug fix for: "Cautious" AI may fail to discourage residual moves (#1178) 2025-05-31 15:07:23 -04:00
Brianum
f480cb9e24 Rename and document `BrokenPlacePPUnits` (#1179) 2025-04-29 08:18:10 +02:00
Rangi42
098944485b Rename "city" treemon set to "none", since it has no encounters 2025-04-21 12:42:57 -04:00
Rangi42
b4fc71cba1 Verify the battle BG effect pointer table length 2025-03-15 01:23:04 -04:00
Rangi42
467ee7ee72 Sync further with pokegold 2025-03-15 01:03:28 -04:00
Rangi42
94c36a4351 Verify the trade dialog pointer table length 2025-03-15 00:49:14 -04:00
Rangi42
1cc2216ef9 Verify the mart types pointer table length 2025-03-15 00:44:33 -04:00
Rangi42
15ae47a61e Separate constants for name types and naming screen types 2025-03-12 12:26:21 -04:00
Rangi
4d6c3e2975 Avoid using EQUS when EQU or MACRO will do (#1166) 2025-02-27 13:07:12 -05:00
Darsh
7a7a06289c Add assert to note _CGB_Diploma also loads PartyMenuOBPals (#1167) 2025-02-24 12:40:50 -05:00
Jordan Moore
86a87a355e Remove "skip" prefix from AI move score labels (#1163) 2024-12-29 15:31:50 -05:00
Rangi
85ddf0e90a Don't pass redundant label names to table_width and list_start (#1160) 2024-12-27 12:35:35 -05:00
Hannabart Pekopon
3f686e67da Correct wrong and misleading comments about enemy trainer AI (#1149) 2024-12-26 08:59:18 -05:00
Rangi
61c9ba5f6c Use RGBDS 0.9.0 (#1159) 2024-12-25 21:24:37 -05:00
Jordan Moore
d323aa83dd Rename checkcurl to checkrollout 2024-12-25 12:17:14 +01:00
Rangi42
cbfd48b8d1 Use SERIAL_RNS_LENGTH in _BattleRandom 2024-12-21 21:04:21 -05:00
Rangi42
99af3f4f3b Identify some missed bit 7 menu flags 2024-12-02 12:20:52 -05:00
Rangi42
41045d0266 Crystal-only jumptable exit bits 2024-12-02 12:16:30 -05:00
Rangi42
e1e7cbd838 Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F 2024-12-02 12:16:30 -05:00
Sylvie
644bd42fb0 Identify more bit flags (#1153) 2024-11-29 19:29:30 -05:00
Jordan Moore
8894e29da2 Add documentation for HideHeadbuttTree (#1152) 2024-11-28 11:20:15 -05:00
Rangi42
961fad9e15 Fix AI_Smart_Curse labels
Fixes #1130
2024-10-17 17:12:19 -04:00
SnorlaxMonster
0ebea8cfe1 Correct Moon Ball bug documentation (#1133) 2024-10-17 17:00:59 -04:00
duckie
1febb75bf9 Update mislabeled sweet_scent.asm subroutine (#1140) 2024-10-17 16:57:59 -04:00
Sylvie
2265e53d24 Rename dt and dd to bigdt and bigdd (#1141)
This makes their big-endianness obvious and matches `bigdw`
2024-10-17 14:52:47 -04:00
abcboy101
2408579942 Correct European mail documentation (#1142) 2024-09-26 00:20:30 -04:00
Sylvie
4d0e928c6f Label the unused daily flag (#1143) 2024-09-26 00:17:12 -04:00
vulcandth
9ae05312d6 Use NUM_TRAINER_ATTRIBUTES const in AI scoring Layers 2024-07-27 21:58:54 -05:00
Sylvie
fed587fc37 Refactor the Unown wall word data (#1131) 2024-07-24 10:56:46 -04:00
Rangi42
4f57e96f31 Consolidate the duplicate stat level data files 2024-06-12 13:13:58 -04:00
Sylvie
8819f7b117 Identify various "????"s (#1125) 2024-06-11 20:54:45 -04:00
Rangi42
23183bb9bb Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:37 -04:00
Rangi42
de0d5c29e5 wPrinterQueueLength values are divisible by 2 2024-05-22 21:02:55 -04:00
Rangi42
b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
Idain
4432df05cb Add more assert cases in the codebase (#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:17:07 -05:00
SnorlaxMonster
b9dce73573 Rename MON_ID to MON_OT_ID (#1114)
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2024-04-27 12:16:34 -05:00
vulcandth
b0b5ed2eb8 Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
xCrystal
17d3a1a8ae Address PR suggestions (#1078) 2024-01-28 21:19:32 +01:00
xCrystal
e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal
7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal
f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal
5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal
cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
2024-01-07 13:36:28 +01:00
xCrystal
bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi
dbf6044650 Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
Idain
bbfb4ab60e Fix magic numbers in Celebi event code 2024-01-03 15:34:29 +01:00